Re: [PATCH v9 5/5] net/enetfec: add features

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 11/10/2021 7:48 AM, Apeksha Gupta wrote:
> This patch adds checksum and VLAN offloads in enetfec network
> poll mode driver.
> 
> Signed-off-by: Sachin Saxena <sachin.saxena@nxp.com>
> Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>

<...>

> @@ -191,7 +195,12 @@ enet_free_buffers(struct rte_eth_dev *dev)
>   static int
>   enetfec_eth_configure(struct rte_eth_dev *dev)
>   {
> -	if (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_KEEP_CRC)

Instead of first adding 'DEV_RX_OFFLOAD_KEEP_CRC' and later fixing it in this
patch, correct macro should be added at first place.

<...>

> @@ -86,6 +93,48 @@ enetfec_recv_pkts(void *rxq1, __rte_unused struct rte_mbuf **rx_pkts,
>   
>   		rx_pkts[pkt_received] = mbuf;
>   		pkt_received++;
> +
> +		/* Extract the enhanced buffer descriptor */
> +		ebdp = NULL;
> +		if (rxq->fep->bufdesc_ex)
> +			ebdp = (struct bufdesc_ex *)bdp;
> +
> +		/* If this is a VLAN packet remove the VLAN Tag */
> +		vlan_packet_rcvd = false;
> +		if ((rx_offloads & DEV_RX_OFFLOAD_VLAN) &&

Can you please use updated macro: RTE_ETH_RX_OFFLOAD_VLAN