From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: Chaoyong He <chaoyong.he@corigine.com>, <dev@dpdk.org>
Cc: <oss-drivers@corigine.com>, <niklas.soderlund@corigine.com>,
James Hershaw <james.hershaw@corigine.com>
Subject: Re: [PATCH] net/nfp: improve readability NFP HWINFO header
Date: Tue, 20 Sep 2022 18:33:02 +0100 [thread overview]
Message-ID: <e1504cf6-d40f-c330-202b-82749ac141cf@xilinx.com> (raw)
In-Reply-To: <1661492343-23225-1-git-send-email-chaoyong.he@corigine.com>
On 8/26/2022 6:39 AM, Chaoyong He wrote:
> From: James Hershaw <james.hershaw@corigine.com>
>
> Prepend `0x` to the NFP HWINFO header value that is printed to improve
> the readability of the printed statement.
>
> Signed-off-by: James Hershaw <james.hershaw@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> ---
> drivers/net/nfp/nfpcore/nfp_hwinfo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/nfp/nfpcore/nfp_hwinfo.c b/drivers/net/nfp/nfpcore/nfp_hwinfo.c
> index c0516bf..9f848bd 100644
> --- a/drivers/net/nfp/nfpcore/nfp_hwinfo.c
> +++ b/drivers/net/nfp/nfpcore/nfp_hwinfo.c
> @@ -108,7 +108,7 @@
> goto exit_free;
>
> header = (void *)db;
> - printf("NFP HWINFO header: %08x\n", *(uint32_t *)header);
> + printf("NFP HWINFO header: %#08x\n", *(uint32_t *)header);
Why driver is directly using 'printf', but not rte_log APIs?
I can see there are already 'PMD_INIT_LOG' & 'PMD_DRV_LOG' macros for this.
next prev parent reply other threads:[~2022-09-20 17:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 5:39 Chaoyong He
2022-09-20 9:58 ` Niklas Söderlund
2022-09-20 17:33 ` Ferruh Yigit [this message]
2022-09-20 17:51 ` Niklas Söderlund
2022-09-20 18:01 ` Ferruh Yigit
2022-09-21 7:19 ` Niklas Söderlund
2022-09-21 8:09 ` Ferruh Yigit
2022-09-21 8:35 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1504cf6-d40f-c330-202b-82749ac141cf@xilinx.com \
--to=ferruh.yigit@xilinx.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=james.hershaw@corigine.com \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).