From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96F80A00C3; Tue, 20 Sep 2022 19:33:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B8F040DFB; Tue, 20 Sep 2022 19:33:09 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2045.outbound.protection.outlook.com [40.107.223.45]) by mails.dpdk.org (Postfix) with ESMTP id 326C14069B for ; Tue, 20 Sep 2022 19:33:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NtTsBI0t6T3YLjraJ2Ujkq07rHkh/4ws8hXMSwtZs52s17y25vuc/gFmhy8n/+2J8v+UvpeOAuaYIguCbV0MQalSKA7RZ1aqXc9xssLqzz+ycpo6AmsoMB8+OGA0H/agSexI0E0+F6XdZbKW4HGbekpG5BI4io1Ve9+CLZi0tgScDNGLoFCv4OD4JBfmRlvt5DaTXGeS8HY9JALYF2w4qx5gDjvWeVsXtR8tSYs4W/Wb4N4apbq95BJjJWAlq1AxF2raI5cRu/vk5mrMV7L2Xhcsm0x2t7tpEU47Fp8E5HjknQwpcAq3SGlih1GmGpSGkCn4U50Aif3J3d40ymlm6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IqFQQD6XUCSztz/+YwE4KW2vMEua06B1m7wnu06QkJQ=; b=oSeG150LC6Fd+sOJRZCTp9ZiWa6YW+uMaSGi03Ee+drOrc6r0dcsSz2cO23iYy64miNFWH//Zv3GrbEB8Mpp2O7g+cIuxTBjyWfZSstZyEskN4HIAwxkVvES2xJhRiDDBG6OKpyceqYXtIOX0FYj7+3HxTSXaO0irJR+W/fA/NPtcnPTz+rI1Dk35CuP/cD6cAqasfhgdYBZJVBEvC4CmIvXf2xRfDpTJC8IQ0NhOI2SYDwutGzP1tZfgcGWlZR105rDq9KKpOMNTVB9n0cNkp8mlMbsWy6VLmyZO6vBnSLN3P9BBXLJ6YBABmwC8lAOvcqF2ZZCjxXHqCsmZD5qiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=corigine.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IqFQQD6XUCSztz/+YwE4KW2vMEua06B1m7wnu06QkJQ=; b=YQOKs+zCUtp6YJ7TjqipLFIjB4Bihb0B6AJP3iIpme+JnBbOE8fPtKlj0epjXsEE2iDUxovab/a+xpEJED1Ns60gghe6B9Xvcq7/sTU9Ok+d3DvHkyp+4KpZJguqlqxB4ky9lX2SM/1JzBmh++WAgEEWM3rZsE79tlFiFms5r1Q= Received: from SA0PR13CA0014.namprd13.prod.outlook.com (2603:10b6:806:130::19) by DM6PR02MB7083.namprd02.prod.outlook.com (2603:10b6:5:254::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Tue, 20 Sep 2022 17:33:05 +0000 Received: from SN1NAM02FT0036.eop-nam02.prod.protection.outlook.com (2603:10b6:806:130:cafe::bb) by SA0PR13CA0014.outlook.office365.com (2603:10b6:806:130::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 20 Sep 2022 17:33:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0036.mail.protection.outlook.com (10.97.4.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 17:33:04 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 20 Sep 2022 18:33:03 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Tue, 20 Sep 2022 18:33:03 +0100 Envelope-to: chaoyong.he@corigine.com, dev@dpdk.org, oss-drivers@corigine.com, niklas.soderlund@corigine.com, james.hershaw@corigine.com Received: from [10.71.194.74] (port=50017) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oah7H-0007Yy-6b; Tue, 20 Sep 2022 18:33:03 +0100 Message-ID: Date: Tue, 20 Sep 2022 18:33:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] net/nfp: improve readability NFP HWINFO header Content-Language: en-US To: Chaoyong He , CC: , , James Hershaw References: <1661492343-23225-1-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <1661492343-23225-1-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1NAM02FT0036:EE_|DM6PR02MB7083:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d94e50f-1069-4b23-b049-08da9b2e2cb3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W/WZrZVNr9UCj+angrlJMirFnb6TLAw1VDcJfhlbUgSDoaq01sTOdGTFr9owkkF+FWuPSSDWB09u/k2MNyYh4hym+duqlScXMc3nv0gdNl9ptYO5N02dI7qM4egmbXKI0EAX3mJrt58XYkRhGSibguREGq9gCCBW8xiHKxgMHEZw2hlVdUCbfpQUWWwwpZpYRH70llMeiK6bnaES/WKgA7M0kiy2eem+eh7nIzWNU0TuN1OljZp7OqJBwo4XVLPgpuQ0BOuAp6N48xXHZflZo/JFeWNOOAI/tP9TB3XEjeqOhB9oELB/907uSKpfmbPcXVy5f3My31M/MRJGJvHz/TggVDon/DJWvGfVZRAZWPCXlnLCiKJVp0+ob4p6nPTBoOZHPRpj99xZk9EsaVB6RYjwkapWErAapbAE6keS5L7r2UaraPRhEb1g7u0I7nm4OEhUgsNBsn85kRAI+FDZvp7qy5KitZcw+zWTAWO5zxSppRF7WzXV6h+MWZlFCoE8nYhn+1c4te4mlaJjhGqGZQ4afyaaVTVTwYLTc5Nod8co8HtStfz9aFDpg2YKh+l5RBC54a4JcYwrAjyywNG27RhOMBgKhQkcth4RGxk4x4UQkfIzgSGNLRlxZxCkXBm09s+WhR8hZwPdO//Oq9qBvocO4X7uv6AfiSA17qufZEGMNYn4GlStmZK0GyQ3XMS3W+qGvLApPXHC1X0gxH/7hiKMzkE5fmY/XNn+8RNJdLVhz/9tJ9Lgh0s10G99WUqwqOnDs2D7wX8QAJA2EHvlu19MeZgydAkwv0FxJmZXaP8A4jkblP3sPDVcAeRmYejqGZS8d6sLCsUtrqzVtQeiEw== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230022)(4636009)(346002)(136003)(396003)(376002)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(31686004)(83380400001)(2906002)(36756003)(8676002)(54906003)(110136005)(44832011)(5660300002)(316002)(40480700001)(70586007)(4326008)(70206006)(31696002)(478600001)(9786002)(82310400005)(41300700001)(8936002)(53546011)(2616005)(186003)(426003)(66574015)(336012)(26005)(47076005)(7636003)(356005)(40460700003)(36860700001)(82740400003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 17:33:04.3527 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3d94e50f-1069-4b23-b049-08da9b2e2cb3 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0036.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB7083 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/26/2022 6:39 AM, Chaoyong He wrote: > From: James Hershaw > > Prepend `0x` to the NFP HWINFO header value that is printed to improve > the readability of the printed statement. > > Signed-off-by: James Hershaw > Reviewed-by: Chaoyong He > Reviewed-by: Niklas Söderlund > --- > drivers/net/nfp/nfpcore/nfp_hwinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/nfp/nfpcore/nfp_hwinfo.c b/drivers/net/nfp/nfpcore/nfp_hwinfo.c > index c0516bf..9f848bd 100644 > --- a/drivers/net/nfp/nfpcore/nfp_hwinfo.c > +++ b/drivers/net/nfp/nfpcore/nfp_hwinfo.c > @@ -108,7 +108,7 @@ > goto exit_free; > > header = (void *)db; > - printf("NFP HWINFO header: %08x\n", *(uint32_t *)header); > + printf("NFP HWINFO header: %#08x\n", *(uint32_t *)header); Why driver is directly using 'printf', but not rte_log APIs? I can see there are already 'PMD_INIT_LOG' & 'PMD_DRV_LOG' macros for this.