From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id AEE27A054A;
	Tue, 25 Oct 2022 12:12:06 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 598D0427FF;
	Tue, 25 Oct 2022 12:12:06 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id DDABD41143
 for <dev@dpdk.org>; Tue, 25 Oct 2022 12:12:04 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 625D55E;
 Tue, 25 Oct 2022 13:12:04 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 625D55E
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1666692724;
 bh=zWiUW/7ZPzA3qOvzQi8WpGYJQw7WyJ+gGjwEqn0K2kU=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=Z7iSXUR0/gAQd7SVwdqiQgPRQ3vozj4/1Djmv40jR2kMMmjNcKdVofiuArDjQ2k7O
 nkgHzFvQeOLIK8qstSctT3GAvCbIiZwygoXAHR+ukSwq6ETvo+oBSNiO4U9LI8a2t2
 AbtwlLkWZO64vTM6L2Su3Pd1FqIDuKsm4h7mR6cQ=
Message-ID: <e1568ed7-d2bb-231d-4edd-1293af42054e@oktetlabs.ru>
Date: Tue, 25 Oct 2022 13:12:04 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v11 12/18] net/idpf: add support for basic Tx datapath
Content-Language: en-US
To: Junfeng Guo <junfeng.guo@intel.com>, qi.z.zhang@intel.com,
 jingjing.wu@intel.com, beilei.xing@intel.com
Cc: dev@dpdk.org, Xiaoyun Li <xiaoyun.li@intel.com>
References: <20221024130134.1046536-2-junfeng.guo@intel.com>
 <20221024131227.1062446-1-junfeng.guo@intel.com>
 <20221024131227.1062446-13-junfeng.guo@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20221024131227.1062446-13-junfeng.guo@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 10/24/22 16:12, Junfeng Guo wrote:
> Add basic Tx support in split queue mode and single queue mode.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>

[snip]

> +/* TX prep functions */
> +uint16_t
> +idpf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,
> +	       uint16_t nb_pkts)
> +{
> +	int i, ret;
> +	struct rte_mbuf *m;
> +
> +	for (i = 0; i < nb_pkts; i++) {
> +		m = tx_pkts[i];
> +
> +		if (m->pkt_len < IDPF_MIN_FRAME_SIZE) {
> +			rte_errno = EINVAL;
> +			return i;
> +		}
> +
> +		ret = rte_net_intel_cksum_prepare(m);

I'm wondering what it does here if you don't support Tx
checksum offloads yet.

> +		if (ret != 0) {
> +			rte_errno = -ret;
> +			return i;
> +		}
> +	}
> +
> +	return i;
> +}
> +

[snip]