DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hemant Agrawal <hemant.agrawal@oss.nxp.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
	"Hemant Agrawal" <hemant.agrawal@nxp.com>,
	dev@dpdk.org
Cc: thomas@monjalon.net, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: add missing buses in dev iterator
Date: Thu, 29 Apr 2021 19:27:14 +0530	[thread overview]
Message-ID: <e1597bd7-78ef-ee3e-3485-946419b4d0f8@oss.nxp.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C6172A@smartserver.smartshare.dk>


On 4/29/2021 7:23 PM, Morten Brørup wrote:
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hemant Agrawal
>> Sent: Thursday, April 29, 2021 7:56 AM
>>
>> This patch fixes issue with OVS 2.15 not working on
>> DPAA/FSLMC based platform due to missing support for
>> these busses in dev_iterate.
>> This patch adds dpaa_bus and fslmc to dev iterator
>> for bus arguments.
>>
>> Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>>   lib/ethdev/rte_ethdev.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
>> index a1879765e8..483013ec7a 100644
>> --- a/lib/ethdev/rte_ethdev.c
>> +++ b/lib/ethdev/rte_ethdev.c
>> @@ -260,7 +260,9 @@ rte_eth_iterator_init(struct rte_dev_iterator
>> *iter, const char *devargs_str)
>>   	}
>>
>>   	/* Convert bus args to new syntax for use with new API
>> dev_iterate. */
>> -	if (strcmp(iter->bus->name, "vdev") == 0) {
>> +	if ((strcmp(iter->bus->name, "vdev") == 0) ||
>> +		(strcmp(iter->bus->name, "fslmc") == 0) ||
>> +		(strcmp(iter->bus->name, "dpaa_bus") == 0)) {
> Shouldn't that be "dpaa" instead of "dpaa_bus"?
The registered bus name is "dpaa_bus" only.
>
>>   		bus_param_key = "name";
>>   	} else if (strcmp(iter->bus->name, "pci") == 0) {
>>   		bus_param_key = "addr";
>> --
>> 2.17.1
>>

  reply	other threads:[~2021-04-29 13:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29  5:55 Hemant Agrawal
2021-04-29  7:56 ` Thomas Monjalon
2021-04-29  8:01   ` Hemant Agrawal
2021-05-04 12:49     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-05-04 15:50       ` Thomas Monjalon
2021-05-04 16:34         ` Ferruh Yigit
2021-05-05 14:39         ` Xu, Rosen
2021-04-29 13:53 ` [dpdk-dev] " Morten Brørup
2021-04-29 13:57   ` Hemant Agrawal [this message]
2021-04-29 14:01     ` Morten Brørup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1597bd7-78ef-ee3e-3485-946419b4d0f8@oss.nxp.com \
    --to=hemant.agrawal@oss.nxp.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=mb@smartsharesystems.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).