From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77343A0547; Thu, 29 Apr 2021 15:57:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37349410DD; Thu, 29 Apr 2021 15:57:28 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60083.outbound.protection.outlook.com [40.107.6.83]) by mails.dpdk.org (Postfix) with ESMTP id CB9B3406FF; Thu, 29 Apr 2021 15:57:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J3TmG8oDEfd7ZEc4zkKCCCpmgjrO5IWhX3GkFpPjFCILyP2PLLcfI7UDWheUw1zosEwk+KoSao0tT5NZmG+eQYUSSVws1q+9sKKmux+2No0WxSdkVe6OqTzJQc/UO+1e9bZ7UlPUtUGMMu7ndxLUzYAj6XY8qJlj67dFe88tfHulvhnzyQ2dIZxICpR42dayJg3ZWukuhtO+jpxCWPeBTVYvzpgA0WfI4qBD3ZR+CTby7o39N/cbEh/LPJWoEM7XoWsQkjiohrSNR3DWFa7vooFNUCnVcPuL9Z7SXHbBOtcyytKIxRXQMHwYMSE4l2yWlOfo1v3axZ0y6oNgmdWccw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RYCxz9wG/1fVaLyiwBpTg+Lu6NwWPrpoWHq5fFnAp3c=; b=fpo513CqC5VxV9iY4+xfE63rZ5sWkfQ7JmYYSVxDweoLWSv5OPPleqtYxBrFrKSF2vEiAtXquuubGJfhnFAkCsJd38eWDu7GYYPXT/c61VzDyM8hDZDy0bfUbG7fN6B+KpABkpMyzsf+sL8da1By/vLmsz3XV7IgyyjI6eC/QD6+esjU8pLl7Q2IN/VvrjZteKfOgSXOz3OE44uoUHPfTDSNzoGdHukAypP8h6tXHHaErgOl8xL811nNqO1AGHgjAdCZ75Z9IBOYukxWYoR/XdFDJdkPcFAWNwYVypfIFW9NgoTtCD5H3+B4RIJy3ZYPXl+F7ok2ohTGKwIycRy9cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RYCxz9wG/1fVaLyiwBpTg+Lu6NwWPrpoWHq5fFnAp3c=; b=k17/uDGm8dP60k2HeVpeC4ESlPx38IvuN+h9Co1hZ1+EquHqW6L5AqtQ9rghBca6v8NoKO2S+bBOc6XHz3xFh4FmxRxcpp/dCb0J0kw9hWk8Gxmr2Xs8k/pBj3YNrFMnR3m9eUowi0SSVij76F961E6Mj9ZB02T88BgfPDbkbi8= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=oss.nxp.com; Received: from AM6PR04MB4456.eurprd04.prod.outlook.com (2603:10a6:20b:22::25) by AM5PR0401MB2675.eurprd04.prod.outlook.com (2603:10a6:203:35::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Thu, 29 Apr 2021 13:57:25 +0000 Received: from AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::ad9e:a38e:e84e:bf55]) by AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::ad9e:a38e:e84e:bf55%6]) with mapi id 15.20.4065.027; Thu, 29 Apr 2021 13:57:25 +0000 To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , Hemant Agrawal , dev@dpdk.org Cc: thomas@monjalon.net, stable@dpdk.org References: <20210429055548.12964-1-hemant.agrawal@nxp.com> <98CBD80474FA8B44BF855DF32C47DC35C6172A@smartserver.smartshare.dk> From: Hemant Agrawal Message-ID: Date: Thu, 29 Apr 2021 19:27:14 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C6172A@smartserver.smartshare.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [223.178.219.73] X-ClientProxiedBy: HK2P15301CA0014.APCP153.PROD.OUTLOOK.COM (2603:1096:202:1::24) To AM6PR04MB4456.eurprd04.prod.outlook.com (2603:10a6:20b:22::25) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.2] (223.178.219.73) by HK2P15301CA0014.APCP153.PROD.OUTLOOK.COM (2603:1096:202:1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.4 via Frontend Transport; Thu, 29 Apr 2021 13:57:22 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5d3b4ef2-05e5-48c1-b187-08d90b16b78c X-MS-TrafficTypeDiagnostic: AM5PR0401MB2675: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SceY+wA76Zjwdzpi4uSq7t/9ZFBU1NY3b6qUByjnXD2rZyIBbaWiCxtnZeGxhctMZwQ8KXLpydmB3CvwM/iMO+zjZhbZ0MvOw4mW/Zc9jVeKoWwr5i4YXhsmG8mMuscaMsBWJro3nKu8cYvE3DM0CyEq4tU2Ig9tEV77YPiyeWoifGW8cvBKjiTxmXln/v9H9nO4o2biCO/HkkCvlDNiOxhvtLgML7b1MDYQNAsiCC/9PVI8dMrrbHgoqdChzcoze6IKsPV/GrvzPwd//MfrerUAeH1ZOirdIQFZQ+JkpWxS7J3QR+1fQ5NLrRbyI4+ojKhYFlywh01eX3+SgseMsGztB+VNCxTSMdoQgPorWqGa6CEciWs/fucphlQZWa2oNiCdYpSNj1OZaMazqQURw+N+cyNOQtqgfrpecSpN4yyfj69GyZBD5KNF87lw1j0oWQAS0Saw42rkNdqCJEnRoZ6Wxp6tDR+Znxdr5yEkyIx4fVqfh1IH1ku7A0RyuJS7CMU3Bvu6Hz3U1b6DyCI/4TjMROvuHEfG4LebyxOSuaGVqMwBWmI5ZvNUVM7cEr+EO4OJ8hGzkS1Axci1cTenELHsxBZPlEb2jFaSey1PWIiWN2p+aeNzAJRspsgUFNmzxtXwOoDyh+w7DjD7xAGtGO09dQF4DDZmHylGjDEVhIR+lm3oN0D9kz6fVbDa1zKcDTP/tYJ/+NSnwVnj1w7EVe8G/pxvmHUVjhXq1TAyil0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB4456.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(396003)(346002)(39860400002)(366004)(6486002)(316002)(38100700002)(2906002)(53546011)(38350700002)(52116002)(66574015)(44832011)(66476007)(16576012)(31686004)(6666004)(31696002)(8936002)(956004)(83380400001)(5660300002)(4326008)(110136005)(8676002)(26005)(86362001)(66946007)(16526019)(66556008)(478600001)(186003)(2616005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aFMzRHBOM1MwZTZCL1JHaFBSYVVVN21QWXpsckk2ZHQvYjZkMlhac01oZWt1?= =?utf-8?B?RFdaOGFyMnVGL2dZWis1L3Q0WTc4Q0ZOOS9tZTErK2JkVUEzbktaQ1d6SEN6?= =?utf-8?B?dDQxZEMveGthM2FZdGxPLzJjaGRCOEZGbnZScnhtdkxML1p0U2d1RzR4aWo5?= =?utf-8?B?WkU0N1JiaHFrbFkwQ3pWSUFZazJjN1pSMUF6YWNnL2pwaVpDcmJOSFpvZXp2?= =?utf-8?B?MEJuc0tlSHpaNkhwazExUFBuRzdOOFpvOTVIbWluR0M0Ky9ZT3Z3TkhYSnBN?= =?utf-8?B?SDc1TDBIc3ZWL044eGNlVDloV2dRWmpPYUVNV2hHN2V2TGlldDc0RzJTaStQ?= =?utf-8?B?WnNPSGcyS09zU3RTRzBpOHRqS1M5cjhkVlYyZkZENVNIV01vS3B4YnZBYlF5?= =?utf-8?B?a0hqbUVWeGdlZWd0VGJHMUE4VVFRWnFINVJqYk9QdHJDeG15a1IvcHp4bWFW?= =?utf-8?B?NWNHNDNXbkUxOEhsckZzRnhUWWtyLzJ1Q3R2V3R0QW8wT2ZEYkYxQmlORTR4?= =?utf-8?B?TTZpUzdRQjI1NjlnM2h6ZFFJcnRxeDQ4eUR5TzRzTWVnc1p4eEhEQWErejB0?= =?utf-8?B?OXBJSmFSRHQvZDFpMG82c3BsQStwSDh5c1k0dWp3ZzU5clRsTGh4d1JrVWlX?= =?utf-8?B?TkFaYTgwOCtVS0s2ZlV5NGR2Q3RkWVRkbFZISVBDT3hNMjRxQ3RQWnZuTHFZ?= =?utf-8?B?ZTZSRC9IejM3SHNqbDFxL0RUYVdXeHQybFc4djJscFM4OFNRMHh0L0N0SU9z?= =?utf-8?B?RFNVSlIxYUFZWGQvUkowV3lLMlhFLzNzV2JtcjBsUnNnYVlkWTBxc2FZYlZx?= =?utf-8?B?VW1vdlJqZVhsbFFRR0VXSXU2T29NOVM4SWNHeW9hckJha0ZCVkJJSlMyeHlW?= =?utf-8?B?U3BlZE5ES01lRGtaVUN2VVU0YjNCVXYwM0R3WnRybnppdmFSS0w4UmovZ2xU?= =?utf-8?B?SXdEc3NlWDRIcUc3d3QybkF1WWc5cmxmSEZ3QzAxRmg2YVpXRTVTcHAxMW5h?= =?utf-8?B?aFM0a2E4MTh3OCsxTEZ0YjJFWDBPMGkwMElYS0M1R1ZoTmQ1UzBKMmlCdXFB?= =?utf-8?B?akV6TVMwMFNER1lIc1htMUpDSHZPdWQ4M0lTVTdRYzlnN2d3VUFFRnh5V0pZ?= =?utf-8?B?UkNrcDJkQjR0Q1EzUUdtOEx3NDF3K2xKZkMrNm9mOE5MdDFsK3hxaVNuMXpM?= =?utf-8?B?bjJhRUZoT2NuMHNvWUppQ1JNbFVPVFdCcTB2RStUUHFvMms2bVhMVitEcU4z?= =?utf-8?B?bjJDanNhQ2tiL1drQjBlUzh3TWFYSVpxL1VkMk84UHZRVWk4S1JtdUtFQjJO?= =?utf-8?B?V29nc1hNODBmUDQ5U3RPNkpZUEV1SnB4YnkwWnc2SmphUG5kODFQNms5aDFh?= =?utf-8?B?NkcxbithalpqNmg5VUt2Rk9EbDl4Mi9yY05Xb21zU2ZrVStJcFRuTkRBUVAw?= =?utf-8?B?MnFabEFNQ2NvVmhXUnExMkhlbFFyNlBuSk1adnUvVEsxWndWN21YV3dOM2VF?= =?utf-8?B?YWNTTTlZWTJ2VzFSeklkeXRxdDUyZkUwTWxXY01WUjc3NFBMQlVaYVQwZmhT?= =?utf-8?B?UVlWUXpMN2ZDYWIzS0VpeTZzWFRXaFpWNDNEQ092cHlGTE9JY3VaTmRaYWhZ?= =?utf-8?B?V1pIUm1kSGtQWHJPem9Ma3lzMDJTRzJzNFJJZDIxZmpDQ1V3QXBLMmU3UTNQ?= =?utf-8?B?ejJJUkpjQVVDZitCTERwanJxUXlyaWplZW1NNGE3QS9hdzJza0NQMis4RE1M?= =?utf-8?B?ejZEU2JtYjdFR2NjMjRvc3NGSjhpVENPeDl6UC9ZbnV1SGJSUGlETkJoRjB5?= =?utf-8?B?VDNZSHV1Y1l2ZHdQMEhMZz09?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d3b4ef2-05e5-48c1-b187-08d90b16b78c X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4456.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 13:57:24.9720 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dWCH54LhbLuTMA9CnTqpi6rooR3spY0J0rm0nNxvjpdChKCX8q0NdCWSPp42zUuYhC4v4WMqAwaXhLk6L9avOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2675 Subject: Re: [dpdk-dev] [PATCH] ethdev: add missing buses in dev iterator X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: hemant.agrawal@nxp.com Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/29/2021 7:23 PM, Morten Brørup wrote: >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hemant Agrawal >> Sent: Thursday, April 29, 2021 7:56 AM >> >> This patch fixes issue with OVS 2.15 not working on >> DPAA/FSLMC based platform due to missing support for >> these busses in dev_iterate. >> This patch adds dpaa_bus and fslmc to dev iterator >> for bus arguments. >> >> Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") >> Cc: stable@dpdk.org >> >> Signed-off-by: Hemant Agrawal >> --- >> lib/ethdev/rte_ethdev.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c >> index a1879765e8..483013ec7a 100644 >> --- a/lib/ethdev/rte_ethdev.c >> +++ b/lib/ethdev/rte_ethdev.c >> @@ -260,7 +260,9 @@ rte_eth_iterator_init(struct rte_dev_iterator >> *iter, const char *devargs_str) >> } >> >> /* Convert bus args to new syntax for use with new API >> dev_iterate. */ >> - if (strcmp(iter->bus->name, "vdev") == 0) { >> + if ((strcmp(iter->bus->name, "vdev") == 0) || >> + (strcmp(iter->bus->name, "fslmc") == 0) || >> + (strcmp(iter->bus->name, "dpaa_bus") == 0)) { > Shouldn't that be "dpaa" instead of "dpaa_bus"? The registered bus name is "dpaa_bus" only. > >> bus_param_key = "name"; >> } else if (strcmp(iter->bus->name, "pci") == 0) { >> bus_param_key = "addr"; >> -- >> 2.17.1 >>