From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 5C019968 for ; Mon, 25 Sep 2017 17:11:39 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 25 Sep 2017 08:11:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,436,1500966000"; d="scan'208";a="903638206" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 25 Sep 2017 08:11:37 -0700 To: Shreyansh Jain Cc: dev@dpdk.org, hemant.agrawal@nxp.com References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170909112132.13936-1-shreyansh.jain@nxp.com> <20170909112132.13936-3-shreyansh.jain@nxp.com> <2392e7d0-4790-9f1f-27b1-62b8fe775a87@nxp.com> <7cf232e2-000a-85f4-2628-2945e1e7ddb1@nxp.com> From: Ferruh Yigit Message-ID: Date: Mon, 25 Sep 2017 16:11:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <7cf232e2-000a-85f4-2628-2945e1e7ddb1@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 02/41] bus/dpaa: introduce NXP DPAA Bus driver skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 15:11:39 -0000 On 9/25/2017 3:32 PM, Shreyansh Jain wrote: > On Tuesday 19 September 2017 06:44 PM, Shreyansh Jain wrote: >> Hello Ferruh, >> >> On Monday 18 September 2017 08:17 PM, Ferruh Yigit wrote: >>> On 9/9/2017 12:20 PM, Shreyansh Jain wrote: >>>> Signed-off-by: Shreyansh Jain >>>> Signed-off-by: Hemant Agrawal >>> >>> <...> >>> >>>> diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map >>>> b/drivers/bus/dpaa/rte_bus_dpaa_version.map >>>> new file mode 100644 >>>> index 0000000..d97a009 >>>> --- /dev/null >>>> +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map >>>> @@ -0,0 +1,7 @@ >>>> +DPDK_17.11 { >>>> +    global: >>>> + >>>> +    rte_dpaa_driver_register; >>>> +    rte_dpaa_driver_unregister; >>> >>> "local *;" ? >> >> Agree. I will change this. >> Currently rte_dpaa_driver_* functions are being used locally within >> bus/dpaa. >> > > Even though I agree earlier that I will change this (append 'local *:' > to the file), probably I will have to skip this. > Further in the patch series, there are some symbols which are added > which are required by the mempool and net drivers (and crypto, in > future). Shared compilation fails for them if I add 'local: *;' here. It should be OK if this is last item in the first group. Technically I believe it will be OK to remove that line, but not quite sure. Lets be consistent with exiting usage and keep it, there are many sample map files.