From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 027131B1CF for ; Tue, 9 Jan 2018 20:18:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 11:18:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,336,1511856000"; d="scan'208";a="22701630" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by orsmga001.jf.intel.com with ESMTP; 09 Jan 2018 11:17:59 -0800 From: Ferruh Yigit To: Amr Mokhtar , dev@dpdk.org Cc: thomas@monjalon.net, anatoly.burakov@intel.com, pablo.de.lara.guarch@intel.com, niall.power@intel.com, chris.macnamara@intel.com References: <1513990331-20253-1-git-send-email-amr.mokhtar@intel.com> Message-ID: Date: Tue, 9 Jan 2018 19:17:59 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1513990331-20253-1-git-send-email-amr.mokhtar@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 1/5] bbdev: introducing wireless base band device (BBDEV) abstraction library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 19:18:03 -0000 On 12/23/2017 12:52 AM, Amr Mokhtar wrote: > - wireless baseband device (bbdev) library files > - bbdev is tagged as EXPERIMENTAL > - makefiles and configuration macros definition > - bbdev library is enabled by default > - release notes of the initial version Hi Amr, Overall lgtm: Acked-by: Ferruh Yigit There are a few minor things commented below, can you please check them? You can keep my ack with next version. ./devtools/check-git-log.sh complaining about patch title, same with some of the other patches, can you please update them? > > Signed-off-by: Amr Mokhtar <...> > @@ -593,6 +593,13 @@ CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV_DEBUG=n > CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=y > CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF_DEBUG=n > > +# Compile generic wireless base band device library > +# EXPERIMENTAL: API may change without prior notice > +# > +CONFIG_RTE_LIBRTE_BBDEV=y > +CONFIG_RTE_LIBRTE_BBDEV_DEBUG=n It seems this option is not used now. <...> > @@ -0,0 +1,586 @@ > +.. > + SPDX-License-Identifier: BSD-3-Clause > + Copyright(c) 2017 Intel Corporation Minor issue but can you please move SPDX to first line, same for a few more documents. <...> > +/* Find data alocated for the device or if not found return first unused bbdev > + * data. If all structures are in use and none is used by the device return > + * NULL. > + */ If this kind of comment syntax because of checkpatch warning you can ignore it, fyi. <...>