From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0045.outbound.protection.outlook.com [104.47.40.45]) by dpdk.org (Postfix) with ESMTP id C78045689 for ; Wed, 1 Aug 2018 09:01:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u1117l5ypnj76JDoWqj/JjIuLuSx9ahSeLG4+WMtmmM=; b=RKg+eF0qXXduBulYDsOk34LPOa0CeOREhVXTHHK7K6P61jhE/2KfpU+f08VnaXGTjSLTrylHADMeManpUKXbzWIlbZ6iqnpV5A1q6zGzT+sF/jA8WdpQ5NmFJgjKZRP+YQCchwnBlbn8ZMdhRPkQlaY2gpRw1LB3HnEsqa2xtZQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from [IPv6:2405:204:d400:8dee:817b:e263:61d9:47e] (2405:204:d400:8dee:817b:e263:61d9:47e) by SN6PR07MB4911.namprd07.prod.outlook.com (2603:10b6:805:3c::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.15; Wed, 1 Aug 2018 06:59:37 +0000 To: Thomas Monjalon Cc: dev@dpdk.org, Bruce Richardson , Pablo de Lara , Jerin Jacob , Narayana Prasad , Hemant Agrawal , "Ananyev, Konstantin" , Sunil Kumar Kori , Nikhil Rao References: <1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com> <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> <3685021.sWt9K18E1B@xps> From: "Joseph, Anoob" Message-ID: Date: Wed, 1 Aug 2018 12:29:50 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <3685021.sWt9K18E1B@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [2405:204:d400:8dee:817b:e263:61d9:47e] X-ClientProxiedBy: BMXPR01CA0021.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:d::31) To SN6PR07MB4911.namprd07.prod.outlook.com (2603:10b6:805:3c::29) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f7bdcda3-c4ae-4131-ca9c-08d5f77c5cb4 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB4911; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4911; 3:TeZLVHH42nLhR6jNpYsMjoC+mlgoiY6Hqz06UFF88IhO+27LLoYB/Tl76jQ6U+uHHCPNOG/Vy6zpeV/yTfnbvuFOWlxTD/L4UdrGHbQcYq/yzC0nQKVf7zL/rF+wyd/h5ul4k+jBZOkU33scIVAp4ryStAV5jM6PNydKOJDkzDUhYrDgkeWrrKnycvMiGXh9RMDcKATNhg3t/VVSgL8QLahSYD1mALBt+4UNuRd0XZrZ3+f4NKdwGYb6sW8MXVT6; 25:vjj/gU2un78l7Y8qnNblZucDbYKA9uhtJnwSzpcNnPFT1Po1uA92PMkH6Dul2LPMkAw5s3tAAraQXrcv+zITE6SLeuSg1YYqTN+Q7+DKOSPzib+Obx6uV4sKzLcmqtVLWa4a7MuZpcae0dzMYmVETFuQeCSzc8fFTy4ZtaQHkUUEsA2lDHAGiV00MakOYpdPNCDWRAgPs40/CQaGSozo3rbe22dkCfIoK/SvaVYsZePz9u5sWPlNRoldcyTzTL7dm+68oFI/joDUqODKO4VM+Nix06FTtKls9rmSxDpoexou0NSiKojfnY8yasgMYjpX+IYGktT3OrNjv+EeyAMJvw==; 31:O4qlQxIkYAGE74PAGRFYNoaEwgjm6rUgXDniOZ5US4gasivS0kwuqT3N4ZhYV5zXc6NndSKvx9I6Uu5xdxIVC2AalhBIj3UoJK3WTQlRYXT5rQEKUoRlf5S6mIP1f7TXz/tSnQV/2y2a5MsQWM0itehkbig6QaRx1PoD9PxiTlBHf8QFiZth/K9EKrivnSmLVJXssMGo+clqGc/8h218/IqcypEJieE0Bx+M7WSHJKs= X-MS-TrafficTypeDiagnostic: SN6PR07MB4911: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4911; 20:jeS3XoQPI2hRlIILUaYQKhcIuDObOcVJcGlLckHNoAwZmdvhWRj6K7kCZ+VEXCmVwCYEAJwXGtoJD6tPFnyIDVYSCREactrmn6XWLMpQZQRlFHQPjoTFx4oq/DSSZ7I7DTem29DKStp7rAWi4CV8p0E86k0vVCMr17PVBqkmqp/ix9lmZ5sFJ+oN8/ANBVSPmDxQZVxU/2Aj4h+kAWXUHzKuJiYvZTXQmB3tHJO6aVwMK/Lw9vqKC9qrxf7btFjthQBOluusRuJaz5PjqwB47Q0hq07yeWUIwUrbo7yFw1M2/M1ZugSklB5M/PBANuSUWNP7Uk0WIn/BmZR3uQiMOQEKJmujUHsQiMnq4udOC/+Na13u2WxBk5lTI/8Hto3/n2BYnlICqib8pEa34a4L230K8yJ43R/g3AwnsHw3KWCQTW/WYQParbpvqqr26IXJf8vNWE6k1fYTUuxq8KI4MUsz5ZOk74LPKBEi8BxCaZAW/QAdJtpqh/C1Jkx3e/PoKyBAgjVkOiAWCffrPhZe4qHtHQwKTVwKiGnoCp5WTBkxbSkSuCDy353qJnEYwoPhGkQXP17t72vdGUylEQi5Rugykq+31YPrhDpaXJ+aIsM=; 4:Ad9xibdNT9pRJ2/xiUcCYOgrqJUT+uxbaVSE3vbbLM4q2FrGy667lUp+EMtIJX72gBbXIaiNM70rpIoM5pdNbK7RopB5U9NJzCqTKlNQRz4cpG2U2ZKcD3Iq/RkA2pmWZfW3ZI9RQNVHw47aICjfYi/oAwrecRhEL18f7+YSwtnGldJs1kHEp7V8pql/I9aZJNk9AFfdktt/O4ITSMI2w9z0AUnNLwxCwGlbcj9tNCE2VNPculMS8IN61INhd/iMTB0Jk2u4Eu6RCoHH2rgNU/D3lt1SXd6TNWOIt5bYo8PFkXRQ+XJdY7cUss+nn0Ey X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(3231311)(944501410)(52105095)(10201501046)(3002001)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:SN6PR07MB4911; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB4911; X-Forefront-PRVS: 0751474A44 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(39860400002)(346002)(376002)(396003)(366004)(189003)(52164004)(199004)(486006)(186003)(53546011)(64126003)(54906003)(14444005)(97736004)(476003)(446003)(58126008)(386003)(229853002)(67846002)(5660300001)(65826007)(23676004)(52396003)(46003)(52146003)(42882007)(76176011)(53936002)(11346002)(316002)(2616005)(2486003)(6486002)(52116002)(6306002)(16526019)(106356001)(3260700006)(25786009)(31696002)(50466002)(8676002)(81166006)(68736007)(105586002)(6246003)(305945005)(31686004)(7736002)(6916009)(4326008)(65956001)(47776003)(36756003)(478600001)(6666003)(65806001)(81156014)(6116002)(230700001)(1706002)(72206003)(8936002)(966005)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4911; H:[IPv6:2405:204:d400:8dee:817b:e263:61d9:47e]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjZQUjA3TUI0OTExOzIzOkRCcGJiWTdYVk1UREpMWFdsekk3bVI3bmk0?= =?utf-8?B?ZVFhd1QyZ0Y0Q0czTlJTRXNabm5NYmhLeGRtV3piVGdHYVZpYVJ3ak9GcGhp?= =?utf-8?B?ajlrVytESW03V0V4ZGZwMGZjVTZzOS9EcEh4OGREbFpFV2pyL3FweDBnbS9L?= =?utf-8?B?MTJ2TjAycHFGSWhRVCs1ZyswRDRRSTYxUWduKyt1UmhNQmNvQ05FZGhMWit1?= =?utf-8?B?eVQ1cEloUG05dWt4cVZRNnk4NVdrL3pTTEJGZnJOZEY4aDkyaWpBRFBHZFpr?= =?utf-8?B?eTV6K0tpc2w2aXQ4OFEzdHpTanR1eUF6OFRHNE43eVpqVmlnaCtQbU84V0N4?= =?utf-8?B?SWRINGJTeWU1RVdEeUdraXdYUTBVTVN1SUN4OUh1dTJYNnVSclZDd2VFSnJJ?= =?utf-8?B?dEluVjZEVDB0dlpzN0xOT0ZJVkRUSUlBY2pnZnAvbU80dWtHV1dtZzNzQW81?= =?utf-8?B?MkxGVzN0cHQvOHgxU3pOYzhtQlpPYTZuODBYZ0FXUkRmajg0TTlKNVUvZmlO?= =?utf-8?B?VVdpUk5HQytrY0JDd2xQSTRocWxLUFRTeTJqZ3E0S2t5MGpNdHBucG1jUU1D?= =?utf-8?B?eEhrL0o2a0dmYWlGb2VlTEszaXpVQzl3dE0rYVhqMk02UlpJUmQydXFjeVRv?= =?utf-8?B?dHJiM2NWTUR4eHlkR3Z2bDY4OERxNWRBbXBDc1NlYnVsUk13VEVJOVU2bG5V?= =?utf-8?B?c2NFSGZOaDMwdHg3SThvaS9EMWI1NUZJUVpDbVJhbWs4TXlZM0UzWnFJOGpk?= =?utf-8?B?bCsxZ3pRcmNsM1JlSTZYTWx2QVZXUm1QWjVQaGZXQ2JDcEZpM0hRa2s5dEcy?= =?utf-8?B?dXZ3a2ZzY0o3a1ZZdEllNWxRZVlDUEdnSTlrRUdYeG84KzZWd3pkNm0yQ0hY?= =?utf-8?B?NGt5RUV4NWtOWVBHZzBYb21ycDk3YUpMRC9nU0sxK1N3alBNbm1BOC9SUWt5?= =?utf-8?B?RWNKT2JUWmJUK0w4STZrVkpUNWF6NHZtd1hneEpuOTRSckd5OWk1clZqQkdl?= =?utf-8?B?Y0VEV0l6RnVEMHB6cTZhY0VXRVpCbG1LdXBad29pSXl0S01sN2x4THpwaGl6?= =?utf-8?B?ZHN6amF4bXUwSkhLZ2dYYXZPTDUwTGVGd1pJWGZOUTJKQXRpeTRhNUdFMjJj?= =?utf-8?B?UFQ0VENIU3NqSTlmQ1lkemdENEVKWlNXNDlHMmQ1ZlcvSmdxR1JGWERyMU9s?= =?utf-8?B?cDlsSnlxRnRXbExaQTlwTlh2bWlKUUlKMVEzVWl6N3NOWm9jcU5reGprMVlF?= =?utf-8?B?Ky9PYUhNWXI1enJObEdEZlNPSUIxZFpKdDVvS1pyWlJQQ2F6akR0Z1A2b1Z5?= =?utf-8?B?ODVlRG5mTTl4WkUxUXJaVmhtWE5KbVc1Q0ErTzNDb21sWE80bnNoRnhocHpZ?= =?utf-8?B?cXdyWEg1c011Sm14Z0lBVVpjbkVCdCtpN2RIc0pWQWg1cGVHcWlkelZmdzUr?= =?utf-8?B?Ym1kZnBLYXZ6WHJzWVNVNDhKcnNYR1VzNHFjck1KbnoyS0dHMmo4dWUvNkw5?= =?utf-8?B?NlV3Nmc3SEIrajRTOGt5OUZnK21PZDVXMldXVGhtemdFM3VkTk12VlpaK0cz?= =?utf-8?B?Q2N5dUZpamNzUGo5OFdxMEFUelR6c3Ywc2lKaTljdGxKMGl5dkt1cnVKLzVK?= =?utf-8?B?eXozdkdQWVpoQmJJQkxUalZrR2o5dzQrMDhmeHJjWGY4VW1tbVpuN3M3a0VY?= =?utf-8?B?UDdYU0RNV0dneHRQU3BvQ0NiQTQrRkdQOW82YXk0dTJQdXd3eHVJcnVzVTVj?= =?utf-8?B?WHdpd0tlSGlxSjY2akt2TThuM0duZ0RRUWJCcVI3c2dvZ0JKUllmekkvWnlD?= =?utf-8?B?TUErZXVRT2JxcUNScnNGTlVBbENJeEdFS0pCUm9WME9raldJS1c4Y1pSQlJ2?= =?utf-8?B?cTlsUHA0TnBlWTFwYzZCcFFab3V6VHRtb0Z6LzgxaUlIV3o2cDVMdjRyNDZ4?= =?utf-8?B?N01TTkZnbG13bDNIMWRXU3JIdHArSFJEeWV2bXFyZHZGNEdBOXEwUUxjLzc3?= =?utf-8?B?emZOYytNeFM0U0orOXE4d2ZidWlWV1hEcXdRZz09?= X-Microsoft-Antispam-Message-Info: DGZMWi+SycizfrXFSK2KiSlk0wU0FhWQWGQqql2fVIuYmcjnzlP63r4w5fNT36T0VN5eRrLYz5CZxMVm4hBJbBHTWMoUGGOJNTLKCtJkJZ74tjar41CCCQyec61oJMUb4xCMF1lHH7Xl93eYIzuu4xJLz3zIOt9hFSNvR6E2nE9HWLvL1LrD0z0MDoOokxy/Gla5KzJO3b1lGTYtSOna+AuaKe4gpbMMrALfzTfpAAMmY70PSqqOuvGT2nkQOj8l5+md0pe8JWz2C+TKiMfEmTzzQinjK8i/aPI+HURBOooTebifz4WcFZRuZkaDa+W3XiC8omP2/eTuljM9m3IaCTQHkFVwt/NWXXOkf2MNr64= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4911; 6:vg6+7nPlgruv13gMqepB1FA6cmEvW6QTnvkadYg+arQGaqjnxB54uMG9HoK80zmgEEJQ6iZCvVm0zvMN7zX0rhmQmCHujBnQaCRW9u7+SK3FJibmLBV+5sUEerCwQ/6HC6P3lOlYqTqeHabysQONYUh9OFTl9Fh/shz1ESxb/eTnqjICuXh/xqJqZE72LvwpA+So7Ool0jQR9NC3pO3UCv7W4jVTlXG1tJJj5U828+PHeObbVrTsmzF3UVTE3VPt2dzGPC4Fe15c81Ff+y3dO3MbuFg75WoYtJjRF+rqBaBLsVpYYBjuyKqr4n0gTORymWSi3kmV1FvwsZV9Yn359mwRfs5gAUqIGDZcmGoDwjZaJLFxJKTA5XUIPbS5+VkhjKygRx5MQC/i6E0dP10sa70KTrhRXiepSX6+LOL8ylXXzWPQuTXKh/HjmhKamX3Ic8OmjIAGfAVe6leFBdTXxA==; 5:OxkdD+ciqEoCNCTqqTWCFEFo5pH3z6N4ze74IEpqcQ/SpPrqG8jwvul86qg8EYvQ+DE3XUWqwQXPzLxipSoyWJHZR+VtPkV/udPBLFefeMAHl9ssq2yCvVP6Z1C1o/NXJtzpNwEguOa1JFssN3Yg4Y2VcFXQSj64X1gDS/FS6v0=; 7:/FjHSWkurByKOP2d4LudS/e56eTVBdYr6CObvxiQUM3mZV303DQ/oWUiXYyJVUJOzs6xUCorScuMSFzuHQ6xNjw7k+NM9v3z3eEl4m4ub9LmlprDtSBDLN/4IxJ+RHNNlgHufSZFj5FFFpLKbh6B6ZyaUZ+FfKrCvRerpwwOlwNDk5JgHxtVdMDBKnB4SIhpBNPVpAAugW7KxHM0ofgiAB/wXzqQHZo8gvj5rTsLrsj6wkvgYwQR1hBRkmgxXa/7 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2018 06:59:37.7868 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f7bdcda3-c4ae-4131-ca9c-08d5f77c5cb4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4911 Subject: Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 07:01:07 -0000 Hi Thomas, On 26-07-2018 22:27, Thomas Monjalon wrote: > External Email > >> Anoob Joseph (12): >> examples/l2fwd: move macro definitions to common header >> examples/l2fwd: move structure definitions to common header >> examples/l2fwd: move globally accessed vars to common header >> examples/l2fwd: move dataplane code to new file >> examples/l2fwd: remove unused header includes >> examples/l2fwd: move drain buffers to new function >> examples/l2fwd: optimize check for master core >> examples/l2fwd: move periodic tasks to new function >> examples/l2fwd: skip timer updates for non master cores >> examples/l2fwd: move pkt send code to a new function >> examples/l2fwd: use fprint instead of printf for usage print >> examples/l2fwd: improvements to the usage print > Maintainers of this app look to be against adding complexity. > > In order to get this series accepted, we need more discussions > with more people involved. > So it will miss 18.08. > > It can be discussed in a more global discussion about examples maintenance. > If discussion does not happen, you can request it to the technical board. > Event dev framework and various adapters enable multiple packet handling schemes, as opposed to the traditional polling on queues. But these features are not integrated into any established example application. There are specific example applications for event dev etc, which can be used to analyze an event device or a particular eventdev adapter, but there is no standard application which can be used to compare the real world performance for a system when it's using event device for packet handling and when it's done via polling on queues. The following patch submitted by Sunil was looking to address this issue with l3fwd, https://mails.dpdk.org/archives/dev/2018-March/093131.html Bruce & Jerin reviewed the patch and suggested the addition of helper functions to abstract the event mode additions in applications, https://mails.dpdk.org/archives/dev/2018-April/096879.html This effort of adding helper functions for eventmode was taken up following the above suggestion. The idea is to add eventmode without touching the existing code path. All the eventmode specific additions would go into library so that these need not be repeated for every application. And since there is no change in the existing code path, performance for any vendor should not have any impact with the additions. The scope of this effort has increased since the submission, as now we have Tx adapter as well. Sunil & Konstantin had clarified their concerns, and gave green flag to this approach. https://mails.dpdk.org/archives/dev/2018-June/105730.html https://mails.dpdk.org/archives/dev/2018-July/106453.html I guess Bruce was opening this question to the community. For compute intense applications like ipsec-secgw, eventmode might be the right approach in the first place. Such complex applications would need a scheduler to perform dynamic load balancing. Addition of eventmode in l2fwd was to float around the idea which can then be scaled for more complex applications. If maintainers doesn't have any objection to this, I'm fine with adding this in the next release. Thanks, Anoob