DPDK patches and discussions
 help / color / mirror / Atom feed
* Re: [dpdk-dev] net/i40e: fix error setting for L2TAG
  2020-05-20 21:25 [dpdk-dev] net/i40e: fix error setting for L2TAG Jeff Guo
@ 2020-05-20 10:01 ` Zhang, Qi Z
  2020-05-21  0:22 ` Ye Xiaolong
  1 sibling, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2020-05-20 10:01 UTC (permalink / raw)
  To: Guo, Jia, Xing, Beilei, jianbo.liu, xiaoping.yan
  Cc: Ye, Xiaolong, dev, olivier.matz



> -----Original Message-----
> From: Guo, Jia <jia.guo@intel.com>
> Sent: Thursday, May 21, 2020 5:25 AM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> jianbo.liu@linaro.org; xiaoping.yan@nokia-sbell.com
> Cc: Ye, Xiaolong <xiaolong.ye@intel.com>; dev@dpdk.org; Guo, Jia
> <jia.guo@intel.com>; olivier.matz@6wind.com
> Subject: [dpdk-dev] net/i40e: fix error setting for L2TAG
> 
> Base on HW, if a packet be split into multiple segments, the L2TAG should
> only be valid on the last Rx descriptor. So fix it by setting L2TAG into mbuf
> when processing the last split packet.
> 
> Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from vector
> driver")
> 
> Signed-off-by: Jeff Guo <jia.guo@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev]  net/i40e: fix error setting for L2TAG
@ 2020-05-20 21:25 Jeff Guo
  2020-05-20 10:01 ` Zhang, Qi Z
  2020-05-21  0:22 ` Ye Xiaolong
  0 siblings, 2 replies; 4+ messages in thread
From: Jeff Guo @ 2020-05-20 21:25 UTC (permalink / raw)
  To: beilei.xing, qi.z.zhang, jianbo.liu, xiaoping.yan
  Cc: xiaolong.ye, dev, jia.guo, olivier.matz

Base on HW, if a packet be split into multiple segments, the L2TAG
should only be valid on the last Rx descriptor. So fix it by setting
L2TAG into mbuf when processing the last split packet.

Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from vector driver")

Signed-off-by: Jeff Guo <jia.guo@intel.com>
---
 drivers/net/i40e/i40e_rxtx_vec_common.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h
index 0e6ffa007..31f73f605 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_common.h
+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
@@ -33,6 +33,7 @@ reassemble_packets(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_bufs,
 			if (!split_flags[buf_idx]) {
 				/* it's the last packet of the set */
 				start->hash = end->hash;
+				start->vlan_tci = end->vlan_tci;
 				start->ol_flags = end->ol_flags;
 				/* we need to strip crc for the whole packet */
 				start->pkt_len -= rxq->crc_len;
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] net/i40e: fix error setting for L2TAG
  2020-05-20 21:25 [dpdk-dev] net/i40e: fix error setting for L2TAG Jeff Guo
  2020-05-20 10:01 ` Zhang, Qi Z
@ 2020-05-21  0:22 ` Ye Xiaolong
  2020-05-21  1:33   ` Yan, Xiaoping (NSB - CN/Hangzhou)
  1 sibling, 1 reply; 4+ messages in thread
From: Ye Xiaolong @ 2020-05-21  0:22 UTC (permalink / raw)
  To: Jeff Guo
  Cc: beilei.xing, qi.z.zhang, jianbo.liu, xiaoping.yan, dev, olivier.matz

On 05/20, Jeff Guo wrote:
>Base on HW, if a packet be split into multiple segments, the L2TAG
>should only be valid on the last Rx descriptor. So fix it by setting
>L2TAG into mbuf when processing the last split packet.
>
>Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from vector driver")
>
>Signed-off-by: Jeff Guo <jia.guo@intel.com>
>---
> drivers/net/i40e/i40e_rxtx_vec_common.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h
>index 0e6ffa007..31f73f605 100644
>--- a/drivers/net/i40e/i40e_rxtx_vec_common.h
>+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
>@@ -33,6 +33,7 @@ reassemble_packets(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_bufs,
> 			if (!split_flags[buf_idx]) {
> 				/* it's the last packet of the set */
> 				start->hash = end->hash;
>+				start->vlan_tci = end->vlan_tci;
> 				start->ol_flags = end->ol_flags;
> 				/* we need to strip crc for the whole packet */
> 				start->pkt_len -= rxq->crc_len;
>-- 
>2.20.1
>

Applied to dpdk-next-net-intel, Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] net/i40e: fix error setting for L2TAG
  2020-05-21  0:22 ` Ye Xiaolong
@ 2020-05-21  1:33   ` Yan, Xiaoping (NSB - CN/Hangzhou)
  0 siblings, 0 replies; 4+ messages in thread
From: Yan, Xiaoping (NSB - CN/Hangzhou) @ 2020-05-21  1:33 UTC (permalink / raw)
  To: Ye Xiaolong, Jeff Guo
  Cc: beilei.xing, qi.z.zhang, jianbo.liu, dev, olivier.matz

Hi,

In which dpdk release, this fix will be available?
Thank you.

Best regards
Yan Xiaoping

-----Original Message-----
From: Ye Xiaolong <xiaolong.ye@intel.com> 
Sent: 2020年5月21日 8:23
To: Jeff Guo <jia.guo@intel.com>
Cc: beilei.xing@intel.com; qi.z.zhang@intel.com; jianbo.liu@linaro.org; Yan, Xiaoping (NSB - CN/Hangzhou) <xiaoping.yan@nokia-sbell.com>; dev@dpdk.org; olivier.matz@6wind.com
Subject: Re: [dpdk-dev] net/i40e: fix error setting for L2TAG

On 05/20, Jeff Guo wrote:
>Base on HW, if a packet be split into multiple segments, the L2TAG 
>should only be valid on the last Rx descriptor. So fix it by setting 
>L2TAG into mbuf when processing the last split packet.
>
>Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from 
>vector driver")
>
>Signed-off-by: Jeff Guo <jia.guo@intel.com>
>---
> drivers/net/i40e/i40e_rxtx_vec_common.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h 
>b/drivers/net/i40e/i40e_rxtx_vec_common.h
>index 0e6ffa007..31f73f605 100644
>--- a/drivers/net/i40e/i40e_rxtx_vec_common.h
>+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
>@@ -33,6 +33,7 @@ reassemble_packets(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_bufs,
> 			if (!split_flags[buf_idx]) {
> 				/* it's the last packet of the set */
> 				start->hash = end->hash;
>+				start->vlan_tci = end->vlan_tci;
> 				start->ol_flags = end->ol_flags;
> 				/* we need to strip crc for the whole packet */
> 				start->pkt_len -= rxq->crc_len;
>--
>2.20.1
>

Applied to dpdk-next-net-intel, Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-23 20:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 21:25 [dpdk-dev] net/i40e: fix error setting for L2TAG Jeff Guo
2020-05-20 10:01 ` Zhang, Qi Z
2020-05-21  0:22 ` Ye Xiaolong
2020-05-21  1:33   ` Yan, Xiaoping (NSB - CN/Hangzhou)

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git