From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id AB1CC1B42D; Wed, 10 Oct 2018 09:25:42 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F034D81127; Wed, 10 Oct 2018 07:25:41 +0000 (UTC) Received: from [10.36.112.48] (ovpn-112-48.ams2.redhat.com [10.36.112.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 28A6A18233; Wed, 10 Oct 2018 07:25:34 +0000 (UTC) To: dev@dpdk.org, i.maximets@samsung.com, bruce.richardson@intel.com Cc: tiwei.bie@intel.com, zhihong.wang@intel.com, jfreimann@redhat.com, nicknickolaev@gmail.com, alejandro.lucero@netronome.com, dgilbert@redhat.com, stable@dpdk.org References: <20181009205426.21219-1-maxime.coquelin@redhat.com> <20181009205426.21219-2-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: Date: Wed, 10 Oct 2018 09:25:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181009205426.21219-2-maxime.coquelin@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 10 Oct 2018 07:25:42 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v5 01/19] vhost: fix messages results handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 07:25:43 -0000 Hi Ilya On 10/09/2018 10:54 PM, Maxime Coquelin wrote: > Return of message handling has now changed to an enum that can > take non-negative value that is not zero in case a reply is > needed. But the code checking the variable afterwards has not > been updated, leading to success messages handling being > treated as errors. > > External post and pre callbacks return type needs also to be > changed to the new enum, so that its handling is consistent. > This is done in this patch alongside with the convertion of > its only user, vhost-crypto backend. > > Fixes: 0bff510b5ea6 ("vhost: unify message handling function signature") > > Signed-off-by: Maxime Coquelin > Acked-by: Ilya Maximets Sorry, I just notice I forgot to remove your ack from the commit message as it has quite changed since the previous version. Please let me know if the patch is OK to you. Regards, Maxime