From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 278EB45B17;
	Sat, 12 Oct 2024 04:07:44 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AC9C240272;
	Sat, 12 Oct 2024 04:07:43 +0200 (CEST)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id 33BF040268
 for <dev@dpdk.org>; Sat, 12 Oct 2024 04:07:41 +0200 (CEST)
Received: from mail.maildlp.com (unknown [172.19.88.105])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4XQRfm3mBsz10N2q;
 Sat, 12 Oct 2024 10:05:52 +0800 (CST)
Received: from kwepemm600004.china.huawei.com (unknown [7.193.23.242])
 by mail.maildlp.com (Postfix) with ESMTPS id 919D114011F;
 Sat, 12 Oct 2024 10:07:39 +0800 (CST)
Received: from [10.67.121.59] (10.67.121.59) by kwepemm600004.china.huawei.com
 (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Sat, 12 Oct
 2024 10:07:38 +0800
Message-ID: <e19fb1a5-2b16-d86c-964a-e5afa80b98e3@huawei.com>
Date: Sat, 12 Oct 2024 10:07:38 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH v10 0/2] power: introduce PM QoS interface
To: <dev@dpdk.org>, <thomas@monjalon.net>, <ferruh.yigit@amd.com>,
 fengchengwen <fengchengwen@huawei.com>
CC: <mb@smartsharesystems.com>, <anatoly.burakov@intel.com>,
 <david.hunt@intel.com>, <sivaprasad.tummala@amd.com>,
 <stephen@networkplumber.org>, <david.marchand@redhat.com>,
 <liuyonglong@huawei.com>
References: <20240320105529.5626-1-lihuisong@huawei.com>
 <20240912023812.30885-1-lihuisong@huawei.com>
 <851d5fbf-d5d5-4b14-b0cf-b463e071bea4@huawei.com>
From: "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <851d5fbf-d5d5-4b14-b0cf-b463e071bea4@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.121.59]
X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To
 kwepemm600004.china.huawei.com (7.193.23.242)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Thomas and Ferruh,

Kindly ping for merge.

/Huisong
在 2024/9/12 11:07, fengchengwen 写道:
> Series-reviewed-by: Chengwen Feng <fengchengwen@huawei.com>
Thanks chengwen.
>
> On 2024/9/12 10:38, Huisong Li wrote:
>> The deeper the idle state, the lower the power consumption, but the longer
>> the resume time. Some service are delay sensitive and very except the low
>> resume time, like interrupt packet receiving mode.
>>
>> And the "/sys/devices/system/cpu/cpuX/power/pm_qos_resume_latency_us" sysfs
>> interface is used to set and get the resume latency limit on the cpuX for
>> userspace. Please see the description in kernel document[1].
>> Each cpuidle governor in Linux select which idle state to enter based on
>> this CPU resume latency in their idle task.
>>
>> The per-CPU PM QoS API can be used to control this CPU's idle state
>> selection and limit just enter the shallowest idle state to low the delay
>> after sleep by setting strict resume latency (zero value).
>>
>> [1] https://www.kernel.org/doc/html/latest/admin-guide/abi-testing.html?highlight=pm_qos_resume_latency_us#abi-sys-devices-power-pm-qos-resume-latency-us
>>
>> ---
>>   v10:
>>    - replace LINE_MAX with a custom macro and fix two typos.
>>   v9:
>>    - move new feature description from release_24_07.rst to release_24_11.rst.
>>   v8:
>>    - update the latest code to resolve CI warning
>>   v7:
>>    - remove a dead code rte_lcore_is_enabled in patch[2/2]
>>   v6:
>>    - update release_24_07.rst based on dpdk repo to resolve CI warning.
>>   v5:
>>    - use LINE_MAX to replace BUFSIZ, and use snprintf to replace sprintf.
>>   v4:
>>    - fix some comments basd on Stephen
>>    - add stdint.h include
>>    - add Acked-by Morten Brørup <mb@smartsharesystems.com>
>>   v3:
>>    - add RTE_POWER_xxx prefix for some macro in header
>>    - add the check for lcore_id with rte_lcore_is_enabled
>>   v2:
>>    - use PM QoS on CPU wide to replace the one on system wide
>>
>> Huisong Li (2):
>>    power: introduce PM QoS API on CPU wide
>>    examples/l3fwd-power: add PM QoS configuration
>>
>>   doc/guides/prog_guide/power_man.rst    |  24 ++++++
>>   doc/guides/rel_notes/release_24_11.rst |   5 ++
>>   examples/l3fwd-power/main.c            |  24 ++++++
>>   lib/power/meson.build                  |   2 +
>>   lib/power/rte_power_qos.c              | 111 +++++++++++++++++++++++++
>>   lib/power/rte_power_qos.h              |  73 ++++++++++++++++
>>   lib/power/version.map                  |   4 +
>>   7 files changed, 243 insertions(+)
>>   create mode 100644 lib/power/rte_power_qos.c
>>   create mode 100644 lib/power/rte_power_qos.h
>>
> .