From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Jonas Pfefferle <pepperjo@japf.ch>,
Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling
Date: Tue, 16 Jan 2018 10:07:51 +0000 [thread overview]
Message-ID: <e1bc83ba-3528-cf4b-7e3a-bdd5f1ce498f@intel.com> (raw)
In-Reply-To: <web-42154786@switchplus-mail.ch>
On 15-Jan-18 12:22 PM, Jonas Pfefferle wrote:
>
> On Sat, 13 Jan 2018 23:49:30 +0100
> Thomas Monjalon <thomas@monjalon.net> wrote:
>> 13/01/2018 13:15, Burakov, Anatoly:
>>> On 11-Jan-18 11:45 PM, Thomas Monjalon wrote:
>>> > 07/11/2017 10:50, Jonas Pfefferle1:
>>> >>> Is there something urgent for 17.11?
>>> >>> Or can it be refined in 18.02?
>>> >>
>>> >> Nothing urgent. We can refine this for 18.02.
>>> >>
>>> >>> Anatoly, any thought?
>>> > > Anatoly, Jonas, how do you want to proceed with this patch?
>>> >
>>> I don't see anything to be refined here, it's a simple bug fix - code
>>> assumes noiommu mode support is always available, when it might not
>>> be the case on older kernels.
>>
>> As a bug fix, the title must start with "fix" and a tag "Fixes:"
>> must be added to help with backport.
>> At the same time, the explanation of the bug must be added in
>> the commit log please.
>>
>> Thanks
>
> It's not really a bug fix since it does not change the semantic of the
> function but just adds nicer error handling.
Well, as far as i can tell, it *does* change semantics - previously, if
noiommu mode file was not found, we returned -1, now we return 0.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-01-16 10:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 15:59 Jonas Pfefferle
2017-11-06 20:25 ` Thomas Monjalon
2017-11-07 9:05 ` Jonas Pfefferle1
2017-11-07 9:40 ` Thomas Monjalon
2017-11-07 9:50 ` Jonas Pfefferle1
2018-01-11 23:45 ` Thomas Monjalon
2018-01-13 12:15 ` Burakov, Anatoly
2018-01-13 22:49 ` Thomas Monjalon
2018-01-15 12:22 ` Jonas Pfefferle
2018-01-15 16:11 ` Thomas Monjalon
2018-01-16 16:08 ` Jonas Pfefferle
2018-01-16 17:01 ` Maxime Coquelin
2018-01-17 8:48 ` Jonas Pfefferle
2018-01-17 8:55 ` Maxime Coquelin
2018-01-17 10:34 ` Jonas Pfefferle
2018-01-16 10:07 ` Burakov, Anatoly [this message]
2018-01-16 16:09 ` Jonas Pfefferle
2018-01-13 12:05 ` Burakov, Anatoly
2018-01-19 17:37 ` Maxime Coquelin
2018-01-20 14:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1bc83ba-3528-cf4b-7e3a-bdd5f1ce498f@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=pepperjo@japf.ch \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).