From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Olivier Matz <olivier.matz@6wind.com>, <dev@dpdk.org>,
Neil Horman <nhorman@tuxdriver.com>,
John McNamara <john.mcnamara@intel.com>,
"Marko Kovacevic" <marko.kovacevic@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] doc: announce PMD API change for set default MAC
Date: Tue, 30 Jan 2018 09:06:01 +0300 [thread overview]
Message-ID: <e1d01d38-eaf1-448e-bac2-1d9dec01bcb9@solarflare.com> (raw)
In-Reply-To: <20180129171339.20896-1-olivier.matz@6wind.com>
On 01/29/2018 08:13 PM, Olivier Matz wrote:
> Announce internal PMD API change in the function to set the default MAC
> address. The objective is to be able to notify errors occurring in the
> PMD.
>
> Link: https://dpdk.org/dev/patchwork/patch/32284/
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 43a39d827..8ad4407c2 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -76,3 +76,11 @@ Deprecation Notices
> * mbuf: The mbuf flags ``PKT_TX_VLAN_PKT`` and ``PKT_TX_QINQ_PKT`` are
> respectively renamed as ``PKT_TX_VLAN`` and ``PKT_TX_QINQ``. The old
> names will be removed in v18.08.
> +
> +* ethdev: The prototype and the behavior of
> + ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return code
> + will be added to notify the caller if an error occurred in the PMD. In
> + ``rte_eth_dev_default_mac_addr_set()``, the new default MAC address
> + will be copied in ``dev->data->mac_addrs[0]`` only if the operation is
> + succesfull. This modification will only impact the PMDs, not the
> + applications.
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
next prev parent reply other threads:[~2018-01-30 6:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 17:13 Olivier Matz
2018-01-30 6:06 ` Andrew Rybchenko [this message]
2018-01-31 19:11 ` Ferruh Yigit
2018-02-13 12:42 ` Shahaf Shuler
2018-02-14 0:00 ` Thomas Monjalon
2018-02-14 17:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1d01d38-eaf1-448e-bac2-1d9dec01bcb9@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).