From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB42D41D30; Tue, 21 Feb 2023 16:29:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DF68431EF; Tue, 21 Feb 2023 16:29:04 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 8142C40E0F for ; Tue, 21 Feb 2023 16:29:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676993342; x=1708529342; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=iVMe5mrATonUy+cHLPwsa1F3BEvxlQEbARfjykBYDZ8=; b=aRLmlN58B0W+riTAQ8EKj26tJJOm2LOnKJUkgKAD3TpisZNWpUCZbvod PpcwE9MkUiyqkO/8d2Z96PtHapN6NF8eM6CDsgG/C9/aPqkFgZUPdVkVl ZamcR8WTq0hK8+P6SU5E8itSEjQVFxWFgsT+AfHcGTsmyA5UzfZjDXL3m 42jpZoP39+MF+i8wPMfuSlkQlIZfxwiXsNsu4sghHJNSEeXk3PQUq/bZ/ LmFKpXdfxCHGssaIeP7HTe90CdBCjWb5E4qgdQH7nLc8F5bmr69Vsu57D slM2nMKESzxLUXcxYKztAZ/Xy5N4iMZdvRbjy5WG6kXLjX28LuJ8Pxl8F A==; X-IronPort-AV: E=McAfee;i="6500,9779,10628"; a="334022934" X-IronPort-AV: E=Sophos;i="5.97,315,1669104000"; d="scan'208";a="334022934" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2023 07:28:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10628"; a="781036258" X-IronPort-AV: E=Sophos;i="5.97,315,1669104000"; d="scan'208";a="781036258" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 21 Feb 2023 07:28:51 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 21 Feb 2023 07:28:50 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 21 Feb 2023 07:28:50 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 21 Feb 2023 07:28:50 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 21 Feb 2023 07:28:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lnKazJrdBVa3tu4CNKZ/wzkVU5bJPu4whKe4AkWy5HD/Kkhm8BSVl0wtw5iLBnZ0r74EqcMaZkJJNlAyM9AwMk7+NiKogbZ+laHiIlvCDiLDmqdZMKa6jxwaRYhukiEyT68/06LzAN3nn6nVPqpJRu0IvCmskhsn2vmwTLtiHznFMnNNXiogaQSJk92r9tt6ATYG+b7YiPc6hv/njGiX+BHW3ka66gucPfiLHUDXnUOOWrl+zZkZsqZPy6pElj5bKbgeKqN+EbdHoHHBQC1EBQ3I8Y2DODD7ajdWGr6pVdt6vzdPJGDFIEf9Nx5C8lLXbLEo2j8HmFnqxDIOILRLVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iVMe5mrATonUy+cHLPwsa1F3BEvxlQEbARfjykBYDZ8=; b=G9vdaI/ybX016I/juY+yHRumxJ/Rz2mS9roOyTEdKrdbzYoHOqVF6AwDJjg5tiwLE7W4bFuYmJ9edXvLyiQ39ROYMA1dg5PnqMq8htLVNMluoKWHNGFCu6r6KqZAbT9NPSAAHo4rUcWj/V5xHFLVORWFzN5tXLOmxFIrt+GVhRkEtDhQshLeCBUrndnXEIotJEQvj017Su6vfoCGyRPfItDHhXw2yfW4pwRzT27TYNE+jv4HHjI2XO8jiC7bEVQKsyGBM/Ziraaxaf2q12vV+f/ho+SMyHRMZ+BFVDLi8n1yjCtJI5NpNh4slRXGLRHJyRysNhEJ1hEj21CeSLzbZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by CH0PR11MB5346.namprd11.prod.outlook.com (2603:10b6:610:b9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 15:28:48 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::944c:b2ed:2b29:99fd]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::944c:b2ed:2b29:99fd%3]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 15:28:48 +0000 Message-ID: Date: Tue, 21 Feb 2023 20:58:35 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [dpdk-dev] [RFC] testpmd: support user-id attribute To: Thomas Monjalon , Eli Britstein CC: "dev@dpdk.org" , Slava Ovsiienko , Ori Kam , Matan Azrad , Gaetan Rivet , Nir Anteby , Yuying Zhang , Andrew Rybchenko , Asaf Penso , , , , , Ivan Malov References: <20220704082433.3698761-1-elibr@nvidia.com> <2087714.otsE0voPBg@thomas> Content-Language: en-US From: "Singh, Aman Deep" In-Reply-To: <2087714.otsE0voPBg@thomas> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PR01CA0237.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:eb::19) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB0062:EE_|CH0PR11MB5346:EE_ X-MS-Office365-Filtering-Correlation-Id: b51a34aa-531c-423b-4c9d-08db1420538c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8EzCYHsZfyve47D3z+BAuTTPoYRw6iH+dmhj4uF4ysSkjxYc9Cwocm3dLvedq2HRYx8xw6/hJzNNB3IkcR3W85vi7mjQurmwQrg19XqIpXWyX7BpYu1k5UE/80VNJuv1hdexR6SUXdaryENoZSDw+oabfXsloE54ldj4m/Vq/n5SveCIlZ7ouOSszkqIBsQO2V/DP3aKIfYy9G0wP04qWjtTOwAvhw7eUkph8XZEXFESyGvLTz3XZvFByPgupylwo0mWD2HYJCz84+gxzXAuj5KDZiNwnq6kztBAvMuumiHzfX4hCg8L/qRhtPwXSPx8vZytkWtVqkbG0tYU1tdaKA3onczmqwWOWh+BqC7trjvxoNuidzZXjHFGEORS9arXfaptB386rS7jUH5oDWlf/Wdk7aJqicjz5mageH2CjEWKVJ2CksqXtPvO8m0KGYJC52QsvHh+EcqPvvrf4PekLoXp+fKTKUB5492hLF5MhtUx+/kQUU/DVTjTxGCHD+jLcF/Xx5HYdNJ+4cqa4v2Ms+9HgNv0998p4Efo8oJmWEkXCnA+Z3aVSMiA2Q2Li/aF2foVpWWH+WySDtEpugPCjqyVb1xqQeXggvWCeFFONNgSBgPJN7fZ+tHIPhdY0fGOO+zu+r0oUNHsnZer4ROP9Grp+Pe2wxkGZVn5DFduHum05dR2AYkZ9wgCH6A8OMSagj7Tp9ffB0PdLuCLUCJ8eQRmgVmWkKLCUD3M8wMqgUM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(39860400002)(346002)(366004)(396003)(376002)(451199018)(36756003)(54906003)(110136005)(83380400001)(316002)(6666004)(6486002)(2616005)(6506007)(53546011)(41300700001)(6512007)(26005)(186003)(8936002)(2906002)(86362001)(31696002)(5660300002)(7416002)(4326008)(478600001)(66556008)(66476007)(82960400001)(38100700002)(66946007)(8676002)(66899018)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkJuek5VVVZid2x3NEpOT0NFRjkzTVhNTkxpRlBIYVZzQzZ0bDQ3NHNYbDJx?= =?utf-8?B?RGtXZ0Y5UjFvaGUwdERGNEdDeStTRFhjbTVWbm1yYW5PcTJEWDNCU01vYXpW?= =?utf-8?B?ZDJkbHQxWjhyWHNVWjhvRnRZSjB0V0w3VEdmcWJDL2pDYUxQb25IcHF4VG1x?= =?utf-8?B?c3UweXc1cklSUWJNb3lOendySmlpSDdHVFFmOEhmcGtoZlN0N1h4UW82NlhK?= =?utf-8?B?Z3pCWENEMWVWY1duWXJ4SzQ1eVhDdXJMemNsWUQ5RUR3Z2k0UWF6bG9IdHNQ?= =?utf-8?B?NFE2QTZ0ZWFqWEg1QjE2MzZaSko5UWRJV0hWeklBOUxwSHhSVkYyUW9YSTdM?= =?utf-8?B?eHFkbWcrdVVVaHAyVkx0SlFCOGRsSzdiTTNKNjdzVzVsMFhFTitrdzR1R3pk?= =?utf-8?B?UUw0a0tGTDhXeEdoZUVPVHJGQldPV0U2YkdUK0JBNUoxUkFaWmV1RDJRV2FV?= =?utf-8?B?eVZWeWR4WDNGckFUTHhjazdPZmVIQnp0aWRaOEFpNUtpbEhJeW5JdWQ5K0NT?= =?utf-8?B?eENpZUlwZUF3Y2s2NC9seUlmUzR5VlZlUFNiNzZSQmVhcjdUbDRsZEZReEFz?= =?utf-8?B?UENKRGFEQjJudnpqeE1rdkdmc3FSOFVQRzY2ejk1RUJ6RXFwRkVudE5GT0lO?= =?utf-8?B?UmtySndHSnJoY0pmMjB2TXMwdWJyaWdmY09IUmZLc2V6Vjk1OVFmR2RYQnMv?= =?utf-8?B?NS80RnpiL2VaNUdnNFhmczJtdms0d0NLdkZwQ25IOE5uL1dhekJGKzZFdlJn?= =?utf-8?B?M25TOVZKRUlSNkRwbkhlVS9SNVVvcnlOc0tRNHkxcnFJQVJQeGdtL0ticDRw?= =?utf-8?B?OVpJU0JuaVVUaUhSVWlSUmJabFZmalFFUTZ0eXUxVkJzMURWS0V2dHdzVVpv?= =?utf-8?B?WW83bXNMaVZMeVVuczZCRjZtaU5xYmhhb1VaK3ZpZ0U1M2R5TVRwVXlBbXp0?= =?utf-8?B?bC9heWVwUDV2N0JBcittamR0QXM4Ym5oUGdXZkt2ZWVSL0VYcUlUQ2ppUjhp?= =?utf-8?B?MU90SnhnNDh3eFMrdkQvOHVxcUszUWJ4cWJBT2ZOK0krU1cwN0pnUVRxdmVP?= =?utf-8?B?MVhVc2kyTFJNamJxSFlGdDhrSHE4UkM3YllHeXFXTE03TTcrUVBVTUY5WFZV?= =?utf-8?B?SjRRQmhzQmdzbEVJRDl4SkRtZDZBWEZwWnVsUVVtU29jZVZjT3FGWm1pcXRC?= =?utf-8?B?VzYzQkNUUnQ4a25mb0puUWtPVm1xUlZUNjV4b0pLaTBTVmFqRzNFSkhDUURa?= =?utf-8?B?cmlRNkNwWUQ4b2lkZFJWL1c2aDVnbFV6RFYwb1M0NHdYZGhtN29yZzdUelkv?= =?utf-8?B?WVF5bk5ncUJMeXBEVFVzOHFrbFIzeHZkeDFVUkhOaThWM0kyRXJoOXJURTZ4?= =?utf-8?B?M1lhS3FpOUMvcDBmelZubnBGVUcxeGpFOUhkQWFicGFISFpEU2xXV3dBbXY1?= =?utf-8?B?RmQyWDQ5aGR6dkx2WklhZ0x0OTRrYy96ZHFwRThwOGgrM1QyRitwbng5azBT?= =?utf-8?B?d291U1FoV2pwejlkM0RhS2tKcTVDS3NZdytKclBlK3kyRVgvTWNxWmdmQkNq?= =?utf-8?B?TlgydmlUQ1p4UEdNMExteHdGNXZLQTRRTnJRUVRtYVQ0Rkk1Nk15UU5YMG9G?= =?utf-8?B?Y2NUWWpzMWhVM2o2MTNaL3o0TW1pa2xnV01LWlZEaE51dFU4NlFCRXVzVUx1?= =?utf-8?B?aVhuMDNrVzhqelREZ1VQNnkzUXFUYlFndG9DdWdZbFBzeENPUlpHMEV0U2tR?= =?utf-8?B?Z2xsUitOS1hJL3pvOUFiWTNEQ3FpNU9ZbWx0QUR6S0VLRFNRZmpjbFI1MzBI?= =?utf-8?B?SC84T1RIU2pyRFVsQ2RCQUw0RzZGK1NCSzlDZ0xLKzFjUkJNa2EzbVBaS3NG?= =?utf-8?B?TVN4ZHVYY2xzVW5Ra05LUDVuVGlLdEJybTNaZllqSWVLMTY5Qnc1QjVtTW1P?= =?utf-8?B?TVpFMkF4YUpuWXhtdWJPMnF5WVVPL3Y1ayt4TVBFeTFINlVWWWdhNmpiVEJY?= =?utf-8?B?cmdJZG9JU3pkRHR1L1RhVkprZkx1dEhwUjRVUFZOaFlpN1pVNjR2eVVrVi9T?= =?utf-8?B?NGRTeXIvTEZhK1BINDgyY25WNDZYV3gxZEI3U3A0WUVQRGVqMmFDUjhhTVA2?= =?utf-8?B?RVZHSnhkbG9PS2Vhd0ZHTXRQTytjWjQwd1ptbTkybW00RDQvMGpNQ0Jzc2lw?= =?utf-8?B?TGc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: b51a34aa-531c-423b-4c9d-08db1420538c X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 15:28:47.8144 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tRl3bCP6GFoDYusZh6AqQ5G+lBKs4C7NCLAxeVm777Zu6E+7u/bRvz6kAMG9k8TK4PCi+llfSrJdL4YCT9TXT7C+vsHY1bAfcjGr/U0lrb0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5346 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org As per RFC, I guess possible testpmd implementation will have a mapping between user-id(new) <=> rule-id (old/testpmd) And this mapping will be maintained in testpmd code. Please check, if that is how it is planned? Another option I feel that this mapping done outside, by intermediate script OVS_log (with user id) => script => testpmd flow commands Any other options/comments are welcome. Thanks Aman On 2/21/2023 3:56 PM, Thomas Monjalon wrote: > This feature assigns custom IDs to flow rules > so a complete sequence of commands can prepared in a script. > As a test application, I think it is really valuable to be able > to script a sequence. > > Any other opinions? > If you want to see this feature please speak to encourage its development. > > > 30/01/2023 11:03, Asaf Penso: >> Hello Aman, >> Can you clarify your intention? Like Eli mentioned, the group_id is less relevant for that purpose. Even with the same group_id we wish to have several different flows with different user-id. >> >> All, >> Do you have any other comments? >> We would like to proceed with the process of sending v1, review, and integrate. >> >> Regards, >> Asaf Penso >> >>> -----Original Message----- >>> From: Eli Britstein >>> Sent: Sunday, 7 August 2022 10:01 >>> To: Singh, Aman Deep ; dev@dpdk.org >>> Cc: Slava Ovsiienko ; Ori Kam ; >>> Asaf Penso ; Matan Azrad ; Gaetan >>> Rivet ; Nir Anteby ; Yuying >>> Zhang ; Ferruh Yigit ; >>> Andrew Rybchenko ; NBU-Contact- >>> Thomas Monjalon (EXTERNAL) >>> Subject: RE: [dpdk-dev] [RFC] testpmd: support user-id attribute >>> >>> Hi Aman, >>> >>> No, the group attribute has its own meaning, so it cannot be used for this >>> purpose, unless I misunderstood your meaning. >>> >>> Thanks, >>> Eli >>> >>>> -----Original Message----- >>>> From: Singh, Aman Deep >>>> Sent: Thursday, July 28, 2022 5:07 PM >>>> To: dev@dpdk.org; Eli Britstein >>>> Cc: Slava Ovsiienko ; Ori Kam >>>> ; Asaf Penso ; Matan Azrad >>>> ; Gaetan Rivet ; Nir Anteby >>>> ; Yuying Zhang ; Ferruh >>>> Yigit ; Andrew Rybchenko >>>> ; NBU-Contact- Thomas Monjalon >>>> (EXTERNAL) >>>> Subject: Re: [dpdk-dev] [RFC] testpmd: support user-id attribute >>>> >>>> External email: Use caution opening links or attachments >>>> >>>> >>>> Hi Eli, >>>> >>>> In RTE flow there is support for group_id attribute(u32). >>>> Similar to the example you gave- >>>> >>>> testpmd> flow create 0 group 0x1234 ingress pattern eth / end actions >>>> count / drop / end >>>> >>>> Please check if it fits the requirement. >>>> >>>> Regards >>>> Aman >>>> >>>> >>>> On 7/20/2022 2:14 AM, Thomas Monjalon wrote: >>>>> +Cc ethdev and testpmd maintainers >>>>> >>>>> Any feedback about this need and solution? >>>>> >>>>> >>>>> 04/07/2022 10:24, Eli Britstein: >>>>>> Upon creation of a flow, testpmd assigns it a flow ID. Later, the >>>>>> flow ID is used for flow operations (query, destroy, dump). >>>>>> >>>>>> The testpmd application allows to manage flow rules with its IDs. >>>>>> The flow ID is known only when the flow is created. >>>>>> In order to prepare a complete sequence of testpmd commands to >>>>>> copy/paste, the flow IDs must be predictable. >>>>>> >>>>>> The idea brought here is to allow providing some user-defined ID, >>>>>> chosen in advance of the effective flow creation. >>>>>> >>>>>> >>>>>> Example: >>>>>> >>>>>> testpmd> flow create 0 ingress user_id 0x1234 pattern eth / end >>>>>> testpmd> actions >>>>>> count / drop / end >>>>>> Flow rule #0 created, user-id 0x1234 >>>>>> >>>>>> testpmd> flow destroy 0 user_id rule 0x1234 >>>>>> Flow rule #0 destroyed, user-id 0x1234 Here, "user_id" is a flag >>>>>> that signifies the "rule" ID is the user-id. >>>>>> >>>>>> The motivation is from OVS. OVS dumps its "rte_flow_create" calls to >>>>>> the log in testpmd commands syntax. As the flow ID testpmd would >>>>>> assign is unkwon, it cannot log valid "flow destroy" commands. >>>>>> >>>>>> With the enhancement described above, valid testpmd commands can be >>>>>> created in a log to copy/paste to testpmd. >>>>>> The application's flows sequence can then be played back in testpmd, >>>>>> to enable enhanced dpdk debug capabilities of the applications's >>>>>> flows in a controlled environment of testpmd rather than a dynamic, >>>>>> more difficult to debug environment of the application. > > > >