From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11BF8A046B for ; Sun, 18 Aug 2019 11:47:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32CAEDE3; Sun, 18 Aug 2019 11:47:10 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 277972AB for ; Sun, 18 Aug 2019 11:47:09 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id D6BBC400056; Sun, 18 Aug 2019 09:47:07 +0000 (UTC) Received: from [192.168.1.11] (85.187.13.152) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 18 Aug 2019 10:47:00 +0100 To: Pavan Nikhilesh Bhagavatula , "Jerin Jacob Kollanukkaran" , "ferruh.yigit@intel.com" , John McNamara , "Marko Kovacevic" , Thomas Monjalon CC: "dev@dpdk.org" References: <20190816055511.2322-1-pbhagavatula@marvell.com> <20190816055511.2322-4-pbhagavatula@marvell.com> <4ca361c2-c350-6888-e5c3-5d3454af35ab@solarflare.com> From: Andrew Rybchenko Message-ID: Date: Sun, 18 Aug 2019 12:46:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [85.187.13.152] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24854.003 X-TM-AS-Result: No-8.529600-8.000000-10 X-TMASE-MatchedRID: byfwvk+IcRkeimh1YYHcKPZvT2zYoYOwC/ExpXrHizzHoLp1yJ83GMTj UGHqEXpx4QnYkIC5xsWsfpX8uF+TtOtsQZv7lD95MiMrbc70Pfe3xwqfnvnKHh81+yG62AKW079 j1EwNbJRE06krXZg2MmB1WhaKRr7kPzeZcPbTUUT4KPASpfWnubvGYJkNeu61Bph69XjMbdlAHO g8qEtqyNpTvcHSSI8FgS3Vjc49psnlW1X3S7HG10r0JusapgjyUg5zxCPHJW2YeMTPaAHLLX06x SvNHRHXejpyiV78IFofq/Nq0zU6zW6VeGD4IV/gYKm742WlIN5V1kAYC5kpwhS+f3d7BiKCglVb ihMOL/7eK42qKT00vJBMbEvm5vThOlhoODuWFvBuh7qwx+D6T30tCKdnhB581B0Hk1Q1KyLUZxE AlFPo8/cUt5lc1lLgfSMcxA+ES9m1cNaNnRgu8tOdkN35mYVN52KcQpF1pRFRg1M1dlbYn5I/Hi X8mBM/RbKaGpXwORMO5a8dKTdMudKGuJ7NoPM6evlRtbVMjGPwHX5+Q8jjw1wuriZ3P6dErIJZJ bQfMXRqaM5LmpUkwzunJXJz8X1QftwZ3X11IV0= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--8.529600-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24854.003 X-MDID: 1566121628-GiNUMBUXj1iz Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 3/7] ethdev: add flow action type update as an offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/17/19 5:23 PM, Pavan Nikhilesh Bhagavatula wrote: >>> enable/disable PMDs write to `rte_mbuf::hash::fdir::hi`. >> Notes similar to RSS hash. >> >> It requires better motivation why. It lets Rx queue know that >> it will be used as flow action MARK target and the queue should >> be configured to deliver the mark from NIC to PMD and processed >> in the driver. >> >> Also I think that flow API action MARK documentation should be >> updated to mentioned the offload. > Ack will reword the commit log and update the documentation. >>> Signed-off-by: Pavan Nikhilesh >>> --- >>> doc/guides/nics/features.rst | 12 ++++++++++++ >>> lib/librte_ethdev/rte_ethdev.h | 1 + >>> 2 files changed, 13 insertions(+) >>> >>> diff --git a/doc/guides/nics/features.rst >> b/doc/guides/nics/features.rst >>> index f79b69b38..d67430d90 100644 >>> --- a/doc/guides/nics/features.rst >>> +++ b/doc/guides/nics/features.rst >>> @@ -594,6 +594,18 @@ application to set ptypes it is interested in. >>> * **[provides] mbuf**: ``mbuf.packet_type``. >>> >>> >>> +.. _nic_features_flow_action_type_update: >> May be  _nic_features_flow_mark ? >> >>> + >>> +Flow type update >> May be "Flow mark delivery" ? > I named it flow action type update because we use the same flag to represent two different > flow types i.e. RTE_FLOW_ACTION_TYPE_FLAG and RTE_FLOW_ACTION_TYPE_MARK. > > I'm not so sure about the name RX_OFFLOAD_FLOW_MARK too because mbuf might have ol_flags > marked for ACTION_TYPE_FLAG. Let me know your thoughts on this. I forgot about RTE_FLOW_ACTION_TYPE_FLAG and really care about mark only since it is 32-bit vs one. Anyway may be it is more correct to care about both. If so,  may be _nic_features_flow_flag_mark and "Flow flag/mark update"? > I will modify the name once we come to an agreement. > >>> +---------------- >>> + >>> +Supports flow action type update to ``mbuf.ol_flags`` and >> ``mbuf.hash.fdir.hi``. >>> + >>> +* **[uses] rte_eth_rxconf,rte_eth_rxmode**: >> ``offloads:DEV_RX_OFFLOAD_FLOW_TYPE``. >> >> DEV_RX_OFFLOAD_FLOW_MARK, not TYPE. > Ack, will fix in v2. > >> >> >>> +* **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_FDIR``, >> ``mbuf.ol_flags:PKT_RX_FDIR_ID;``, >>> + ``mbuf.hash.fdir.hi`` >>> + >>> + >>> .. _nic_features_timesync: >>> >>> Timesync >>> diff --git a/lib/librte_ethdev/rte_ethdev.h >> b/lib/librte_ethdev/rte_ethdev.h >>> index 889486a11..4a0cff830 100644 >>> --- a/lib/librte_ethdev/rte_ethdev.h >>> +++ b/lib/librte_ethdev/rte_ethdev.h >>> @@ -1014,6 +1014,7 @@ struct rte_eth_conf { >>> #define DEV_RX_OFFLOAD_SCTP_CKSUM 0x00020000 >>> #define DEV_RX_OFFLOAD_OUTER_Udrivers/net/sfc/base/rhead_ev.c.origDP_CKSUM 0x00040000 >>> #define DEV_RX_OFFLOAD_RSS_HASH 0x00080000 >>> +#define DEV_RX_OFFLOAD_FLOW_MARK 0x00100000 >>> >>> #define DEV_RX_OFFLOAD_CHECKSUM >> (DEV_RX_OFFLOAD_IPV4_CKSUM | \ >>> DEV_RX_OFFLOAD_UDP_CKSUM | \ >> Add to rte_rx_offload_names