From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 55599A0C47;
	Thu,  7 Oct 2021 12:07:17 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D7F934114F;
	Thu,  7 Oct 2021 12:07:16 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 278B840040
 for <dev@dpdk.org>; Thu,  7 Oct 2021 12:07:16 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 803777F508;
 Thu,  7 Oct 2021 13:07:15 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 803777F508
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1633601235;
 bh=zHODbxzg9hQLnDqSwkE8vAaKBI5Qy2yg4R68AT7JAXA=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=um+8l0OSp+rgFYizwTN+rsly0ppS0/nfDEhX9QxGzcXo2fRgyOGbQjlWyEDYOD5Nm
 DQKIqZber+L22Z7uLzBvKBqnITRNQUDrccz2dUrww5zg8FOtyT/iicrVyV0wTSZ/e0
 m4sy9H5ONGYa9Dg7bh0buIPdBZZpzTHJSA/93zbE=
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, Ori Kam <orika@nvidia.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>
References: <20210915210444.3126008-1-thomas@monjalon.net>
 <20210923093916.3050958-1-thomas@monjalon.net>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <e2297f22-0a1d-8a10-716f-f2a42e6704cf@oktetlabs.ru>
Date: Thu, 7 Oct 2021 13:07:15 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20210923093916.3050958-1-thomas@monjalon.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: replace bit shifts with macros
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/23/21 12:39 PM, Thomas Monjalon wrote:
> The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts.
> The macro UINT64C is also used to replace remaining occurrences of ULL.
> 
> Only bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason.
> 
> The API of rte_mtr and rte_tm is using enums for 64-bit variables.
> As they are enums, RTE_BIT32 is used.
> The corresponding struct members should be converted to 32-bit.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>