From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Dekel Peled <dekelp@nvidia.com>,
Xiaoyu Min <jackmin@mellanox.com>,
Jasvinder Singh <jasvinder.singh@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 5/5] net/softnic: update headers size calculation
Date: Tue, 17 Nov 2020 10:30:12 +0000 [thread overview]
Message-ID: <e230fc1e-b1a9-f4ce-0076-d83d9f881425@intel.com> (raw)
In-Reply-To: <MN2PR12MB437541064CC79691A959E97ABBE30@MN2PR12MB4375.namprd12.prod.outlook.com>
On 11/16/2020 7:09 PM, Dekel Peled wrote:
< Please don't top post, reply moved to the bottom >
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Monday, November 16, 2020 6:27 PM
>> To: Xiaoyu Min <jackmin@mellanox.com>; Jasvinder Singh
>> <jasvinder.singh@intel.com>; Cristian Dumitrescu
>> <cristian.dumitrescu@intel.com>
>> Cc: dev@dpdk.org; Dekel Peled <dekelp@nvidia.com>
>> Subject: Re: [dpdk-dev] [PATCH 5/5] net/softnic: update headers size
>> calculation
>>
>> On 11/16/2020 7:55 AM, Xiaoyu Min wrote:
>>> From: Dekel Peled <dekelp@nvidia.com>
>>>
>>> The rte_flow_item_eth and rte_flow_item_vlan items were updated in
>> [1].
>>> The rte_flow_item_ipv6 item was updated in [2].
>>> The structs now contain additional metadata following the header data.
>>> The size to use for match should be the header data size only, and not
>>> the size of the whole struct.
>>>
>>> This patch replaces the rte_flow_item_* with the corresponding
>> rte_*_hdr.
>>>
>>> [1]:commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and
>>> VLAN
>>> items")
>>>
>>> [2]: commit ad976bd40d28 ("ethdev: add extensions attributes to IPv6
>>> item")
>>>
>>> Signed-off-by: Dekel Peled <dekelp@nvidia.com>
>>> ---
>>> drivers/net/softnic/rte_eth_softnic_flow.c | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/net/softnic/rte_eth_softnic_flow.c
>>> b/drivers/net/softnic/rte_eth_softnic_flow.c
>>> index f05ff092fa..7925bad1c0 100644
>>> --- a/drivers/net/softnic/rte_eth_softnic_flow.c
>>> +++ b/drivers/net/softnic/rte_eth_softnic_flow.c
>>> @@ -169,22 +169,22 @@ flow_item_is_proto(enum rte_flow_item_type
>> type,
>>>
>>> case RTE_FLOW_ITEM_TYPE_ETH:
>>> *mask = &rte_flow_item_eth_mask;
>>> - *size = sizeof(struct rte_flow_item_eth);
>>> + *size = sizeof(struct rte_ether_hdr);
>>> return 1; /* TRUE */
>>>
>>> case RTE_FLOW_ITEM_TYPE_VLAN:
>>> *mask = &rte_flow_item_vlan_mask;
>>> - *size = sizeof(struct rte_flow_item_vlan);
>>> + *size = sizeof(struct rte_vlan_hdr);
>>> return 1;
>>>
>>> case RTE_FLOW_ITEM_TYPE_IPV4:
>>> *mask = &rte_flow_item_ipv4_mask;
>>> - *size = sizeof(struct rte_flow_item_ipv4);
>>> + *size = sizeof(struct rte_ipv4_hdr);
>>> return 1;
>>>
>>> case RTE_FLOW_ITEM_TYPE_IPV6:
>>> *mask = &rte_flow_item_ipv6_mask;
>>> - *size = sizeof(struct rte_flow_item_ipv6);
>>> + *size = sizeof(struct rte_ipv6_hdr);
>>> return 1;
>>>
>>
>> As far as I can see the 'flow_item_is_proto' sets the size to be used over
>> 'rte_flow_item_*" types, the original values seems correct to me, am I
>> missing something.
>>
>> Can you please elaborate why the change is needed?
>
> Hi Ferruh,
>
> The failure occur at hash_key_mask_is_same() which uses the size returned by
flow_item_is_proto() for comparison.
> Since the rte_flow_item_* of some types is now different than the rte_*_hdr
size of these types, need to use the rte_*_hdr size.
>
Got it.
Using "rte_*_hdr" structs size will strip the new additions to the
"rte_flow_item_*" structs and won't able to use them.
But at least using old sizes should preserve old functionality and prevent any
unexpected side affect, so I am OK to continue with this change but code needs
to be updated later to benefit from latest "rte_flow_item_*" structs.
Cristian, Jasvinder,
Can you please acknowledge that you are aware of the reason of this change and
possible updates may be required later?
next prev parent reply other threads:[~2020-11-17 10:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 7:55 [dpdk-dev] [PATCH 0/5] fix protocol " Xiaoyu Min
2020-11-16 7:55 ` [dpdk-dev] [PATCH 1/5] net/mlx5: fix protocol size for raw encap judgement Xiaoyu Min
2020-11-17 13:25 ` Matan Azrad
2020-11-22 14:21 ` Thomas Monjalon
2020-11-22 15:32 ` Thomas Monjalon
2020-11-22 16:04 ` Matan Azrad
2020-11-23 7:54 ` Ori Kam
2020-11-23 8:12 ` Thomas Monjalon
2020-11-16 7:55 ` [dpdk-dev] [PATCH 2/5] app/flow-perf: fix protocol size for raw encap Xiaoyu Min
2020-11-16 7:55 ` [dpdk-dev] [PATCH 3/5] net/bnxt: fix protocol size for VXLAN encap copy Xiaoyu Min
2020-11-16 16:12 ` Ferruh Yigit
2020-11-18 0:34 ` Ajit Khaparde
2020-11-18 6:37 ` Andrew Rybchenko
2020-11-18 17:44 ` Ajit Khaparde
2020-11-16 7:55 ` [dpdk-dev] [PATCH 4/5] net/iavf: fix protocol size for virtchnl copy Xiaoyu Min
2020-11-16 16:23 ` Ferruh Yigit
2020-11-22 13:28 ` Jack Min
2020-11-22 14:15 ` Thomas Monjalon
2020-11-23 10:02 ` Ferruh Yigit
2020-11-23 10:49 ` Ferruh Yigit
2020-11-24 21:58 ` Thomas Monjalon
2020-11-27 1:17 ` Xing, Beilei
2020-11-16 7:55 ` [dpdk-dev] [PATCH 5/5] net/softnic: update headers size calculation Xiaoyu Min
2020-11-16 16:27 ` Ferruh Yigit
2020-11-16 19:09 ` Dekel Peled
2020-11-17 10:30 ` Ferruh Yigit [this message]
2020-11-17 12:41 ` Dekel Peled
2020-11-17 15:43 ` Singh, Jasvinder
2020-11-18 2:23 ` Zhou, JunX W
2020-11-22 16:11 ` [dpdk-dev] [PATCH 0/5] fix protocol " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e230fc1e-b1a9-f4ce-0076-d83d9f881425@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dekelp@nvidia.com \
--cc=dev@dpdk.org \
--cc=jackmin@mellanox.com \
--cc=jasvinder.singh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).