From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFDBFA0547; Thu, 26 Aug 2021 11:30:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA33B40140; Thu, 26 Aug 2021 11:30:51 +0200 (CEST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id 739754013F for ; Thu, 26 Aug 2021 11:30:50 +0200 (CEST) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4GwHdN0m0mz8BGd; Thu, 26 Aug 2021 17:30:32 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 26 Aug 2021 17:30:48 +0800 Received: from [10.40.190.165] (10.40.190.165) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 26 Aug 2021 17:30:47 +0800 To: Bruce Richardson CC: , , , , , , , , , , , , , , References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <1629689494-55091-1-git-send-email-fengchengwen@huawei.com> <1629689494-55091-8-git-send-email-fengchengwen@huawei.com> From: fengchengwen Message-ID: Date: Thu, 26 Aug 2021 17:30:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.190.165] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v16 7/9] dma/skeleton: add test cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The skeleton_dma mainly focus on dma framework ut, as it currently functions. Agree add more general testcase which run with diffenernt hardware drivers, these testcases mainly used to test drivers (not dma framework). In this way, the driver's selftest ops can be implemented very easily. On 2021/8/23 22:03, Bruce Richardson wrote: > On Mon, Aug 23, 2021 at 11:31:32AM +0800, Chengwen Feng wrote: >> Patch introduces dmadev unit testcase for validation against the >> skeleton dmadev PMD implementation. >> >> Test cases are added along with the skeleton driver implementation. >> It can be enabled by using vdev argument to any DPDK binary: >> >> --vdev="dma_skeleton,selftest=1" >> >> In case 'selftest=1' is not provided, autotest doesn't execute the >> test cases but the vdev is still available for application use. >> >> Signed-off-by: Chengwen Feng >> --- > > Having self-tests was useful for rawdev implementations as each rawdev was > (potentially) a completely different device type so no common set of tests > could really be written for them. However, for dmadev, we have a common set > of functions and APIs, so I think that the tests provided here should be in > a general test-case set. > > We are preparing to upstream a test suite for DMA devices, based off the > work we have in progress on our own drivers, and we'll look to include some > of the tests from here in that for consistency. Please wait for that set - > hopefully appearing the next day or two - before doing additional work on > this set, as our set includes quite a comprehensive set of functional tests > in it, which would go well with the API tests here. > > In terms of the skeleton dmadev itself, I'm not fully convinced of its > usefulness, but it does allow unit testing of the APIs in the absense of > dma device hardware. Whether that utility is worth the maintenance cost, > though, I'm not sure. > > Regards, > /Bruce > . >