From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F598A00C4; Tue, 26 Jul 2022 09:55:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E28D40DDD; Tue, 26 Jul 2022 09:55:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AF69140695 for ; Tue, 26 Jul 2022 09:55:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658822109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=louvLNtlR72kPqIyPcp9CQLBUjsgPUZQ3NIWCCYUeYE=; b=EBgtRvtCSNziRW3gLfJzexCvP1gFLnotrxY5RonBatpPU4DjDHITJRaWZiizlG47DI3Ok3 xEDS49bBF3Kz11HnRMy+3eIQuBYxLwA5+OmMLnYuyiqnw+MQSgT2s10LwsLxQAOOfBrpup HEwlfAmf254PhoUZ1laRrcH/+pINJgA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-15-QIMn5JLzOg61HPtFycMMQA-1; Tue, 26 Jul 2022 03:55:08 -0400 X-MC-Unique: QIMn5JLzOg61HPtFycMMQA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B39493C025D8; Tue, 26 Jul 2022 07:55:07 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ED1352026D64; Tue, 26 Jul 2022 07:55:06 +0000 (UTC) Message-ID: Date: Tue, 26 Jul 2022 09:55:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 1/4] vhost: fix vq use after free on NUMA reallocation To: David Marchand , dev@dpdk.org Cc: stable@dpdk.org, Chenbo Xia References: <20220722135320.109269-1-david.marchand@redhat.com> <20220725203206.427083-1-david.marchand@redhat.com> <20220725203206.427083-2-david.marchand@redhat.com> From: Maxime Coquelin In-Reply-To: <20220725203206.427083-2-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/25/22 22:32, David Marchand wrote: > translate_ring_addresses (via numa_realloc) may change a virtio device and > virtio queue. > The virtqueue object must be refreshed before accessing the lock. > > Fixes: 04c27cb673b9 ("vhost: fix unsafe vring addresses modifications") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > lib/vhost/vhost_user.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c > index 4ad28bac45..91d40e32fc 100644 > --- a/lib/vhost/vhost_user.c > +++ b/lib/vhost/vhost_user.c > @@ -2596,6 +2596,7 @@ vhost_user_iotlb_msg(struct virtio_net **pdev, > if (is_vring_iotlb(dev, vq, imsg)) { > rte_spinlock_lock(&vq->access_lock); > *pdev = dev = translate_ring_addresses(dev, i); > + vq = dev->virtqueue[i]; > rte_spinlock_unlock(&vq->access_lock); > } > } Reviewed-by: Maxime Coquelin Thanks, Maxime