From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 0FCC3330D for ; Tue, 5 Sep 2017 14:56:57 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id u26so18957729wma.0 for ; Tue, 05 Sep 2017 05:56:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8Vu1jdEtKPGbmsoJi5GHU1jfo6OJ3TTtfHIZOn/C+zg=; b=S0aHlPC1q8CYBXaZX67sGRsDMBu5AcmrTd2Zjzo7XfbBqxuqmc62jzJfJcsRcc97yX 9bsv/fafv22B0OiGfCQvOK7WayXZnWS1PH8rdtFtw3HAAs3BdVXsq9I6f/JPYeCNlqTK MOdMHkrk/6sBALORYd5X8tquNeha8Eev0/sBK8dPc0lEZ3L31i1PFqFSahKNhrODhXxm mrPgfvOFRUZDDfoOzXZXlhQQPU9vW6XTthsKEhNL1yMMG7Kd4mc5gTd2ocMgvfuviywr 7ApQJ4/72z6UHWd33IuQpns4v5YfZ9fplMkRhBMcz34z6cNZX1TUOuSzs9H8t84Bxx5c nl9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8Vu1jdEtKPGbmsoJi5GHU1jfo6OJ3TTtfHIZOn/C+zg=; b=MOsORWCPmh/w1rMUqbvHH44Hb73DF8IDdyBH6ELt1nMu5O4dm7bhYFfHxLnrARaJRa oorfy8+/s1n3mSP7S9qRG5mgFwDV4+h3En0NZ9V4HGer5T0STckQhoctS5oYfleY7YQ6 Xf4uymNwFvZOlOBD3biblyBxWvx47/CpUzu7CWZiFpv9kJhbs6avTYP5T3G3Lfi4w4Za QEMsEDd9iEBso2QN2+Xm3+kSzh0FPucNPPcD1Ix+vYmVVLRZla1g36Zsq4HrgnGOlo1c t8vXEzF5Hc51KmaL8IfPBpvdrU+pjlth0N88NDqabyqv4147gVRnhnMuFzHe+z35LUXH YTvQ== X-Gm-Message-State: AHPjjUh9Zh+40ho2wyOpGZujC10piiewCfMB8Fi3MU/ap4eComAe3JP1 EwxsWole4xMvZnPK X-Google-Smtp-Source: ADKCNb66nMM7Zc9Di7n29YBHuV4zSWqJiz1bl9/fJdcD17PysJEO2S/lQiSMzLDc8EzDicdvQSuyfw== X-Received: by 10.28.229.6 with SMTP id c6mr2029531wmh.170.1504616216719; Tue, 05 Sep 2017 05:56:56 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 4sm559770wmg.20.2017.09.05.05.56.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Sep 2017 05:56:55 -0700 (PDT) From: Adrien Mazarguil To: Gaetan Rivet , Matan Azrad Cc: dev@dpdk.org, stable@dpdk.org Date: Tue, 5 Sep 2017 14:56:37 +0200 Message-Id: X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v1 1/3] net/mlx4: fix unhandled event debug message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2017 12:56:57 -0000 When LSC or RMV events are received by the PMD but are not requested by the application, a misleading debugging message implying the PMD does not support them is shown. Fixes: 6dd7b7056d7f ("net/mlx4: support device removal event") Cc: Gaetan Rivet Cc: stable@dpdk.org Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_intr.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx4/mlx4_intr.c b/drivers/net/mlx4/mlx4_intr.c index e3449ee..d7f1098 100644 --- a/drivers/net/mlx4/mlx4_intr.c +++ b/drivers/net/mlx4/mlx4_intr.c @@ -160,16 +160,21 @@ mlx4_collect_interrupt_events(struct priv *priv, uint32_t *events) for (;;) { if (ibv_get_async_event(priv->ctx, &event)) break; - if ((event.event_type == IBV_EVENT_PORT_ACTIVE || - event.event_type == IBV_EVENT_PORT_ERR) && - intr_conf->lsc) { + switch (event.event_type) { + case IBV_EVENT_PORT_ACTIVE: + case IBV_EVENT_PORT_ERR: + if (!intr_conf->lsc) + break; port_change = 1; ret++; - } else if (event.event_type == IBV_EVENT_DEVICE_FATAL && - intr_conf->rmv) { + break; + case IBV_EVENT_DEVICE_FATAL: + if (!intr_conf->rmv) + break; *events |= (1 << RTE_ETH_EVENT_INTR_RMV); ret++; - } else { + break; + default: DEBUG("event type %d on port %d not handled", event.event_type, event.element.port_num); } -- 2.1.4