From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74BEEA09EF; Wed, 16 Dec 2020 14:37:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 535EDC9A0; Wed, 16 Dec 2020 14:37:36 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 655C0C996 for ; Wed, 16 Dec 2020 14:37:35 +0100 (CET) IronPort-SDR: OBQAFbFuTV8nLDEkBZBh6unkr9b1gO32qKocJG6E5E+c22XAGKfOUWCf7jxTJz4GEIRJsASmNo Zaoeq6hF4aUg== X-IronPort-AV: E=McAfee;i="6000,8403,9836"; a="193446253" X-IronPort-AV: E=Sophos;i="5.78,424,1599548400"; d="scan'208";a="193446253" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2020 05:37:33 -0800 IronPort-SDR: wUM/2bDZAshkYd5UYxelZ6hlcgiXoupLutQOPoHuTfy5/F56pTwZ7MrZa2iTiW9T27eMKNrY1a HHrVJqC7c+LQ== X-IronPort-AV: E=Sophos;i="5.78,424,1599548400"; d="scan'208";a="369078474" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.233.132]) ([10.213.233.132]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2020 05:37:31 -0800 To: lironh@marvell.com Cc: dev@dpdk.org, Luca Boccassi , Kevin Traynor , Akhil Goyal References: <20201202130529.7332-2-lironh@marvell.com> <20201215222319.13816-1-lironh@marvell.com> From: Ferruh Yigit Message-ID: Date: Wed, 16 Dec 2020 13:37:28 +0000 MIME-Version: 1.0 In-Reply-To: <20201215222319.13816-1-lironh@marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] meson: update meson build for armada drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/15/2020 10:23 PM, lironh@marvell.com wrote: > From: Liron Himi > > With pkg-config support available within musdk library > (from musdk-release-SDK-10.3.5.0-PR2 version), > meson option 'lib_musdk_dir' can be removed. > PKG_CONFIG_PATH environment variable should be set appropriately > to use the musdk library. Hi Liron, It is good change to get rid of an custom meson option, can we or should we backport this to the v20.11? > > docs are updated with new musdk version and meson instructions. > > Signed-off-by: Liron Himi > Reviewed-by: Liron Himi > --- > v2: > * include updated docs in this patch > * add musdk version in commit message > --- > doc/guides/nics/mvneta.rst | 13 ++++++++----- > doc/guides/nics/mvpp2.rst | 15 +++++++++------ > drivers/common/mvep/meson.build | 14 +++++--------- > drivers/crypto/mvsam/meson.build | 15 +++++---------- @Ahil, is it OK if I get this to the next-net, since logically related? > drivers/net/mvneta/meson.build | 19 +++++-------------- > drivers/net/mvneta/mvneta_ethdev.h | 1 + > drivers/net/mvpp2/meson.build | 15 +++++---------- > meson_options.txt | 2 -- > 8 files changed, 38 insertions(+), 56 deletions(-) > <...> > @@ -94,7 +94,7 @@ be passed as part of EAL arguments. > -c 3 -- -i --p 3 -a > > > -Building DPDK > +Building MUSDK > ------------- > This is giving doc warning because of "Title underline too short". <...> > @@ -108,7 +108,7 @@ Prerequisites > DPDK environment. > > > -Building DPDK > +Building MUSDK > ------------- > Ditto. <...> > diff --git a/drivers/net/mvneta/mvneta_ethdev.h b/drivers/net/mvneta/mvneta_ethdev.h > index ef8067790..e090abc25 100644 > --- a/drivers/net/mvneta/mvneta_ethdev.h > +++ b/drivers/net/mvneta/mvneta_ethdev.h > @@ -21,6 +21,7 @@ > #undef container_of > #endif > > +#include Is this include related with this patch?