From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 001994C96 for ; Fri, 9 Nov 2018 15:31:12 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5CE21C0495B1; Fri, 9 Nov 2018 14:31:12 +0000 (UTC) Received: from [10.36.112.39] (ovpn-112-39.ams2.redhat.com [10.36.112.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AE04E672CA; Fri, 9 Nov 2018 14:31:11 +0000 (UTC) To: Fan Zhang , dev@dpdk.org References: <20181024131826.6842-1-roy.fan.zhang@intel.com> <20181106162248.5172-1-roy.fan.zhang@intel.com> From: Maxime Coquelin Message-ID: Date: Fri, 9 Nov 2018 15:31:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181106162248.5172-1-roy.fan.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 09 Nov 2018 14:31:12 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2] vhost/crypto: fix incorrect copy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 14:31:13 -0000 On 11/6/18 5:22 PM, Fan Zhang wrote: > This patch fixes the incorrect packet content copy in the > chaining mode. Originally the content before cipher offset is > overwritten by all zeros. This patch fixes the problem by > making sure the correct write back source and destination > settings during set up. > > Signed-off-by: Fan Zhang > --- > v2: > - fixed a write back size error bug. > > lib/librte_vhost/vhost_crypto.c | 460 ++++++++++++++++++++++++++++++---------- > 1 file changed, 348 insertions(+), 112 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime