From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 1A8EB2C2B for ; Wed, 1 Mar 2017 13:50:14 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id u199so35495977wmd.1 for ; Wed, 01 Mar 2017 04:50:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=KOPJpRndqIKPtaPiy4bMOy3+kLhish44XBpgEMOQ8HE=; b=A+IITSbx+rURk6ZWVKesZoE1msh8e6zXllKoXMjr7668g7jxMiRuJ7wujMkVnq75Y2 qb4cfurqDbU/z5ndo2k3Kbit866UmDW4c68xsmjLIRZ6Kv7BD6kmWLVMvDFlvcwRs6iX ziHpltKDYZbbQpL1/Sfx21bK7GYFy4Vuf0ywdHDNzhZ3qNmd6GpdUfvdNAY+XBAx8kXK XdcCXFWCj4MHAUj/ELYPaqx1+SXMJX5R0aHZgSBB6S5O6cIyZUZx2LIOom7Hq1Lnna/h YwNlE3ZZnSVdSdsZLfk3kjBsTPnv+Qe5TOulUSy+z/gJVrIxjne6pGZ6p5thvq4GtkRo 9XSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=KOPJpRndqIKPtaPiy4bMOy3+kLhish44XBpgEMOQ8HE=; b=rJxIuhiLn+g/D3BWqaYA9ATqInl6PnI1U70HZpPcXc80h6l0HKbBASg2o/stNUZzFY 2RYMtPZ4lF/o809ftUKG7248Js3oWn9hwgNzO4E49m9Z8LPd4NUpPFvMrn4bmH9YNPPX GFdlrM9dDiyu8I54TWAwjn9/p7wOcriZ9kxlhzFVvIczmaACz7Vq/eCpXIO0GX0LsNUv lO7A63Z9El6XNUsnT5i8tCY6yeHbA5e5LwwSHm/DNuJai6y8Foa9vssZwvvQWm5bCMt2 yfAB4ZPqvEN6gfJXwiHxLPFwVsnS+7ZvQiccCo/qwOMcz6ezoddac2kNKfFdRb/YSkzL jVhg== X-Gm-Message-State: AMke39n5eQzkcE7UbV1PVwJ1abajYi3vW6yuSrtEaWX5ISH3iLRU+WcQA9TzurFBxWw9IkDA X-Received: by 10.28.206.15 with SMTP id e15mr3345410wmg.43.1488372614603; Wed, 01 Mar 2017 04:50:14 -0800 (PST) Received: from ping.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l45sm6502268wrc.14.2017.03.01.04.50.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 01 Mar 2017 04:50:14 -0800 (PST) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Adrien Mazarguil , stable@dpdk.org Date: Wed, 1 Mar 2017 13:49:41 +0100 Message-Id: X-Mailer: git-send-email 2.1.4 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v2 2/9] net/mlx5: fix resources free in the right function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 12:50:15 -0000 ibv_attr should be freed in the function which allocates the memory. Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions") CC: stable@dpdk.org Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 6765a77..0712926 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -974,7 +974,6 @@ priv_flow_create_action_queue(struct priv *priv, ibv_exp_destroy_wq(rte_flow->wq); if (!rte_flow->rxq && rte_flow->cq) ibv_destroy_cq(rte_flow->cq); - rte_free(rte_flow->ibv_attr); rte_free(rte_flow); return NULL; } @@ -1068,6 +1067,8 @@ priv_flow_create(struct priv *priv, } rte_flow = priv_flow_create_action_queue(priv, flow.ibv_attr, &action, error); + if (!rte_flow) + goto exit; return rte_flow; exit: rte_free(flow.ibv_attr); -- 2.1.4