DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/i40evf: fix packet loss issue for X722
@ 2021-02-24  2:09 beilei.xing
  2021-02-24  2:34 ` Guo, Jia
  0 siblings, 1 reply; 3+ messages in thread
From: beilei.xing @ 2021-02-24  2:09 UTC (permalink / raw)
  To: jia.guo; +Cc: dev, Beilei Xing, stable, Hengjian Zhang

From: Beilei Xing <beilei.xing@intel.com>

When Tx queue number is more than Rx queue number, and RSS is
enabled, there'll be packet loss with X722.
The root cause is the lookup table is not configured correctly,
since it uses VF's queue pair number but not Rx queue number.

Fixes: 2da3ba746795 ("net/i40e: fix VF runtime queues RSS config")
Cc: stable@dpdk.org

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Signed-off-by: Hengjian Zhang <hengjianx.zhang@intel.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 2909b4d894..0c9bd8d2c6 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2746,7 +2746,7 @@ i40evf_config_rss(struct i40e_vf *vf)
 		}
 
 		for (i = 0; i < rss_lut_size; i++)
-			lut_info[i] = i % vf->num_queue_pairs;
+			lut_info[i] = i % num;
 
 		ret = i40evf_set_rss_lut(&vf->vsi, lut_info,
 					 rss_lut_size);
-- 
2.26.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/i40evf: fix packet loss issue for X722
  2021-02-24  2:09 [dpdk-dev] [PATCH] net/i40evf: fix packet loss issue for X722 beilei.xing
@ 2021-02-24  2:34 ` Guo, Jia
  2021-03-05  8:49   ` Zhang, Qi Z
  0 siblings, 1 reply; 3+ messages in thread
From: Guo, Jia @ 2021-02-24  2:34 UTC (permalink / raw)
  To: Xing, Beilei; +Cc: dev, stable, Zhang, HengjianX

Acked-by: Jeff Guo <jia.guo@intel.com>

> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Wednesday, February 24, 2021 10:09 AM
> To: Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; stable@dpdk.org;
> Zhang, HengjianX <hengjianx.zhang@intel.com>
> Subject: [PATCH] net/i40evf: fix packet loss issue for X722
> 
> From: Beilei Xing <beilei.xing@intel.com>
> 
> When Tx queue number is more than Rx queue number, and RSS is enabled,
> there'll be packet loss with X722.
> The root cause is the lookup table is not configured correctly, since it uses
> VF's queue pair number but not Rx queue number.
> 
> Fixes: 2da3ba746795 ("net/i40e: fix VF runtime queues RSS config")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> Signed-off-by: Hengjian Zhang <hengjianx.zhang@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index 2909b4d894..0c9bd8d2c6 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -2746,7 +2746,7 @@ i40evf_config_rss(struct i40e_vf *vf)
>  		}
> 
>  		for (i = 0; i < rss_lut_size; i++)
> -			lut_info[i] = i % vf->num_queue_pairs;
> +			lut_info[i] = i % num;
> 
>  		ret = i40evf_set_rss_lut(&vf->vsi, lut_info,
>  					 rss_lut_size);
> --
> 2.26.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/i40evf: fix packet loss issue for X722
  2021-02-24  2:34 ` Guo, Jia
@ 2021-03-05  8:49   ` Zhang, Qi Z
  0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2021-03-05  8:49 UTC (permalink / raw)
  To: Guo, Jia, Xing, Beilei; +Cc: dev, stable, Zhang, HengjianX



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Guo, Jia
> Sent: Wednesday, February 24, 2021 10:35 AM
> To: Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Zhang, HengjianX
> <hengjianx.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/i40evf: fix packet loss issue for X722
> 
> Acked-by: Jeff Guo <jia.guo@intel.com>
> 
> > -----Original Message-----
> > From: Xing, Beilei <beilei.xing@intel.com>
> > Sent: Wednesday, February 24, 2021 10:09 AM
> > To: Guo, Jia <jia.guo@intel.com>
> > Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>;
> > stable@dpdk.org; Zhang, HengjianX <hengjianx.zhang@intel.com>
> > Subject: [PATCH] net/i40evf: fix packet loss issue for X722
> >
> > From: Beilei Xing <beilei.xing@intel.com>
> >
> > When Tx queue number is more than Rx queue number, and RSS is enabled,
> > there'll be packet loss with X722.
> > The root cause is the lookup table is not configured correctly, since
> > it uses VF's queue pair number but not Rx queue number.
> >
> > Fixes: 2da3ba746795 ("net/i40e: fix VF runtime queues RSS config")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> > Signed-off-by: Hengjian Zhang <hengjianx.zhang@intel.com>
> > ---

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-05  8:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-24  2:09 [dpdk-dev] [PATCH] net/i40evf: fix packet loss issue for X722 beilei.xing
2021-02-24  2:34 ` Guo, Jia
2021-03-05  8:49   ` Zhang, Qi Z

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git