From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EDF22A00C3; Sun, 27 Feb 2022 07:20:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B08194068A; Sun, 27 Feb 2022 07:20:04 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 3F07A40683; Sun, 27 Feb 2022 07:20:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645942803; x=1677478803; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gtDmPIPxMmXGFUCLXkvYynOeM/6i0cUSTEAbURUbNWI=; b=Qs4SHBQUdsNgmnaT/DosuXY6DB9FaClLs77dORLk6gv2vL26umh8P1Nz ZUKz9kUH5qW6zKUOSCyPvxTz1yELc9vWrCl/O6WDoB0E3CloG3FYmxDZW yrrwTaQigM2jKZ4+Lpagd6vJqdI+NWkfGsjqD14t1xnQ+GMJOea4jfieQ Ep94KRBBOXAVpGzxInQn07Ig9JBZdCMwogYanKttvrNMbo6PoNINs4dXv Sb7d9/k16TLJcsnHIz12E6c0HIF/ZJCriwZoxPpNy37JD5pOBbxfgQRXj 4ObYiMehMzHhHXT5ueO7tFUXVBKu3518KUx2zQM9c1RhNK7NhJB+YNeAK g==; X-IronPort-AV: E=McAfee;i="6200,9189,10270"; a="233330513" X-IronPort-AV: E=Sophos;i="5.90,140,1643702400"; d="scan'208";a="233330513" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2022 22:20:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,140,1643702400"; d="scan'208";a="492373261" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga003.jf.intel.com with ESMTP; 26 Feb 2022 22:20:01 -0800 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sat, 26 Feb 2022 22:20:01 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 27 Feb 2022 14:19:59 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2308.020; Sun, 27 Feb 2022 14:19:59 +0800 From: "Zhang, Qi Z" To: "Liu, KevinX" , "dev@dpdk.org" CC: "Yang, SteveX" , "stable@dpdk.org" Subject: RE: [PATCH] net/ice: fix Tx offload path choice Thread-Topic: [PATCH] net/ice: fix Tx offload path choice Thread-Index: AQHYKJOj0UaxrD9TC0SDom5GSA96wKym8oUQ Date: Sun, 27 Feb 2022 06:19:58 +0000 Message-ID: References: <20211224150925.3296471-1-kevinx.liu@intel.com> In-Reply-To: <20211224150925.3296471-1-kevinx.liu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Liu, KevinX > Sent: Friday, December 24, 2021 11:09 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, SteveX ; > Liu, KevinX ; stable@dpdk.org > Subject: [PATCH] net/ice: fix Tx offload path choice >=20 > Testpmd forwards packets in checksum mode that it needs to calculate the > checksum of each layer's protocol. >=20 > When setting the hardware calculates the outer UDP checksum and the > software calculates the outer IP checksum, the dev->tx_pkt_burst in > ice_set_tx_function is set to ice_xmit_pkts_vec_avx2. > The inner and outer UDP checksum of the tunnel packet after forwarding is > wrong.The dev->tx_pkt_burst should be set to ice_xmit_pkts. >=20 > The patch adds RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM to > ICE_TX_NO_VECTOR_FLAGS,set dev->tx_pkt_burst to ice_xmit_pkts.After the > tunnel packet is forwarded, the inner and outer UDP checksum is correct. >=20 > At the same time, the patch of "net/ice: fix Tx Checksum offload" will ca= use > interrupt errors in a special case that only inner IP and inner UDP check= sum are > set for hardware calculation.The patch is updating ICE_TX_NO_VECTOR_FLAGS= , > the problem can be solved, so I will restore the code modification of tha= t patch. >=20 > Fixes: e6b9d6411e91 ("app/testpmd: add SW L4 checksum in multi-segments") > Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path") > Fixes: 295968d17407 ("ethdev: add namespace") > Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") > Cc: stable@dpdk.org >=20 > Signed-off-by: Kevin Liu > --- > app/test-pmd/csumonly.c | 6 +-- > drivers/net/ice/ice_rxtx.c | 41 ++++++------------- > drivers/net/ice/ice_rxtx_vec_common.h | 59 +++++++++------------------ > 3 files changed, 34 insertions(+), 72 deletions(-) Please separate testpmd fix and pmd fix into two patches.=20