From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 44B975B38 for ; Tue, 9 Apr 2019 22:31:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 13:31:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,330,1549958400"; d="scan'208";a="132866852" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.46]) ([10.237.221.46]) by orsmga008.jf.intel.com with ESMTP; 09 Apr 2019 13:31:00 -0700 To: Igor Ryzhov Cc: dev@dpdk.org, Stephen Hemminger References: <20180927000224.4011-1-iryzhov@nfware.com> <0a5223b8-5b32-966a-7339-617957c7ba45@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: Date: Tue, 9 Apr 2019 21:30:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] kni: implement header_ops parse method X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 20:31:04 -0000 On 4/8/2019 5:59 PM, Igor Ryzhov wrote: > Hi Ferruh, > > Can we proceed with this patch? > > Igor > > On Thu, Jan 24, 2019 at 9:05 PM Igor Ryzhov > wrote: > > Hi Ferruh, > > Ok, no problem. Generally, it is needed for all applications using packet(7) > interface, running over KNI interfaces. > More specifically, one example of such application is FRRouting, I suppose > you are familiar with it. > FRR's ISIS daemon is using AF_PACKET sockets and checking received sockaddr_ll. > Here is the link on one of the usages > – https://github.com/FRRouting/frr/blob/master/isisd/isis_pfpacket.c#L294 > > When we are good with motivation, I'll send v2 using eth_header_parse. Hi Igor, Sorry for the delay, thanks for the clarification on patch. Can you please send v2 with 'eth_header_parse'? And please include above information in commit log. Thanks, ferruh > > Best regards, > Igor > > On Thu, Jan 24, 2019 at 8:15 PM Ferruh Yigit > wrote: > > On 1/24/2019 4:35 PM, Igor Ryzhov wrote: > > Hi Ferruh, > > > > I already answered your question in my previous email, > header_ops.parse method > > is used by packet(7) interface for packet parsing and filling > sockaddr_ll structure. > > Here is the link on the usage – > > > https://elixir.bootlin.com/linux/latest/source/net/packet/af_packet.c#L2100 > > I saw your previous reply. That is why changed the question slightly, > from 'what > it does' to 'what is the use case'. > Trying to understand do we need it, please help me understand. > > > > > Regarding the question about eth_header_ops usage: > > Right now both already existing functions, kni_net_header and > > kni_net_rebuild_header, are implemented as copies, not using > eth_header_ops > > functions. > > OK, I see your reasoning, but if there is an already Linux API that does > what we > want, I suggest calling it instead of re-implementing it, unless there > is a good > reason to not do so. > > > That's why I think my patch should be accepted as is, and the problem of > > eth_header_ops usage should be investigated separately, and possibly > resolved by > > a separate patch. > > Agreed, eth_header_ops usage should be investigated separately. > > > > > Best regards, > > Igor > > > > On Thu, Jan 24, 2019 at 5:10 PM Ferruh Yigit > > >> wrote: > > > >     On 1/24/2019 9:18 AM, Igor Ryzhov wrote: > >     > Hi Ferruh, > >     > > >     > What about this patch? > >     > Can you merge it as-is, or should I change it to use relevant > eth_header_ops > >     > functions? Or maybe completely use eth_header_ops? > > > >     Hi Igor, > > > >     I am not clear about motivation of the patch, what use case > enabled by this > >     patch? What is not working with current code? > >     I am for rejecting the patch without need justified. > > > >     And if the need is justified, still there is a question that why > not use > >     'eth_header_parse()' directly but implement our copy? > > > > > >     And an extended question/investigation about why not use > 'eth_header_ops', which > >     seems done intentionally but I am missing the reasoning. > > > >     > > >     > Best regards, > >     > Igor > >     > > >     > On Fri, Nov 30, 2018 at 10:07 PM Igor Ryzhov > >     > > >     > > >>> wrote: > >     > > >     >     Hi Ferruh, > >     > > >     >     header_ops.parse method is used by raw-sockets to > fill sockaddr_ll > >     structure. > >     >     It is used, for example, in isisd for frrouting. > >     > > >     >     Regarding your question about eth_header_ops – I, > unfortunately, don't > >     know > >     >     why .cache and .cache_update are disabled for KNI. > >     >     I also think that it will be better to use default > eth_header_ops. > >     > > >     >     Best regards, > >     >     Igor > >     > > >     >     On Tue, Oct 2, 2018 at 7:58 PM Ferruh Yigit > > >     > > >     >      >>> wrote: > >     > > >     >         On 9/27/2018 1:02 AM, Igor Ryzhov wrote: > >     >         > Signed-off-by: Igor Ryzhov > >     > > >     >          > >>> > >     > > >     >         Hi Igor, > >     > > >     >         What is the motivation to add this support? What is > enabled by this? > >     > > >     > > >     >         Meanwhile, why we are not using eth_header_ops, which is > already > >     set by > >     >         ether_setup(). > >     >         To disable .cache & .cache_update? > >     > > >     >         If so why not using relevant eth_header_ops (eth_header, > >     >         eth_header_parse ..) > >     >         instead of implementing ours? > >     > > >     >         > --- > >     >         >  kernel/linux/kni/kni_net.c | 14 ++++++++++++++ > >     >         >  1 file changed, 14 insertions(+) > >     >         > > >     >         > diff --git a/kernel/linux/kni/kni_net.c > b/kernel/linux/kni/kni_net.c > >     >         > index 7fcfa106c..128a5477c 100644 > >     >         > --- a/kernel/linux/kni/kni_net.c > >     >         > +++ b/kernel/linux/kni/kni_net.c > >     >         > @@ -678,6 +678,19 @@ kni_net_header(struct sk_buff > *skb, struct > >     >         net_device *dev, > >     >         >       return dev->hard_header_len; > >     >         >  } > >     >         >  > >     >         > +/* > >     >         > + *  Extract hardware address from packet > >     >         > + */ > >     >         > +static int > >     >         > +kni_net_header_parse(const struct sk_buff *skb, > unsigned char > >     *haddr) > >     >         > +{ > >     >         > +     const struct ethhdr *eth = eth_hdr(skb); > >     >         > + > >     >         > +     memcpy(haddr, eth->h_source, ETH_ALEN); > >     >         > + > >     >         > +     return ETH_ALEN; > >     >         > +} > >     >         > + > >     >         >  /* > >     >         >   * Re-fill the eth header > >     >         >   */ > >     >         > @@ -739,6 +752,7 @@ kni_net_change_carrier(struct > net_device *dev, > >     >         bool new_carrier) > >     >         >  > >     >         >  static const struct header_ops kni_net_header_ops = { > >     >         >       .create  = kni_net_header, > >     >         > +     .parse   = kni_net_header_parse, > >     >         >  #ifdef HAVE_REBUILD_HEADER > >     >         >       .rebuild = kni_net_rebuild_header, > >     >         >  #endif /* < 4.1.0  */ > >     >         > > >     > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 52430A0096 for ; Tue, 9 Apr 2019 22:31:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 029EF5F13; Tue, 9 Apr 2019 22:31:05 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 44B975B38 for ; Tue, 9 Apr 2019 22:31:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 13:31:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,330,1549958400"; d="scan'208";a="132866852" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.46]) ([10.237.221.46]) by orsmga008.jf.intel.com with ESMTP; 09 Apr 2019 13:31:00 -0700 To: Igor Ryzhov Cc: dev@dpdk.org, Stephen Hemminger References: <20180927000224.4011-1-iryzhov@nfware.com> <0a5223b8-5b32-966a-7339-617957c7ba45@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: Date: Tue, 9 Apr 2019 21:30:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] kni: implement header_ops parse method X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409203058.fJyUj2ZgSSnftAPMo1y4VqbFhJ7xgn-dLX_8xMEylxw@z> On 4/8/2019 5:59 PM, Igor Ryzhov wrote: > Hi Ferruh, > > Can we proceed with this patch? > > Igor > > On Thu, Jan 24, 2019 at 9:05 PM Igor Ryzhov > wrote: > > Hi Ferruh, > > Ok, no problem. Generally, it is needed for all applications using packet(7) > interface, running over KNI interfaces. > More specifically, one example of such application is FRRouting, I suppose > you are familiar with it. > FRR's ISIS daemon is using AF_PACKET sockets and checking received sockaddr_ll. > Here is the link on one of the usages > – https://github.com/FRRouting/frr/blob/master/isisd/isis_pfpacket.c#L294 > > When we are good with motivation, I'll send v2 using eth_header_parse. Hi Igor, Sorry for the delay, thanks for the clarification on patch. Can you please send v2 with 'eth_header_parse'? And please include above information in commit log. Thanks, ferruh > > Best regards, > Igor > > On Thu, Jan 24, 2019 at 8:15 PM Ferruh Yigit > wrote: > > On 1/24/2019 4:35 PM, Igor Ryzhov wrote: > > Hi Ferruh, > > > > I already answered your question in my previous email, > header_ops.parse method > > is used by packet(7) interface for packet parsing and filling > sockaddr_ll structure. > > Here is the link on the usage – > > > https://elixir.bootlin.com/linux/latest/source/net/packet/af_packet.c#L2100 > > I saw your previous reply. That is why changed the question slightly, > from 'what > it does' to 'what is the use case'. > Trying to understand do we need it, please help me understand. > > > > > Regarding the question about eth_header_ops usage: > > Right now both already existing functions, kni_net_header and > > kni_net_rebuild_header, are implemented as copies, not using > eth_header_ops > > functions. > > OK, I see your reasoning, but if there is an already Linux API that does > what we > want, I suggest calling it instead of re-implementing it, unless there > is a good > reason to not do so. > > > That's why I think my patch should be accepted as is, and the problem of > > eth_header_ops usage should be investigated separately, and possibly > resolved by > > a separate patch. > > Agreed, eth_header_ops usage should be investigated separately. > > > > > Best regards, > > Igor > > > > On Thu, Jan 24, 2019 at 5:10 PM Ferruh Yigit > > >> wrote: > > > >     On 1/24/2019 9:18 AM, Igor Ryzhov wrote: > >     > Hi Ferruh, > >     > > >     > What about this patch? > >     > Can you merge it as-is, or should I change it to use relevant > eth_header_ops > >     > functions? Or maybe completely use eth_header_ops? > > > >     Hi Igor, > > > >     I am not clear about motivation of the patch, what use case > enabled by this > >     patch? What is not working with current code? > >     I am for rejecting the patch without need justified. > > > >     And if the need is justified, still there is a question that why > not use > >     'eth_header_parse()' directly but implement our copy? > > > > > >     And an extended question/investigation about why not use > 'eth_header_ops', which > >     seems done intentionally but I am missing the reasoning. > > > >     > > >     > Best regards, > >     > Igor > >     > > >     > On Fri, Nov 30, 2018 at 10:07 PM Igor Ryzhov > >     > > >     > > >>> wrote: > >     > > >     >     Hi Ferruh, > >     > > >     >     header_ops.parse method is used by raw-sockets to > fill sockaddr_ll > >     structure. > >     >     It is used, for example, in isisd for frrouting. > >     > > >     >     Regarding your question about eth_header_ops – I, > unfortunately, don't > >     know > >     >     why .cache and .cache_update are disabled for KNI. > >     >     I also think that it will be better to use default > eth_header_ops. > >     > > >     >     Best regards, > >     >     Igor > >     > > >     >     On Tue, Oct 2, 2018 at 7:58 PM Ferruh Yigit > > >     > > >     >      >>> wrote: > >     > > >     >         On 9/27/2018 1:02 AM, Igor Ryzhov wrote: > >     >         > Signed-off-by: Igor Ryzhov > >     > > >     >          > >>> > >     > > >     >         Hi Igor, > >     > > >     >         What is the motivation to add this support? What is > enabled by this? > >     > > >     > > >     >         Meanwhile, why we are not using eth_header_ops, which is > already > >     set by > >     >         ether_setup(). > >     >         To disable .cache & .cache_update? > >     > > >     >         If so why not using relevant eth_header_ops (eth_header, > >     >         eth_header_parse ..) > >     >         instead of implementing ours? > >     > > >     >         > --- > >     >         >  kernel/linux/kni/kni_net.c | 14 ++++++++++++++ > >     >         >  1 file changed, 14 insertions(+) > >     >         > > >     >         > diff --git a/kernel/linux/kni/kni_net.c > b/kernel/linux/kni/kni_net.c > >     >         > index 7fcfa106c..128a5477c 100644 > >     >         > --- a/kernel/linux/kni/kni_net.c > >     >         > +++ b/kernel/linux/kni/kni_net.c > >     >         > @@ -678,6 +678,19 @@ kni_net_header(struct sk_buff > *skb, struct > >     >         net_device *dev, > >     >         >       return dev->hard_header_len; > >     >         >  } > >     >         >  > >     >         > +/* > >     >         > + *  Extract hardware address from packet > >     >         > + */ > >     >         > +static int > >     >         > +kni_net_header_parse(const struct sk_buff *skb, > unsigned char > >     *haddr) > >     >         > +{ > >     >         > +     const struct ethhdr *eth = eth_hdr(skb); > >     >         > + > >     >         > +     memcpy(haddr, eth->h_source, ETH_ALEN); > >     >         > + > >     >         > +     return ETH_ALEN; > >     >         > +} > >     >         > + > >     >         >  /* > >     >         >   * Re-fill the eth header > >     >         >   */ > >     >         > @@ -739,6 +752,7 @@ kni_net_change_carrier(struct > net_device *dev, > >     >         bool new_carrier) > >     >         >  > >     >         >  static const struct header_ops kni_net_header_ops = { > >     >         >       .create  = kni_net_header, > >     >         > +     .parse   = kni_net_header_parse, > >     >         >  #ifdef HAVE_REBUILD_HEADER > >     >         >       .rebuild = kni_net_rebuild_header, > >     >         >  #endif /* < 4.1.0  */ > >     >         > > >     > > > >