From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B500A2F6B for ; Tue, 8 Oct 2019 14:53:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 538A61D41D; Tue, 8 Oct 2019 14:53:15 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 76F5C1D176; Tue, 8 Oct 2019 14:53:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2019 05:53:12 -0700 X-IronPort-AV: E=Sophos;i="5.67,270,1566889200"; d="scan'208";a="199797507" Received: from dhunt5-mobl4.ger.corp.intel.com (HELO [10.237.221.107]) ([10.237.221.107]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/AES256-SHA; 08 Oct 2019 05:53:11 -0700 To: Ruifeng Wang Cc: dev@dpdk.org, hkalra@marvell.com, gavin.hu@arm.com, honnappa.nagarahalli@arm.com, nd@arm.com, stable@dpdk.org References: <20191008095524.1585-1-ruifeng.wang@arm.com> From: "Hunt, David" Message-ID: Date: Tue, 8 Oct 2019 13:53:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20191008095524.1585-1-ruifeng.wang@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] lib/distributor: fix deadlock issue for aarch64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08/10/2019 10:55, Ruifeng Wang wrote: > Distributor and worker threads rely on data structs in cache line > for synchronization. The shared data structs were not protected. > This caused deadlock issue on weaker memory ordering platforms as > aarch64. > Fix this issue by adding memory barriers to ensure synchronization > among cores. > > Bugzilla ID: 342 > Fixes: 775003ad2f96 ("distributor: add new burst-capable library") > Cc: stable@dpdk.org > > Signed-off-by: Ruifeng Wang > Reviewed-by: Gavin Hu > --- > lib/librte_distributor/rte_distributor.c | 28 ++++++++++------ > lib/librte_distributor/rte_distributor_v20.c | 34 +++++++++++++------- > 2 files changed, 41 insertions(+), 21 deletions(-) > --snip-- I tested this on my system, and saw no performance degradation. Looks good. Thanks. Acked-by: David Hunt