DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Kinsella, Ray" <mdr@ashroe.eu>, Thomas Monjalon <thomas@monjalon.net>
Cc: John McNamara <john.mcnamara@intel.com>,
	Marko Kovacevic <marko.kovacevic@intel.com>,
	dev@dpdk.org, david.marchand@redhat.com,
	Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH] doc: add sample for ABI checks in contribution guide
Date: Fri, 7 Aug 2020 13:58:23 +0100	[thread overview]
Message-ID: <e2e373b1-3851-4951-1263-66bd34694758@intel.com> (raw)
In-Reply-To: <db9a9001-3e99-d048-e493-e759d19dceea@ashroe.eu>

On 8/7/2020 1:00 PM, Kinsella, Ray wrote:
> On 07/08/2020 00:43, Thomas Monjalon wrote:
>> +Cc David, Neil and Ray
>> 03/07/2020 19:15, Ferruh Yigit:
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> ---
>>>  doc/guides/contributing/patches.rst | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>> diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
>>> index 25d97b85b..39ec64ec8 100644
>>> --- a/doc/guides/contributing/patches.rst
>>> +++ b/doc/guides/contributing/patches.rst
>>> @@ -550,6 +550,10 @@ results in a subfolder of the current working directory.
>>>  The environment variable ``DPDK_ABI_REF_DIR`` can be set so that the results go
>>>  to a different location.
>>> +Sample::
>>> +
>>> +        DPDK_ABI_REF_VERSION=v19.11 DPDK_ABI_REF_DIR=/tmp ./devtools/test-meson-builds.sh
> This is good, but I think we ought to include some guidance on what version to use.
> What we agreed at the techboard meeting was that the last release should always be used. 
> The script should probably automagically select the last version.
> That is work to be done, for the moment, it will be sufficient to amend the line
> "To enable them, a reference version must be selected via the environment variable DPDK_ABI_REF_VERSION."
> to something like
> "To enable them, a reference version must be selected via the environment variable DPDK_ABI_REF_VERSION. Contributors should be ordinarily be referencing the most recent release of DPDK."
> Make sense?

Intention of the patch is to provide a sample command to help using it,
independent from what version to use.

What do you think doing reference version guidance in different patch?

  reply	other threads:[~2020-08-07 12:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03 17:15 Ferruh Yigit
2020-08-06 23:43 ` Thomas Monjalon
2020-08-07 12:00   ` Kinsella, Ray
2020-08-07 12:58     ` Ferruh Yigit [this message]
2020-08-07 12:58       ` Kinsella, Ray
2020-08-07 12:59   ` Kinsella, Ray
2020-11-27 14:37 ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2e373b1-3851-4951-1263-66bd34694758@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=mdr@ashroe.eu \
    --cc=nhorman@tuxdriver.com \
    --cc=thomas@monjalon.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).