From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 616FFA00C2; Thu, 5 Jan 2023 10:53:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09691400D4; Thu, 5 Jan 2023 10:53:50 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4585240041 for ; Thu, 5 Jan 2023 10:53:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672912428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VJuk/CliGJEZURzrurwjF4N9AmH9X7OnIM0DYUjF9MQ=; b=ZjrsQjX6RVYRWyo+snbfmt8P2qVy2pxacSM4O3iyJ7DGnCw+WV5fpJJdU41Yu5bd0LC+FC C27zeNjC3xO5sPE6/1XgYR0lNoXKxiuAHCYyCOw4bHqxihG08thN+M8NVg6xLgOdZtdtM9 SN9F4wm+Tj7HNxkzOgCkGj8gUsyDQLM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-144-2i8sVQD4OtOQJxtsK4VOYA-1; Thu, 05 Jan 2023 04:53:47 -0500 X-MC-Unique: 2i8sVQD4OtOQJxtsK4VOYA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 15D288027FE; Thu, 5 Jan 2023 09:53:47 +0000 (UTC) Received: from [10.39.208.15] (unknown [10.39.208.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 34EA8492B06; Thu, 5 Jan 2023 09:53:46 +0000 (UTC) Message-ID: Date: Thu, 5 Jan 2023 10:53:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v1 0/3] bbdev: remove offload cost To: "Chautru, Nicolas" , "dev@dpdk.org" Cc: "Vargas, Hernan" References: <20221214233346.391973-1-nicolas.chautru@intel.com> <003bf3bd-bd2b-b365-5f00-7455369b7295@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Nicolas, On 1/4/23 19:01, Chautru, Nicolas wrote: > Hi Maxime, > > I don’t see them on the baseband tree dpdk-next-baseband > > I did a clean clone, these are the last 3 commits > dc0a5a0d2a (HEAD -> for-main, origin/for-main) test/bbdev: explicit check for allocation failure > 0e927787a3 test/bbdev: fix build issue with optional build flag > 51d49ccd23 test/bbdev: fix build issue with optional build flag > > I don’t see the last 3 commits from patchwork (ie. the serie from that email) > [v1,3/3] app/bbdev-test: remove offload cost optional build flag bbdev: remove offload cost - - - 3-- 2022-12-14 Chautru, Nicolas mcoquelin Awaiting Upstream > [v1,2/3] drivers/baseband: remove offload cost optional build flag bbdev: remove offload cost - - - 1-- 2022-12-14 Chautru, Nicolas mcoquelin Awaiting Upstream > [v1,1/3] test/bbdev: explicit check for allocation failure bbdev: remove offload cost - - - 11- 2022-12-14 Chautru, Nicolas mcoquelin Awaiting Upstream > [v3,3/3] test/bbdev: explicit check for allocation failure test/bbdev: fix build issues with optional build flag - 1 - 10-- 2022-12-13 Chautru, Nicolas mcoquelin Awaiting Upstream > [v3,2/3] test/bbdev: fix build issue with optional build flag test/bbdev: fix build issues with optional build flag - 1 - 1-- 2022-12-13 Chautru, Nicolas mcoquelin Awaiting Upstream > [v3,1/3] test/bbdev: fix build issue with optional build flag test/bbdev: fix build issues with optional build flag - 1 - 11- 2022-12-13 Chautru, Nicolas mcoquelin Awaiting Upstream > > Do I miss something? This last serie doesn’t look applied on the remote repo. Could you double check? Hmm OK, I think I got mislead by the similarity of the commit titles between the two series when I changed the state of the first series. I'm reverting back the state of this series from "Awaiting upstream" to "New" since I have not reviewed this one yet. I'll try to review it before end of week. Thanks for the heads-up! Maxime > Thanks > Nic > > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Wednesday, January 4, 2023 4:43 AM >> To: Chautru, Nicolas ; dev@dpdk.org >> Cc: Vargas, Hernan >> Subject: Re: [PATCH v1 0/3] bbdev: remove offload cost >> >> Hi Nicolas, >> >> On 1/3/23 23:07, Chautru, Nicolas wrote: >>> Hi Maxime, >>> >>> Happy new year. >> >> Happy new year. >> >>> What does the state " Awaiting Upstream" mean in patchwork for that >> serie? Can this be applied? >> >> It means it is the the bbdev tree, and is awaiting being pulled into the main >> tree. >> >> So it is applied, but only in the bbdev tree for now. >> This should not be an issue since you shold base your work on top of the >> bbdev tree. >> >> Regards, >> Maxime >> >>> Thanks >>> Nic >>> >>> >>> >>>> -----Original Message----- >>>> From: Chautru, Nicolas >>>> Sent: Wednesday, December 14, 2022 3:34 PM >>>> To: dev@dpdk.org; maxime.coquelin@redhat.com >>>> Cc: Vargas, Hernan ; Chautru, Nicolas >>>> >>>> Subject: [PATCH v1 0/3] bbdev: remove offload cost >>>> >>>> Removing the optional build flag RTE_BBDEV_OFFLOAD_COST from Intel >>>> baseband PMDs and bbdev-test application. >>>> This helps to simplify build variants complexity causing compilation >>>> issues to be missed. >>>> >>>> Maxime, the first commit is actually a miss related to last commit on >>>> top of tree, you may want to merge these two commits together in the >> history. >>>> Sorry for missing it earlier. >>>> >>>> >>>> Nicolas Chautru (3): >>>> test/bbdev: explicit check for allocation failure >>>> drivers/baseband: remove offload cost optional build flag >>>> app/bbdev-test: remove offload cost optional build flag >>>> >>>> app/test-bbdev/test_bbdev_perf.c | 29 +------- >>>> drivers/baseband/acc/acc_common.h | 12 +--- >>>> drivers/baseband/acc/rte_acc100_pmd.c | 2 - >>>> drivers/baseband/acc/rte_acc200_pmd.c | 2 - >>>> .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 10 --- >>>> drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 10 --- >>>> .../baseband/turbo_sw/bbdev_turbo_software.c | 70 ++++--------------- >>>> 7 files changed, 17 insertions(+), 118 deletions(-) >>>> >>>> -- >>>> 2.34.1 >>> >