From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E71FBA09E4; Fri, 29 Jan 2021 10:24:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC5FD240134; Fri, 29 Jan 2021 10:24:53 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 97D8A40694 for ; Fri, 29 Jan 2021 10:24:52 +0100 (CET) IronPort-SDR: pPVx75AxT2/oxr4gho707GZVT6su2pcK2X6hUgmIk4zNqziYLtR/YJIxdPhIbfe6enbPPOWD0Q AL9y0YG3LohA== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="244480788" X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="244480788" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 01:24:51 -0800 IronPort-SDR: ZoFwIW4xEOXagToLj48KfQahtWMUVjex81TPR6QGkKKFoKk32EmcCpiJdAyFXS5/NEvQi9I8Jg YllZwET/Xsew== X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="389229193" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.197.204]) ([10.213.197.204]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 01:24:49 -0800 To: Nalla Pradeep , Radha Mohan Chintakuntla , Veerasenareddy Burru Cc: jerinj@marvell.com, sburla@marvell.com, dev@dpdk.org References: <20210128152220.214485-1-pnalla@marvell.com> <20210129001640.1251-12-pnalla@marvell.com> From: Ferruh Yigit Message-ID: Date: Fri, 29 Jan 2021 09:24:46 +0000 MIME-Version: 1.0 In-Reply-To: <20210129001640.1251-12-pnalla@marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v6 11/12] net/octeontx_ep: receive data path function added X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/29/2021 12:16 AM, Nalla Pradeep wrote: > Function to deliver packets from DROQ to application is added. It also > fills DROQ with receive buffers timely such that device can fill them > with incoming packets. > > Signed-off-by: Nalla Pradeep <...> > @@ -240,7 +246,6 @@ otx_ep_droq_setup_ring_buffers(struct otx_ep_droq *droq) > if (buf == NULL) { > otx_ep_err("OQ buffer alloc failed\n"); > droq->stats.rx_alloc_failure++; > - /* otx_ep_droq_destroy_ring_buffers(droq);*/ > return -ENOMEM; > } Can you please fix this where it is introduced at first place?