From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0203FA0543; Tue, 4 Oct 2022 16:53:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A372640DFB; Tue, 4 Oct 2022 16:53:19 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 6BE9A40DDC for ; Tue, 4 Oct 2022 16:53:18 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id C2E175D; Tue, 4 Oct 2022 17:53:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru C2E175D DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1664895197; bh=sfPnpC9abkPu5F9OZFWSxmvZsp7sNUqHzx5eb0/dRsQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KZNroNbPg96JUZEx3gx1SwjqBA7RsTjoXkepe/oI+RZEcEPs/otf664tE0YIUixtQ 0hZ81GFUbfNjMLvqgNoNa1bgE5B3noilRQwuImoc5RDgDSynCwaS3vQv2wSSFEJGUI C+oiwxxWurhMkdxZy3qMGQFQjI+/igrTxrwaHQ8Y= Message-ID: Date: Tue, 4 Oct 2022 17:53:17 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] memif: memif driver does not crashes when there's different N of TX and RX queues Content-Language: en-US To: Joyce Kong , "huzaifa.rahman" , "jgrajcia@cisco.com" Cc: "dev@dpdk.org" References: <20220726101628.2118564-1-huzaifa.rahman@emumba.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/8/22 13:39, Joyce Kong wrote: > Hi Huzaifa, > > This patch looks good to me. > And would you please help review my memif patches? > https://patches.dpdk.org/project/dpdk/cover/20220701102815.1444223-1-joyce.kong@arm.com/ > > Thanks, > Joyce > >> -----Original Message----- >> From: huzaifa.rahman >> Sent: Tuesday, July 26, 2022 6:16 PM >> To: jgrajcia@cisco.com >> Cc: dev@dpdk.org; huzaifa.rahman >> Subject: [PATCH] memif: memif driver does not crashes when there's >> different N of TX and RX queues > net/memif: fix memif crash with different Tx Rx queues > >> >> Bugzilla ID: 734 >> >> there's a bug in memif_stats_get() function due to confusion between C2S >> (client->server) and S2C (server->client) rings, causing a crash if there's a >> different number of RX and TX queues. >> >> this is fixed by selectiing the correct rings for RX and TX i.e for RX, S2C rings >> are selected and for TX, C2S rings are selected. >> > Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") > Cc: stable@dpdk.org > >> Signed-off-by: huzaifa.rahman > Reviewed-by: Joyce Kong Fixed above on applying. Applied to dpdk-next-net/main, thanks.