DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Matan Azrad <matan@nvidia.com>,
	Long Li <longli@linuxonhyperv.com>,
	Matan Azrad <matan@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	NBU-Contact-longli <longli@microsoft.com>,
	 "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [Patch v2] net/vdev_netvsc: prevent alarm loss on failed device probe
Date: Thu, 29 Oct 2020 20:10:44 +0000
Message-ID: <e336bbb0-13bd-046d-18ac-49669e9dc648@intel.com> (raw)
In-Reply-To: <MW2PR12MB2492B802E243938F790C9D67DF190@MW2PR12MB2492.namprd12.prod.outlook.com>

On 10/26/2020 7:14 AM, Matan Azrad wrote:
> Hi Long
> 
> From: Long Li <longli@linuxonhyperv.com>
>> If a device probe fails, the alarm is canceled and will no longer work for
>> previously probed devices.
>>
>> Fix this by checking if alarm is necessary at the end of each device probe.
>> Reset the alarm if there are vdev_netvsc_ctx created.
>>
>> Change log:
>> v2: removed lock and flags, use counter to decide if alarm should be reset
>>
>> Cc: stable@dpdk.org
>> Signed-off-by: Long Li <longli@microsoft.com>
> 
> I suggest the next title:
> net/vdev_netvsc: fix device probing error flow
> 
> and the next fixes line:
> Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement core functionality")
> 
> Acked-by: Matan Azrad <matan@nvidia.com>
> 

Applied to dpdk-next-net/main, thanks.

(Used suggested title)

      reply	other threads:[~2020-10-29 20:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-22  8:11 [dpdk-dev] " Long Li
2020-10-26  7:14 ` Matan Azrad
2020-10-29 20:10   ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e336bbb0-13bd-046d-18ac-49669e9dc648@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=longli@linuxonhyperv.com \
    --cc=longli@microsoft.com \
    --cc=matan@mellanox.com \
    --cc=matan@nvidia.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git