From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07DF5A0503; Thu, 19 May 2022 17:28:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55CC742B75; Thu, 19 May 2022 17:28:23 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2053.outbound.protection.outlook.com [40.107.100.53]) by mails.dpdk.org (Postfix) with ESMTP id CEBE840156 for ; Thu, 19 May 2022 13:15:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D62pMgHXKpOAO23rqqHLTAsaCQoSftnWFuHj1tLlVzjmg4Rf53gz4dStkS9L1JYqm35uSSs5CMsaOYiqo03dLknClNIJlOaeSEQnoyLMcZ6FQkaih1G8CL4zxcDhxj2bxrG6ACCsTgLnegaH8o/lQxIpuHfDr5Re9Wm3VvncPFLlTrTRmpoKXuAtoCSKW7tPHSxxcO0li+VLYtX2f4oBP/LS4QTpSCkE1A1dP8vSktPPc9ygJyznYw/LUyQRsGGGZD7yQ+WTwjkR+Nyw9bFcw0NQvVoHrrkVdiLFr1KcWXrDE3Pb4kui4cLRgx9QBrbZFdqFKMAPMkeYlNTj6rJayA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pZElfyu8x7QbedU8Lz6mcLIq12fIQcHH6HO+jJfRaN4=; b=gwVTnWWcWRW/Dw6caDOzdN/R100sz0m4/fFl7JzLaUWMw0YsAyLBKPIHjGeDK86vzkJ2O7r+5IOcb/wsQFGwt/z10B4fNkRH3nFDNpw+PGkQZcZHzM/846y1G/qUa8+zt/7KLGJm3IJxAAyD91rwA/mCdghAz+fgEHtEXC0w/2413+jOmh1VE7PDDSff/gomM8lTY94MSsxm0u91wEFXBF28gCZF4l0eBMFD/C4bEwLApROoteSwkN84L7UgeoKREM+fZ9AsOD27UbkpJnFmbv2o2d6+bdCS6kYsa1Q/7DBjgyZ69U2hMqMBDx/ZE3dpG9YGq2bH37asyerDnSEl4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 149.199.80.198) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pZElfyu8x7QbedU8Lz6mcLIq12fIQcHH6HO+jJfRaN4=; b=kYURJ4e4dx2kZB+DLTGEVuA/9+L9CiZXlfbl7Wv/+TTzJeOPsGKgbcvNs+79N7lY02iThBr5aOdXlR0+Y4QjFmEwLPHDuxvi5cH+P3+7D60yZr1s7TC0tUeuavZihYLRqQyjKMskD83jWEKKiottkahAba312Z76tLjsRzEvRGk= Received: from DM5PR1401CA0023.namprd14.prod.outlook.com (2603:10b6:4:4a::33) by SJ0PR02MB7487.namprd02.prod.outlook.com (2603:10b6:a03:29b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Thu, 19 May 2022 11:15:18 +0000 Received: from DM3NAM02FT047.eop-nam02.prod.protection.outlook.com (2603:10b6:4:4a:cafe::da) by DM5PR1401CA0023.outlook.office365.com (2603:10b6:4:4a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.27 via Frontend Transport; Thu, 19 May 2022 11:15:18 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 149.199.80.198) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=amd.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning amd.com discourages use of 149.199.80.198 as permitted sender) Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT047.mail.protection.outlook.com (10.13.4.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Thu, 19 May 2022 11:15:17 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 19 May 2022 12:15:16 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 19 May 2022 12:15:16 +0100 Envelope-to: ferruh.yigit@xilinx.com, roy.fan.zhang@intel.com, bruce.richardson@intel.com, kai.ji@intel.com, dev@dpdk.org Received: from [172.21.34.28] (port=20129) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nre7g-000283-G5; Thu, 19 May 2022 12:15:16 +0100 Message-ID: Date: Thu, 19 May 2022 12:15:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [dpdk-dev v2 1/2] build: add in option for qat use intel ipsec-mb lib Content-Language: en-US To: "Zhang, Roy Fan" , Ferruh Yigit , "Richardson, Bruce" , "Ji, Kai" CC: "dev@dpdk.org" References: <20220407152931.8771-1-roy.fan.zhang@intel.com> <20220517141652.53769-1-kai.ji@intel.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 797ecf2b-6859-4620-4c4f-08da3988db10 X-MS-TrafficTypeDiagnostic: SJ0PR02MB7487:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 2 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z8VbclKzoF3rqXC1wWmkbSWY+07l4lLpWDUdpvnid1H+FLZTxLq7EKTv5heXDNLAiX6Pu2hemPaXvPMSHmKO6F4HCiQH6+XxKusKNRpPhUwG3qzkc/yxvtjO2EVUIf2l/eWAxV8OWdjmMybCCVJZ3w07SuXDKWtvC+FIryf6aC2Gz41fG5IAExPwvyPh1VEv5bfSZbKxA6CS/bDiJNv+6/JyHZr61vVZjhjQZv0B5Gk2sLhq2NHC17vYW0jhjB+fMAfVClrgCwYFrqnG74avZkIyyQxGLQRd2IXCsT4TlyMSdWS8NX08cNJQbAJ7gXumU+RPXnDQAumzdtXqmNaHjZ2NkIqT+WWdSM2uQ6X1SRN72sRleTt0E+fb+cvIhieCsiyjVtjVN163ppC3B/yMzX6kRqyKsj3YUa1Qd9DxWzWa+r5GBy68kyiZF7UAWAULRHo0RoTm9V7q6La3Q2SnBJfjngIj0pBFYY4Uz2ihUhnUW48nhTkRH54XA3zOUgVECQd3+2XU+xcCr7+e77FxKxKlVYvrnkPHnHRtGSvX/54u26gBIDhit/ukyPI/lqfJzGvojJlE3IpbEBW6msLB1Tk2dZKB9d5jqel6pwDL/0kvlV3cmelQDUVyFsGV3dsSGVJyGDZlNqJ4yYNGcPH784rpoPMssSiNOdgNJrw41JJghQWCZwCozSRbGGleTW28WRP8hEJOcz4CfG+nM/8cGWk0QmB1uQ2AYSjo+AOX3jw= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(86362001)(8676002)(70206006)(31696002)(8936002)(110136005)(70586007)(9786002)(316002)(2616005)(4326008)(356005)(53546011)(26005)(7636003)(508600001)(82310400005)(31686004)(47076005)(336012)(2906002)(40460700003)(35950700001)(83380400001)(36756003)(5660300002)(44832011)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 11:15:17.7773 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 797ecf2b-6859-4620-4c4f-08da3988db10 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT047.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7487 X-Mailman-Approved-At: Thu, 19 May 2022 17:28:19 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/19/2022 10:22 AM, Zhang, Roy Fan wrote: > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Wednesday, May 18, 2022 11:26 AM >> To: Richardson, Bruce ; Ji, Kai >> >> Cc: dev@dpdk.org; Zhang, Roy Fan >> Subject: Re: [dpdk-dev v2 1/2] build: add in option for qat use intel ipsec-mb >> lib >> >> On 5/18/2022 9:04 AM, Bruce Richardson wrote: >>> On Tue, May 17, 2022 at 10:16:51PM +0800, Kai Ji wrote: >>>> Add in build option for QAT pmd use intel ipsec-mb lib >>>> instead openssl for precompute partial hash & aes. >>>> >>>> Signed-off-by: Kai Ji >>>> --- >>>> drivers/common/qat/meson.build | 12 ++++++++++++ >>>> meson_options.txt | 2 ++ >>>> 2 files changed, 14 insertions(+) >>>> >>>> diff --git a/drivers/common/qat/meson.build >> b/drivers/common/qat/meson.build >>>> index b7027f3164..d6eaff3e0e 100644 >>>> --- a/drivers/common/qat/meson.build >>>> +++ b/drivers/common/qat/meson.build >>>> @@ -35,6 +35,18 @@ if qat_crypto and not libcrypto.found() >>>> 'missing dependency, libcrypto') >>>> endif >>>> >>>> +if get_option('qat_libipsecmb') >>>> + IMB_required_ver = '1.0.0' >>>> + libipsecmb = cc.find_library('IPSec_MB', required: false) >>>> + if not lib.found() >>>> + build = false >>>> + reason = 'missing dependency, "libIPSec_MB"' >>>> + else >>>> + ext_deps += libipsecmb >>>> + dpdk_conf.set('RTE_QAT_LIBIPSECMB', true) >>>> + endif >>>> +endif >>>> + >>> >>> In general it's not a good idea for individual drivers to add top-level >>> meson.build options. If every driver does this for all its options we will >>> have an unmanageable set of hundreds of options. Unfortunately, though, >> I >>> don't see a really good way to replace this with something other than a >>> build option - I assume it's not just good enough to check which of the >>> dependencies is found/not-found? Is there some way that this can be a >>> generic option, that may be applicable to other drivers? Could the option >>> be instead to prioritize FIPs compatibility? >>> >> >> +1 to not have top level meson option for a driver. >> >> Will it work to give priority to intel-ipsec-mb lib, like when ipsec-mb >> library exists use it, else use openssl? > > Hi Ferruh, > > If both ipsec-mb and openssl3.0 presents in the system. > - Choose openssl 3.0 will result in deprecated API warnings. > - Choose ipsec-mb will ruin the FIPs compliance of QAT PMD. > That's why we think it shall be up to user to select which way to do small cipher/hash op. > Hi Fan, got it. So the runtime devarg option Bruce mentioned can be a solution, if it works.