From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 77086BD28
 for <dev@dpdk.org>; Wed,  8 Mar 2017 16:50:36 +0100 (CET)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 08 Mar 2017 07:50:36 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,264,1486454400"; d="scan'208";a="74274049"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.185.68])
 ([10.254.185.68])
 by fmsmga006.fm.intel.com with ESMTP; 08 Mar 2017 07:50:34 -0800
To: Beilei Xing <beilei.xing@intel.com>, jingjing.wu@intel.com
References: <1488533497-27682-1-git-send-email-beilei.xing@intel.com>
 <1488533497-27682-5-git-send-email-beilei.xing@intel.com>
Cc: helin.zhang@intel.com, dev@dpdk.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <e3720374-17c0-c3e7-cd6d-4be55ccb480f@intel.com>
Date: Wed, 8 Mar 2017 15:50:33 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1488533497-27682-5-git-send-email-beilei.xing@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 4/4] net/i40e: refine consistent tunnel filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Mar 2017 15:50:36 -0000

On 3/3/2017 9:31 AM, Beilei Xing wrote:
> Add i40e_tunnel_type enumeration type to refine consistent
> tunnel filter, it will be esay to add new tunnel type for

s/esay/easy

> i40e.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

<...>

>  /**
> + * Tunnel type.
> + */
> +enum i40e_tunnel_type {
> +	I40E_TUNNEL_TYPE_NONE = 0,
> +	I40E_TUNNEL_TYPE_VXLAN,
> +	I40E_TUNNEL_TYPE_GENEVE,
> +	I40E_TUNNEL_TYPE_TEREDO,
> +	I40E_TUNNEL_TYPE_NVGRE,
> +	I40E_TUNNEL_TYPE_IP_IN_GRE,
> +	I40E_L2_TUNNEL_TYPE_E_TAG,
> +	I40E_TUNNEL_TYPE_MAX,
> +};

Same question here, there is already "rte_eth_tunnel_type", why driver
is duplicating the structure?

<...>