From: prateekag <prateekag@cse.iitb.ac.in>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] Printfs in Signal Handler
Date: Thu, 03 Dec 2020 05:32:08 +0530 [thread overview]
Message-ID: <e3950c980e91d70d410331205e0105e2@cse.iitb.ac.in> (raw)
In-Reply-To: <4079538.OZV0JHgpTk@thomas>
Ok.
On 2020-12-03 02:11, Thomas Monjalon wrote:
> 01/12/2020 10:24, Thomas Monjalon:
>> 01/12/2020 04:39, prateekag:
>> > printf is not signal safe and may lead to deadlock if kept in signal handler
>> > and
>> > signal comes in two quick succession. It will not lead to incorrect behavior
>> > and it is a highly unlikely event. And an expert may understand why this
>> > issue happened. Is it worthwhile to change these printfs to unix I/O write
>> > call?
>>
>> Thank you for reporting.
>> Please could you describe which files and functions you are talking about?
>
> I've received a private reply:
> Filenames:
> testpmd.c
> test_pmd_perf.c
> evt_main.c
> pdump/main.c
> Function name:
> signal_handler
>
>
> I am OK with removing these printfs.
>
> Do you want to do the patch with the explanation?
next prev parent reply other threads:[~2020-12-04 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 3:39 prateekag
2020-12-01 9:24 ` Thomas Monjalon
2020-12-02 20:41 ` Thomas Monjalon
2020-12-03 0:02 ` prateekag [this message]
2020-12-04 9:20 ` prateekag
2020-12-04 9:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3950c980e91d70d410331205e0105e2@cse.iitb.ac.in \
--to=prateekag@cse.iitb.ac.in \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).