From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93BC5A04A7; Tue, 25 Jan 2022 10:59:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D5C34285F; Tue, 25 Jan 2022 10:59:55 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id D5281426D8; Tue, 25 Jan 2022 10:59:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643104794; x=1674640794; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=BZJaXzRgr8Sf3e9T0KIkJuBPXl5ssKLs/PI7C2C674I=; b=Xkcv7M7d+r/cx3cPdD+0d6eir8N+lUNiQv0gBMs+VJG2tWPbvh9sFSTE TPskzinZew8krggaeVqfWCJi3KE50lhSsBKnDt+tnl7naFkIdivl4/PzZ zV9uK580TIQ/UMkRJHVXVYKaMy/WS4kloeJHBNUt0rDUCkaGUMStivpd4 mSm6zo5anv9/7Ka3Z9hCWFrFNEk1nHj4EpF0pvHVAwAd8kkDiMS/XUb8N NUbtIJK+A9mqJv0cOIJGVl8pV3O3dGSDbdEFl7LaNsJt14L6gYH+cNl+M cxhgnSIEQ9JT8njf6d9nRVLzp69ngY5mYpEpX3D/s/c1tu9oHNbsGX9pf A==; X-IronPort-AV: E=McAfee;i="6200,9189,10237"; a="245102468" X-IronPort-AV: E=Sophos;i="5.88,314,1635231600"; d="scan'208";a="245102468" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 01:59:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,314,1635231600"; d="scan'208";a="695780569" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga005.jf.intel.com with ESMTP; 25 Jan 2022 01:59:51 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 01:59:50 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 01:59:50 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 25 Jan 2022 01:59:50 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 25 Jan 2022 01:59:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NVineYW61wWyLJ63fk1etaYvoEfxfiBF3tisF/TJ9RLf0rpBKnTUSzGei3G9ImWBi3YpvOStQKt2FXWcZ5sNfJpNYQByfoc/nS0m6ux37E0Ena6pftfEb9P2zrfwKer+nu8gWgS83ZB6OEgfq/vnJDdNmrwtIzkrCLDY7CRrRbJT+KyDWEICQJg4qQYS3/U8LaBUkppbB1In+nHIfYLT+QusBMiHjOIUaVGt1tjaNMpN3wZz8LR+qsOQj2/kW5vu7SSitmqvpX7lD6ObTHUO8pT23KD2+GP3HMAcSmPaA30Thtkykx61coscliGBOEmGPyO3TWyR1WPQjrO1JSs3Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bGsRCEEtG+2T7TkpcS0ctPmdHhLC/TS38ATi1RCOseI=; b=BDJflNwQyq0YYzbrtlLHTWoGWBvwHxSRoW+6DspSeDnfvR6TgTAXA3JzzmGCxApo+WaeTn096R93WJR/zzPwUufROR3KSnul38gGYkRIfvGTXxZ8pK6oldScnRqL57PD0m2e7XG7h5mhEsRIMDR1IRbA6TBUrTSk2zcf9/rOD3Wa0Wtc2K1E2pll3wuuClK5TmsUOVtbdpOR/9Vbt1r6HEcsaIO4b/kWm+UC/Rqf13m6lEdF3VrzWFHXKB3oTO0umtwI2IQA9uFNVGM2HGBpiro1q8e+UeItYIp2Ej2JqMXITSuvtAgmQP/7uXWsYVRIuF4lUuc9vsOnIINMLD+Khg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BYAPR11MB2853.namprd11.prod.outlook.com (2603:10b6:a02:c8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.10; Tue, 25 Jan 2022 09:59:48 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4909.017; Tue, 25 Jan 2022 09:59:48 +0000 Message-ID: Date: Tue, 25 Jan 2022 09:59:43 +0000 Subject: Re: [dpdk-dev] [PATCH] ethdev: fix rxq_state leak in error path Content-Language: en-US To: Yunjian Wang , CC: , , , , References: From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0186.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::11) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0ab27e85-ce29-413d-be27-08d9dfe96c05 X-MS-TrafficTypeDiagnostic: BYAPR11MB2853:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1169; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GR2IdvjoJXXTFoGo3419dX42YT/tfbGl0VBttg3xNevjff89aCynArvajGOHk+vI267iTcH2bsz9aIyhhTWAVTqterh1BBTJktp6IsMW68m7V8E+sPoGM9OrTJI8k8Rn8t5F8Hiu7pIligfGHr+6BGhgDeIaj334voAcVyGieTLLnes7JyNuCcQsIQbjgcVsQZ+ksdUyJ86f++zNrsLw9hhna4oq9Wk6JycuNh9z4sdGbJfuIpvUW6OuJ+JW4FvhhpvoqLkXyY73g3+jEtoiF9mM7BVOKrE3fayQ8FVH7GAEP0IjjlhMOb/1s7BxXzZpYLJ/ZwCh/ZoYYO0cs7/Cg6M3o9+nluqPDJCUACSmoGUr7H/lf77g5yKEYD+vb/MBCcS1KTIy738XEihNcKceAiohJWVaRj3KUkrP9+WG273KqvhDNQZ2RLLljj+Z93AUrx6QeMrvrw++gc4wh0moevJzSJY+c15yiegOiwPYykQCkNvCg6l/9whOAZixBIT3ZGX9/NK6DGR1AZr7/AWcE24mLpEmaGd2BcM1FpweIL7VhZoMPLG1HeEowx6gUcHAmrokuxsiYRSZbq9YykySujH6JthbBtQZ8labxiMdNf2CQHttFX1J/jOVOH6l846FLQyyFPW2IS42PNVheDenu4P7+kGyDI8cq5ejb8rhdmAVHcZN4gea9WcZhcBqDV2T3nK8VRJc6DZksXEqpO0R0A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8936002)(66556008)(66476007)(66946007)(31686004)(186003)(26005)(6506007)(86362001)(6486002)(82960400001)(8676002)(53546011)(6666004)(6512007)(31696002)(4326008)(5660300002)(44832011)(36756003)(4744005)(2616005)(508600001)(2906002)(38100700002)(316002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azlBbFNrS3FJOGJrZU5RVVBKcVQ0WERvVTF0VFJnZHdwSmRrb01mSmhpYzA0?= =?utf-8?B?V3VTYUNweFFTd2srd3FacDFQL3p4Y3JrMUt6dlZ4UHRYQ2hCOVNvOXpYQTF0?= =?utf-8?B?WXdMZ3pyT3kvRnNDSVBOL0dzblVPMm5odFFoWnpZb2xYS0dLZnc4YmoxZllS?= =?utf-8?B?K0hjNXVON05kbEFLVStuVXZHY2U0TjdVWm9WUy9FVmRwTjZIYmNkMnNrOEMv?= =?utf-8?B?MHZ6WDdUK2FqSWF5OFV1NU4vU25TKy94MHZGU2xuZ2UwNzM3Rks4Z2xMRlUx?= =?utf-8?B?VUtMRE9ycWRzOGdhMjNYbDJnckR6bjM4TUR2THovTTZzTnIwRzY2ajM5bGsz?= =?utf-8?B?NkJjT2RlbHlBWW9zajJhdjB1d1JIdTI4STllLzZPLzRKaUJxVTh0NVhnQjV3?= =?utf-8?B?YnB4NkxYZ2tVSzRSaG5kWmc1WDhYakNLTHRTSnlWYStvKzhqZnZscnFRNktq?= =?utf-8?B?YkZvTHNYQ3BBRjVSK0xhYWE5UXlPZUtGQlV6YVJiUVk2QTFkejl6bExWRDBU?= =?utf-8?B?MkNvUlJqeDg3SWFUVGQ4VzFnQjdNSlptTmUwUEdHZE40UkNaaHpUUzBNTFMz?= =?utf-8?B?Ny92YUNtd0Z0aVJGWlNINmcyQ09tNktUY2xlN0o2eC9ka3o3ZDhJR3VWVzBV?= =?utf-8?B?MG1ZeUxhdW5BK2dzOGd4djlreG1lTVh6YjVpdXBiTk5aNjFUWlV6Z0Q2TTls?= =?utf-8?B?RGpWVmdEVGxYOGNpZUJVOFBmOHdwblF6OGM2TnN3M2MvZmMzK1o4eW9qWnJO?= =?utf-8?B?UXJ0UkJjaThzbTdvQlI3WHZpVkpXeW84L0RxUHBKTjZyOU96Mzl2RkZoWWlv?= =?utf-8?B?Ymg1dmpXVTAxZ2RWbDIyTlRsWm1PU2RrSkg1RS9LREYyaWRIMk5NK0hDVlA0?= =?utf-8?B?TEtJSXpPNEo3ZEN6b2RIN0hLT2tkUXk4bXozOW5HejlmTEhhSmU1SThWVU9R?= =?utf-8?B?WnNpOEhzUDRzOWUzeUo2MnR2UUFvM1N5bkNjL1pGc04rZ2lBNUFTNHpmdGpi?= =?utf-8?B?K1M1eW1xblFFN3BhMVRycHJudVVSQ1lvc2dFc0pmWDhiUDBZandTY1htZ3FZ?= =?utf-8?B?Wk5yV2J2VUZMbmp3Y2k1OHg3Um5MVktsSUtnVHVXNXZodnVXeWErblhoT2kw?= =?utf-8?B?Ti9IVEdxZkl0OUx5T1Nrbnlta0pkcXlqRkxxd24vQWdjdklLbkVhZ090LzZk?= =?utf-8?B?c0RoLytjU2hJRytIL2luM0lKUFhQcUw0aVo0WEdaRVZqVGVBaTlEOXhpc3lU?= =?utf-8?B?NFp2ZUREdGRzMVBidjhwaTdDYzNOU0VpcHVFenZGdk1reGdodGVlK05NclBh?= =?utf-8?B?TFRXaGRpdlVxM2t2UUJHdkxVYUV2RGFrbUZJOGhIckxKTHNrRlowSTh5L253?= =?utf-8?B?SzI5N3EvbVdIclUxVW5ZZ2RvbHdMcERaclhCYllaWUhOM2JGd29lTmdITWZW?= =?utf-8?B?Rzk5cVNLdmtMMVRvQUY4TkJzVW5Ka1B5ei80Qmt2UVJMZnR4Yi96ZGRXTy90?= =?utf-8?B?ZHU1bVc0N0tpNk9xeFJud2lRQThPMENFMWhKQ29rTUZjU3J2S0ZjNVMyaTZC?= =?utf-8?B?R3YyL0Y2QUNoditiUjhDZVBHWHBIYldRZ0xDdkFBaHVmM09oNW5PcmhFZUNW?= =?utf-8?B?eUxuRXd6SUIzdmgrQU8xcHduZTJQMzNFTC8wcXk4WEd6U051NjNTV0pNaTNh?= =?utf-8?B?ZVZWTmtycVF6M2p0YnpwTWYvakQxeVMzRDV2SUJZUUFzVFY1bEg5TGdxbjQ0?= =?utf-8?B?OVBEWWMreTc5WW5LMjUzeTJJQzAxRDgvdUFkTGNweGRlc0EvNzdDUjBCb3Ez?= =?utf-8?B?MHlwWm5aM2t1ZC9Bdkl2RXRuMDZXcjd1MlQ1ZUFrMlM5MnVjL0NQV0hSL0E0?= =?utf-8?B?U3NuUmo0NWMyb1ozYk9WK0lCckE0ZWpqRUcyWFhVaGRVN3FFMEkzTkI0MmV6?= =?utf-8?B?R25hQnpSNkhYVTdXVSt0VVpjTUgyOVlNNFNsNnhyMUY0dTBpaUI5UTRGc0xW?= =?utf-8?B?cWhjR2FGQmxMcXpKbjFvRmJ5aERWM0dBR01hQWJQbXNpb0pJM2hGMEowZmhM?= =?utf-8?B?QkJEdW9nYXB3WGdaOTBLSnRqbWtZRU9yZHBHYVJtdWRsaEEva1RQQW9XcHI2?= =?utf-8?B?bHc4a1NFZHJITTFvRnJxbEZBZkwzWk0xWXRIcUxVc1ZMcHh3dUk3ZHBybFJs?= =?utf-8?Q?9Q9W/uXdBPeWp/ew9U00NnE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0ab27e85-ce29-413d-be27-08d9dfe96c05 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2022 09:59:48.5293 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hevMz2REL6ZEDSciRF/v14ro5xMxTKhtogBC2Cz7r4pKXyXKRuM1rFn7m+42vZzv8m8gYnAIZpWOcexspKif+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2853 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/8/2022 7:51 AM, Yunjian Wang wrote: > In eth_dev_handle_port_info() allocated memory for rxq_state, > we should free it when error happens, otherwise it will lead > to memory leak. > > Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.