From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9E9541CEC; Mon, 20 Feb 2023 16:39:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C82A44307C; Mon, 20 Feb 2023 16:39:04 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7055843079 for ; Mon, 20 Feb 2023 16:39:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676907543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hym0DKTBHe4d9OEQOVxIgrAA4kuP1AklnMXSNRdMcEU=; b=NWycN5FKiqQ5FQwWVWNB77u1FhU0WoY8Ahdk8Rg7TnHRzr1LDmOgfVU/WOmkJdO7sgbbVk 5UytvbKcCVWiNsHoDPoVCZaMZNyg0v+BXps6kN88k9iSjfOKDH1ZubA7lCKY7xv93EVni8 hqLWrJOsOEZnjcJPMY+GgFc5KODMZrg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-358-a2KN88bdNOKeLJFp33-G5Q-1; Mon, 20 Feb 2023 10:38:59 -0500 X-MC-Unique: a2KN88bdNOKeLJFp33-G5Q-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5FC20101B44F; Mon, 20 Feb 2023 15:38:59 +0000 (UTC) Received: from [10.39.208.21] (unknown [10.39.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2EC7F492B04; Mon, 20 Feb 2023 15:38:58 +0000 (UTC) Message-ID: Date: Mon, 20 Feb 2023 16:38:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v1 04/13] test/bbdev: early termination not explicit set To: "Vargas, Hernan" , "dev@dpdk.org" , "gakhil@marvell.com" , "Rix, Tom" Cc: "Chautru, Nicolas" , "Zhang, Qi Z" References: <20230117165023.20567-1-hernan.vargas@intel.com> <20230117165023.20567-5-hernan.vargas@intel.com> <8f83ee36-3aef-ac41-0722-9df33bdf2f0d@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/10/23 18:15, Vargas, Hernan wrote: > Hi Maxime, > > -----Original Message----- > From: Maxime Coquelin > Sent: Tuesday, January 31, 2023 4:04 AM > To: Vargas, Hernan ; dev@dpdk.org; gakhil@marvell.com; Rix, Tom > Cc: Chautru, Nicolas ; Zhang, Qi Z > Subject: Re: [PATCH v1 04/13] test/bbdev: early termination not explicit set > > > > On 1/17/23 17:50, Hernan Vargas wrote: >> Early termination needs to be explicitly enabled. >> >> Signed-off-by: Hernan Vargas >> --- >> app/test-bbdev/test_bbdev_perf.c | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c >> index 14fe76eb64..12fa988da6 100644 >> --- a/app/test-bbdev/test_bbdev_perf.c >> +++ b/app/test-bbdev/test_bbdev_perf.c >> @@ -4463,7 +4463,7 @@ latency_test_dec(struct rte_mempool *mempool, >> struct test_buffers *bufs, struct rte_bbdev_dec_op *ref_op, >> int vector_mask, uint16_t dev_id, uint16_t queue_id, >> const uint16_t num_to_process, uint16_t burst_sz, >> - uint64_t *total_time, uint64_t *min_time, uint64_t *max_time) >> + uint64_t *total_time, uint64_t *min_time, uint64_t *max_time, bool disable_et) >> { >> int ret = TEST_SUCCESS; >> uint16_t i, j, dequeued; >> @@ -4481,6 +4481,13 @@ latency_test_dec(struct rte_mempool *mempool, >> ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz); >> TEST_ASSERT_SUCCESS(ret, >> "rte_bbdev_dec_op_alloc_bulk() failed"); >> + ref_op->turbo_dec.iter_max = get_iter_max(); >> + /* For validation tests we want to enable early termination */ >> + if (!disable_et && !check_bit(ref_op->turbo_dec.op_flags, >> + RTE_BBDEV_TURBO_EARLY_TERMINATION)) >> + ref_op->turbo_dec.op_flags |= >> + RTE_BBDEV_TURBO_EARLY_TERMINATION; >> + >> if (test_vector.op_type != RTE_BBDEV_OP_NONE) >> copy_reference_dec_op(ops_enq, burst_sz, dequeued, >> bufs->inputs, >> @@ -4873,7 +4880,7 @@ validation_latency_test(struct active_device *ad, >> iter = latency_test_dec(op_params->mp, bufs, >> op_params->ref_dec_op, op_params->vector_mask, >> ad->dev_id, queue_id, num_to_process, >> - burst_sz, &total_time, &min_time, &max_time); >> + burst_sz, &total_time, &min_time, &max_time, latency_flag); >> else if (op_type == RTE_BBDEV_OP_LDPC_ENC) >> iter = latency_test_ldpc_enc(op_params->mp, bufs, >> op_params->ref_enc_op, ad->dev_id, queue_id, > > Not clear to me whether it should be a fix. Any thoughts? > > Thanks, > Maxime > > This is not a fix, it's just an enhancement to enable early termination for validation tests if the device supports it. > The validation tests currently run iter_max number of iterations for decoding, with this enhancement the decoding could terminate early. > > Thanks, > Hernan Could you please fix your email client? The message you are replying to is not quoted. Thanks, Maxime