From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1CEA423FE; Tue, 17 Jan 2023 16:14:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 818EC400EF; Tue, 17 Jan 2023 16:14:08 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2044.outbound.protection.outlook.com [40.107.237.44]) by mails.dpdk.org (Postfix) with ESMTP id D97E8400D4 for <dev@dpdk.org>; Tue, 17 Jan 2023 16:14:07 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MM/s3aCaLQ7RCtNO/VdlrZ6jz+JUKJGpdz24rP9tsv+WZlTCQ9cjXbJbpi3wffdnGnuUlL1748Q6ecUG3UN85TG829sBaA4Y79LheOlDoghcmU+ihdNxvvfoNrOLfq76eed5ux0RnGXeBcBDrBFkl65OlhJyyf4dfLmUC6cD6nw/q0M4tLiNShhn5uCRX5Bpt+mS9tnQZ+7BAkVNe0XkGECAdfdsXVfZlrQCa8AKjgGUEfkzi/w13XN0BsT6yYxkxoUHgm4xyKjTxjUm9wEohMGqTy4QgvRlIvOun1yhkVU8JqzROKbnOrTwskqDetwg9/KXZnykLzbEiumOkgdrDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0npg1HJoeYPzYeVW3tM7XXmeYcGT/tVR2fN9IYA6Q5c=; b=NZIQr5iZZyQI7QBLKXL7PtmViEolQINJOvefKuh+LAnxoNmwDqGk+oauCxjtb0bNAbchnENfVJsOuRF8uxEHxkhQBuk8/D+Qdsy1Pz4TrCPaDJVyCX/4zibzUru5Od/poAhE/hKNRHUhuPZpdiv3D4swJO8l76y6U3D37SHObYiTezifASOyBDFfOk7a+b3zZ/xN/P8fwVTG+LGXNw5k4gnNS4YgOeMfCGiMcTpmSpUYdnmZt+E/yhYT0asTkdAUgXZYB73W5aoCNolrliAulHcB6ExZ1eP4GwMJLfmvkT08Yxx17icobb8UF5NjqJiO1HkIcmINbX5T96HLdojEiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0npg1HJoeYPzYeVW3tM7XXmeYcGT/tVR2fN9IYA6Q5c=; b=U8cZTs5V/NyJZ+Vk3fwW3WttC0dFXdG7N7ryBnKkz8DfdqSyeZd4HEehgXhLFKN2m0hQMHlStYCq+pIKaVWNIccGXoMm9586cQ1cd3ALrJUXyEgq7dGRWQFY2CHfmDCYoNbwsQElS3HRNfdnLDURUCIzrfKLcZiApyYKl/Qqpd8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH0PR12MB5060.namprd12.prod.outlook.com (2603:10b6:610:e3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Tue, 17 Jan 2023 15:14:06 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%7]) with mapi id 15.20.5986.023; Tue, 17 Jan 2023 15:14:05 +0000 Message-ID: <e4183a87-c33d-2a33-efa7-56bdc5eb29d6@amd.com> Date: Tue, 17 Jan 2023 15:13:58 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v7] ethdev: add special flags when creating async transfer table Content-Language: en-US To: Rongwei Liu <rongweil@nvidia.com>, matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Ivan Malov <ivan.malov@oktetlabs.ru>, thomas@monjalon.net Cc: dev@dpdk.org, rasland@nvidia.com References: <51e583ea-4446-fea5-af74-dfe75d37f05c@oktetlabs.ru> <20221114115946.1074787-1-rongweil@nvidia.com> From: Ferruh Yigit <ferruh.yigit@amd.com> In-Reply-To: <20221114115946.1074787-1-rongweil@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0698.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:37b::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH0PR12MB5060:EE_ X-MS-Office365-Filtering-Correlation-Id: b338e368-28d5-41aa-657b-08daf89d793f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MwFAq3aypTRx8wAwAUiF9hWvRfzMkb2PzxMCATulQkP/LR2qCkjUayD+ZtmmYXI+IRgFPAc5louhyvYsIdxBcHMNeN0paqPjYFT2SGe3jbcF53l40CubVFiYAM+vtkru09/IZVLQwUNX/0wYawXqFvvLUpevypMAd4hwsUTb9nzY4cdYhMcL5YLzc8q0NVARapThOl1svgTuczcBGiKNygN7UNuwTswgdDyufZi6clTYbTTWlwExINe+yfpdiw8R1IwbgZaXhgNMx/lsT88t+/+2Rn4GxLJnjiq9VmUNYRS63TWiwnls2+sdO3YxE/FTAm7HfTmNDC4DgEFFbhg3hW4PsB5tEER+/yu93aZKJbUxZ5VF3XeRncz/lfgco6DRUHPl0DsQgFkW8MlKyjmwZ9bfhcIJ/DVFcnYVteokTN8vieVAhspNeALkpkLTdABa90NndCna19/qFmo9qwQyN2mA2RA4WwIWPhdeRp8WPPf2HxT+M5ZhelC+UICNBiKjyQ+J7/Z2EP8GPAf/BWcwzD5dcvJ5rmzsj37HZbJhcKffX8x5ImxRQnZGjTZLu4x2IbAFJgH0IGHyFh9jKv5lVAcAOlhxMsJTS2dX8ZHrTFt6tLGHqeBQCngKEwvEMv4RxV8bdPKUigx8HttuSKdkQN2Tm0s6s/HGHzBfiDxUVXdl2DPLMpcfyQ3QmlCMVun7yyYDy6BeRr+tyUzajRN84ONeZKt7SvWW6a/Lf8/kxjo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(346002)(366004)(451199015)(31686004)(86362001)(66556008)(41300700001)(66476007)(2616005)(66946007)(186003)(4326008)(8676002)(26005)(6512007)(31696002)(36756003)(53546011)(5660300002)(83380400001)(8936002)(6666004)(478600001)(110136005)(316002)(6506007)(2906002)(7416002)(38100700002)(6486002)(44832011)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTVGd2RpOE1xcU9JWDlrTzFqL2NqMHNFU0dBckJiM0RLd2xTR3I5aWdkdElP?= =?utf-8?B?bFlCeEc0R3FQOTMyRVlpUDdJMk9hc0w3UEN1OWxvQy9HY1VQYVMyNDVRTnh4?= =?utf-8?B?aS95bnZ3R0ZyRnlmN1dKeFo0TzdFRlpmWkp1WHE4UWRPcXlhWll6NkVHWW9k?= =?utf-8?B?WVZOK0ZEV1h1bFhwV01LNkt6djlBNVFrNE53VC9BMFZrTW1obnJBZnJzWDJB?= =?utf-8?B?ZHk0cmJuMVY1QnlEV2V5a2NGUFFqTXNpOC92WDU0M0doU2JBT3BzbEFzS3Zx?= =?utf-8?B?VWFYdjB2OWdaNEM1ZTRHWndnc1BJNzlFUTZoZ3ArdUI5ZWtVdlF6NzhRcUYx?= =?utf-8?B?RW1zU3oyNitoazlrclJ5Ky9lTnhwR0g2eUNtSnJkWDcvUmUwajlsdjY5b2hV?= =?utf-8?B?SmNSU24rMm42QTJqZ2l3ZUVJOXl5L09odWJHdjRVTlhheFdOSUZTQ1cvcm5j?= =?utf-8?B?ZEE3WkpGSmduQ05Za0dtTWFXVVlVQW05ZWdTdTV3S3FPU25WUGhSQ2JJSFg4?= =?utf-8?B?OU9CT2Z4WnArOWVWbC9KWkxPdHFJaXBJR0Ntbk5KTWcySEZuY1pIOSs4aDd4?= =?utf-8?B?MFh4SHdjYjhtYnR5UlNJVEtwYWtSVjY0YW5INTQwRVB3MHhSSThJZXBnL2JX?= =?utf-8?B?MXZaMmVidlNFUCtYVGxMN3ptZ28wajNTS1VtclFpQ1hpZjZoYTAvRDZ4Z1N1?= =?utf-8?B?MTBDNnZoTjhXaHAvVzVYS1BSM0JiY1gvNnYwMFhKdFRqYmtBSTJkM1NDSEhY?= =?utf-8?B?TWk3aXpOYzV2SzNmamZVZlVibVV1RVgxb0xDOFZzR25haHZ1OW9QTXlsdVpj?= =?utf-8?B?YmZzSEVjbERrcXdoL0FjejA4aTZYWTB4NzBHVWp4K2VJdWpjNDJpSXFlMlpX?= =?utf-8?B?RkN5NTBpb3JvS0hxUkhIZkRJVjRpZGhaZ0hKTk91L1lqYlkyMEJVY1pTVmpO?= =?utf-8?B?d3FJdG5OR3dldkdZQUwrUlliMlc0eU5YOEpLdlpvYStTQzgxTXd5RVB4bUhY?= =?utf-8?B?L1lERGp4YlR1UWY2dFpEdmgyY083a0Izb3owanhIK1lVaS9kdWdENGM1UVgw?= =?utf-8?B?WjRjcmtrZXR4UTMyOW9ZVHZWSk9oQ0hxMkNaS3NkUHg4MWlUdDJNVTloYXp2?= =?utf-8?B?WEtIZDJnNUlCaisyMldISlFmYW1YQ0ZmcEVaeWpPL3JMbWptV3hTL28rOVMx?= =?utf-8?B?MytQOW5Nc2M0R3d6RUJjeGdTTmY2TTZwMk5vNXA2ZHM5cjI0YmhIcmJkZjEw?= =?utf-8?B?d0lSVDhmd2FnSHV6MzZVS3RpdzRONmR4TjVXd1lmK3VRRXBkNDhVN2cwcENF?= =?utf-8?B?YU1Id3RwMjZLRFBid0FtM2JTVklmY2krTERHN2w2ZHFLZVUxZzZJUlJMb2tl?= =?utf-8?B?cy9xbUVjc0xEWmF4NFFoQVUvVzZYR0FXZzlSdjB3VXpROUJFYVdIbU5jemRJ?= =?utf-8?B?eFh1ZFF0b0VxWHJFeXM1a3RuQm8yR0xpRkEyNGNPSmU5MzU1eFVlU2pCRlFv?= =?utf-8?B?L1VvNDFyTHBEMlBhQjRhaHl6OWtFRDVMVWJkSGt2WkhWd0hpVEV5SDZLN1Ny?= =?utf-8?B?TUN1cnoxTlU3UExEK0s1Sk1iNmV3UDIxemwwV1ZLWHYvTUk0SVU1YWJuUjhu?= =?utf-8?B?M1hTSjAvZng3Sm9tWWtKaXVIRUtyMXBvMFplaDU3aFN4Zzgva2phdnFncXh0?= =?utf-8?B?VlFlV29PMjVQN3doeW5FckNXZEdzOHVJUFdVR3ZXQWEwQlVNZmJVdGRNMGNU?= =?utf-8?B?TDd4bk9FRWZqZGxycTgvR004TEdrSWRUSjJKdWdmc0dsMkJtdXNmQmp3V0tR?= =?utf-8?B?WHRsZENpQWRHWVQ2eHdPNk8yZmZ2ekRoQU90eEJhNUVOa3FTM1o4VndLQ0xn?= =?utf-8?B?TG1pckNxcitrRUt5OWxQMEpWRWdXMW9SUUJPZTFicnZBamNQU2ZrcW0zWmh3?= =?utf-8?B?K214dmM4ZEludVVkWDNkQzdKdGo2aGwxR3RGS0ZvNTNsZEVWbVlBa2JPRWdM?= =?utf-8?B?a2NDa2pUWndDT2x3cUZKc2Jqdi9vR3hQVWhYVzkxNlJlZko1SWI1cEF3K2xk?= =?utf-8?B?ZDhUOU9MWkJmVzM1SW9vSGRNVnNieElMRCs2OUw3REdUSHRneUZnZUI3VVEz?= =?utf-8?Q?k3hxqHnEr+kfnT3Qxfo70gLXK?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b338e368-28d5-41aa-657b-08daf89d793f X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 15:14:05.8295 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FjGI90UZVTwmdFUNpAMb3Rs08Yh7k9ZFnoameRS41fQ0lL+o7qPn/Fv7qf4UmE0M X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5060 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 11/14/2022 11:59 AM, Rongwei Liu wrote: > In case flow rules match only one kind of traffic in a flow table, > then optimization can be done via allocation of this table. > Such optimization is possible only if the application gives a hint > about its usage of the table during initial configuration. > > The transfer domain rules may process traffic from wire or vport, > which may correspond to two kinds of underlayer resources. > That's why the first two hints introduced in this patch are about > wire and vport traffic specialization. > Wire means traffic arrives from the uplink port while vport means > traffic initiated from VF/SF. > > There are two possible approaches for providing the hints. > Using IPv4 as an example: > 1. Use pattern item in both template table and flow rules. > > pattern_template: pattern ANY_VPORT / eth / ipv4 is 1.1.1.1 / end > async flow create: pattern ANY_VPORT / eth / ipv4 is 1.1.1.2 / end > > "ANY_VPORT" needs to be present in each flow rule even if it's > just a hint. No value to match because matching is already done by > IPv4 item. > > 2. Add special flags into table_attr. > > template_table 0 create table_id 0 group 1 transfer vport_orig > > Approach 1 needs to specify the pattern in each flow rule which wastes > memory and is not user friendly. > This patch takes the 2nd approach and introduces one new member > "specialize" into rte_flow_table_attr to indicate possible flow table > optimization. > > By default, there is no hint, so the behavior of the transfer domain > doesn't change. > There is no guarantee that the hint will be used by the PMD. > > Signed-off-by: Rongwei Liu <rongweil@nvidia.com> > Acked-by: Ori Kam <orika@nvidia.com> Hi Andrew, Ivan, Do you have objection/comment to latest version, if not I will proceed with patch? Thanks, ferruh