From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 30DCB4570F;
	Thu,  1 Aug 2024 10:43:49 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B6DFE402C8;
	Thu,  1 Aug 2024 10:43:48 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id 029244014F
 for <dev@dpdk.org>; Thu,  1 Aug 2024 10:43:46 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D9FC91063;
 Thu,  1 Aug 2024 01:44:11 -0700 (PDT)
Received: from [10.1.38.17] (JR4XG4HTQC.cambridge.arm.com [10.1.38.17])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AA1AA3F766;
 Thu,  1 Aug 2024 01:43:44 -0700 (PDT)
Message-ID: <e41ac947-5a44-46df-971f-5350146d95e8@arm.com>
Date: Thu, 1 Aug 2024 09:43:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/1] dts: add text parser for testpmd verbose output
Content-Language: en-GB
To: Jeremy Spewock <jspewock@iol.unh.edu>, yoan.picchi@foss.arm.com,
 probb@iol.unh.edu, paul.szczepanek@arm.com, npratte@iol.unh.edu,
 thomas@monjalon.net, Honnappa.Nagarahalli@arm.com,
 juraj.linkes@pantheon.tech, wathsala.vithanage@arm.com
Cc: dev@dpdk.org
References: <20240729203955.267942-1-jspewock@iol.unh.edu>
 <20240730133459.21907-1-jspewock@iol.unh.edu>
 <20240730133459.21907-2-jspewock@iol.unh.edu>
 <CAAA20URJ2XceoywxWLe5ur05oALu1Lsoma1tcsYB1UnhDYEEcA@mail.gmail.com>
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
In-Reply-To: <CAAA20URJ2XceoywxWLe5ur05oALu1Lsoma1tcsYB1UnhDYEEcA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 30/07/2024 22:33, Jeremy Spewock wrote:
> On Tue, Jul 30, 2024 at 9:37 AM <jspewock@iol.unh.edu> wrote:
> <snip>
>> +class VerboseOLFlag(Flag):
>> +    """Flag representing the OL flags of a packet from Testpmd verbose output."""
>> +
>> +    #:
>> +    RTE_MBUF_F_RX_RSS_HASH = auto()
>> +
>> +    #:
>> +    RTE_MBUF_F_RX_L4_CKSUM_GOOD = auto()
>> +    #:
>> +    RTE_MBUF_F_RX_L4_CKSUM_BAD = auto()
>> +    #:
>> +    RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN = auto()
>> +
>> +    #:
>> +    RTE_MBUF_F_RX_IP_CKSUM_GOOD = auto()
>> +    #:
>> +    RTE_MBUF_F_RX_IP_CKSUM_BAD = auto()
>> +    #:
>> +    RTE_MBUF_F_RX_IP_CKSUM_UNKNOWN = auto()
>> +
>> +    #:
>> +    RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD = auto()
>> +    #:
>> +    RTE_MBUF_F_RX_OUTER_L4_CKSUM_BAD = auto()
>> +    #:
>> +    RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN = auto()
>> +
> After reading more of the API and using this patch to write a test
> suite, I believe there is more expansion of these OL flags that should
> take place. For starters, there are the Tx OL flags that, while not
> seeming to be very useful for the current test suites we are writing,
> wouldn't hurt to also include as they seem to be fairly different.
> Additionally, there are some other less common RX OL flags that should
> be included here just to cover all options. I will work on adding
> these into the next version.

If you wanted to cover even more, hw_ptype and sw_ptype look like they 
could use a data structure. I reckon a flag like the above would also work.