From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CBB6A034F; Mon, 29 Mar 2021 12:53:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12AC340151; Mon, 29 Mar 2021 12:53:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id D8DDA40042 for ; Mon, 29 Mar 2021 12:53:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617015180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=buHld6WsqJkkfCwd31cWhSb4H/mv5ougAw89nywY0OM=; b=ZUA5l/7/ZVdqatul/INY+YBjfz6cIcR6f+hLfAvcRdVynxtRkLHJNKDDjWGSBgZfYIarHc S2oW0FCrGD7gmwshZ8eZca7UmZYhKg0Sv/B2JamfiVAoxslXRLkaxxSGe6c7X5cZhAAw2b erb4D3R3j8RFJzr1rl8HLwGMyVx+6Ok= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-591-21cistJWOw2IN1Z58NoBvQ-1; Mon, 29 Mar 2021 06:52:58 -0400 X-MC-Unique: 21cistJWOw2IN1Z58NoBvQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EED4C8018AD; Mon, 29 Mar 2021 10:52:56 +0000 (UTC) Received: from bnemeth.users.ipa.redhat.com (ovpn-114-82.ams2.redhat.com [10.36.114.82]) by smtp.corp.redhat.com (Postfix) with ESMTP id 10BBE6A8FA; Mon, 29 Mar 2021 10:52:48 +0000 (UTC) Message-ID: From: Balazs Nemeth To: David Marchand , Maxime Coquelin Cc: dev , "Xia, Chenbo" , Adrian Moreno Zapata , Olivier Matz Date: Mon, 29 Mar 2021 12:52:47 +0200 In-Reply-To: References: <20210323090219.126712-1-maxime.coquelin@redhat.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=bnemeth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 0/3] vhost: make virtqueue cache-friendly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 2021-03-23 at 11:30 +0100, David Marchand wrote: > On Tue, Mar 23, 2021 at 10:02 AM Maxime Coquelin > wrote: > > > > As done for Virtio PMD, this series improves cache utilization > > of the vhost_virtqueue struct by removing unused field, > > make the live-migration cache dynamically allocated at > > live-migration setup time and by moving fields > > around so that hot fields are on the first cachelines. > > > > With this series, The struct vhost_virtqueue size goes > > from 832B (13 cachelines) down to 320B (5 cachelines). > > > > With this series and the virtio one, I measure a gain > > of up to 8% in IO loop micro-benchmark with packed > > ring, and 5% with split ring. > > > > I don't have a setup at hand to run PVP testing, but > > it might be interresting to get the numbers as I > > suspect the cache pressure is higher in this test as > > in real use-cases. > > > > Changes in v4: > > ============== > > - Fix missing changes to boolean (Chenbo) > > > > For the series, > Reviewed-by: David Marchand > > Merci ! > > Tested this in a PVP setup on ARM, giving a slight improvement in performance. For the series: Tested-by: Balazs Nemeth