From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 10C8AA0540;
Wed, 6 Jul 2022 17:38:50 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id A276140687;
Wed, 6 Jul 2022 17:38:49 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mails.dpdk.org (Postfix) with ESMTP id 541BF40156
for <dev@dpdk.org>; Wed, 6 Jul 2022 17:38:48 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1657121927;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=x+Qaoe+Zze1VVXFpmpoybczWS6//B9Ttny+E+hMPv+Q=;
b=XNpQMVHtX3uZ3zw6HUdFybY15mWbouUU9gdBsKgEORgyyR6sZ7Y41D/0gTT+2L0CtmAHoK
XCrAd+E+KrLqM6xla2p59Y1oZO1OGuG1B7MucqmHsoee5NYG+7jkt4daBUEREbiY7xOG8E
vv5ACxUNwJ2xt7hd0a7j4Yxw9dPcBXQ=
Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com
[209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
us-mta-589-_Sk3IIS7P-GypHpmO00lag-1; Wed, 06 Jul 2022 11:38:44 -0400
X-MC-Unique: _Sk3IIS7P-GypHpmO00lag-1
Received: by mail-qt1-f197.google.com with SMTP id
w42-20020a05622a192a00b0031d3a51eac8so12527422qtc.9
for <dev@dpdk.org>; Wed, 06 Jul 2022 08:38:44 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:subject:to:cc:references:from:message-id:date
:user-agent:mime-version:in-reply-to:content-transfer-encoding
:content-language;
bh=x+Qaoe+Zze1VVXFpmpoybczWS6//B9Ttny+E+hMPv+Q=;
b=vXQmq0h+mllwcGGpNwf4jeSJMRJqZ5WHJg/IGkg/igWiyfNFIJQC3u2ZVAegQexy2Y
z7Eu3cp+wEW05t3u450AYem/vCuJioT6mX9mSEilWtMask9vxtmFCRMVFmwYvI2rY1kF
mGrffuQXCb6ESHPiMVQIZfoRg4ZHQI8mLYgVwd8Hupg44jQSZu6C++YZGASCuqeEltlr
7dEXQedy4RZBlPEUTXA42RyfY2sQgQXAizeCzW+nIOzJ8YbqMn5YCvBe9gswn/3kxOGR
CtXiHa4oLjtaqT5MIXbtEd8gy9kF9uczl3aJksuNJKo/klv++9oMR3ViIeJe8W7vbWZw
D3bQ==
X-Gm-Message-State: AJIora8tJk12nol6NzkAEzfwi47IBA1e9CBKoWwkkntm0PuyNe9JbtKI
CbobQWSfM/1TC7FLeS5Dphc3CyyNx9X7RZwA3gF+LIvztR930B1ymzR2j3uGGbN3HS5f5kON2pB
Hxd8=
X-Received: by 2002:a05:622a:1114:b0:31a:b237:c1ec with SMTP id
e20-20020a05622a111400b0031ab237c1ecmr33454640qty.141.1657121924019;
Wed, 06 Jul 2022 08:38:44 -0700 (PDT)
X-Google-Smtp-Source: AGRyM1sxUhaRjMXc/mznyxHwpFtHIXoppAd03Y2do8gHUgbEe8LJg/Bm/ITOBIH5HAymCX8ZgLjxAg==
X-Received: by 2002:a05:622a:1114:b0:31a:b237:c1ec with SMTP id
e20-20020a05622a111400b0031ab237c1ecmr33454613qty.141.1657121923743;
Wed, 06 Jul 2022 08:38:43 -0700 (PDT)
Received: from localhost.localdomain (024-205-208-113.res.spectrum.com.
[24.205.208.113]) by smtp.gmail.com with ESMTPSA id
g11-20020ac8480b000000b003051ba1f8bcsm23874303qtq.15.2022.07.06.08.38.41
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Wed, 06 Jul 2022 08:38:43 -0700 (PDT)
Subject: Re: [PATCH v4 2/7] bbdev: add device status info
To: Nicolas Chautru <nicolas.chautru@intel.com>, dev@dpdk.org,
thomas@monjalon.net, gakhil@marvell.com, hemant.agrawal@nxp.com
Cc: maxime.coquelin@redhat.com, mdr@ashroe.eu, bruce.richardson@intel.com,
david.marchand@redhat.com, stephen@networkplumber.org
References: <1655491040-183649-6-git-send-email-nicolas.chautru@intel.com>
<1657067022-54373-1-git-send-email-nicolas.chautru@intel.com>
<1657067022-54373-3-git-send-email-nicolas.chautru@intel.com>
From: Tom Rix <trix@redhat.com>
Message-ID: <e42f9b9a-39f3-8958-37cf-49a892f6b371@redhat.com>
Date: Wed, 6 Jul 2022 08:38:40 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <1657067022-54373-3-git-send-email-nicolas.chautru@intel.com>
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On 7/5/22 5:23 PM, Nicolas Chautru wrote:
> Added device status information, so that the PMD can
> expose information related to the underlying accelerator device status.
> Minor order change in structure to fit into padding hole.
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
> drivers/baseband/acc100/rte_acc100_pmd.c | 1 +
> drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 1 +
> drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 1 +
> drivers/baseband/la12xx/bbdev_la12xx.c | 1 +
> drivers/baseband/null/bbdev_null.c | 1 +
> drivers/baseband/turbo_sw/bbdev_turbo_software.c | 1 +
> lib/bbdev/rte_bbdev.c | 24 +++++++++++++++
> lib/bbdev/rte_bbdev.h | 35 ++++++++++++++++++++--
> lib/bbdev/version.map | 6 ++++
> 9 files changed, 69 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
> index de7e4bc..17ba798 100644
> --- a/drivers/baseband/acc100/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc100/rte_acc100_pmd.c
> @@ -1060,6 +1060,7 @@
>
> /* Read and save the populated config from ACC100 registers */
> fetch_acc100_config(dev);
> + dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
>
> /* This isn't ideal because it reports the maximum number of queues but
> * does not provide info on how many can be uplink/downlink or different
> diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> index 82ae6ba..57b12af 100644
> --- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> +++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> @@ -369,6 +369,7 @@
> dev_info->capabilities = bbdev_capabilities;
> dev_info->cpu_flag_reqs = NULL;
> dev_info->data_endianness = RTE_LITTLE_ENDIAN;
> + dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
>
> /* Calculates number of queues assigned to device */
> dev_info->max_num_queues = 0;
> diff --git a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
> index 21d3529..2a330c4 100644
> --- a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
> +++ b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
> @@ -645,6 +645,7 @@ struct __rte_cache_aligned fpga_queue {
> dev_info->capabilities = bbdev_capabilities;
> dev_info->cpu_flag_reqs = NULL;
> dev_info->data_endianness = RTE_LITTLE_ENDIAN;
> + dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
>
> /* Calculates number of queues assigned to device */
> dev_info->max_num_queues = 0;
> diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/drivers/baseband/la12xx/bbdev_la12xx.c
> index 4d1bd16..c1f88c6 100644
> --- a/drivers/baseband/la12xx/bbdev_la12xx.c
> +++ b/drivers/baseband/la12xx/bbdev_la12xx.c
> @@ -100,6 +100,7 @@ struct bbdev_la12xx_params {
> dev_info->capabilities = bbdev_capabilities;
> dev_info->cpu_flag_reqs = NULL;
> dev_info->min_alignment = 64;
> + dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
>
> rte_bbdev_log_debug("got device info from %u", dev->data->dev_id);
> }
> diff --git a/drivers/baseband/null/bbdev_null.c b/drivers/baseband/null/bbdev_null.c
> index 248e129..94a1976 100644
> --- a/drivers/baseband/null/bbdev_null.c
> +++ b/drivers/baseband/null/bbdev_null.c
> @@ -82,6 +82,7 @@ struct bbdev_queue {
> * here for code completeness.
> */
> dev_info->data_endianness = RTE_LITTLE_ENDIAN;
> + dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
>
> rte_bbdev_log_debug("got device info from %u", dev->data->dev_id);
> }
> diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> index af7bc41..dbc5524 100644
> --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> @@ -254,6 +254,7 @@ struct turbo_sw_queue {
> dev_info->min_alignment = 64;
> dev_info->harq_buffer_size = 0;
> dev_info->data_endianness = RTE_LITTLE_ENDIAN;
> + dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED;
>
> rte_bbdev_log_debug("got device info from %u\n", dev->data->dev_id);
> }
> diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c
> index 22bd894..555bda9 100644
> --- a/lib/bbdev/rte_bbdev.c
> +++ b/lib/bbdev/rte_bbdev.c
> @@ -25,6 +25,8 @@
>
> /* Number of supported operation types */
> #define BBDEV_OP_TYPE_COUNT 5
> +/* Number of supported device status */
> +#define BBDEV_DEV_STATUS_COUNT 9
>
> /* BBDev library logging ID */
> RTE_LOG_REGISTER_DEFAULT(bbdev_logtype, NOTICE);
> @@ -1132,3 +1134,25 @@ struct rte_mempool *
> rte_bbdev_log(ERR, "Invalid operation type");
> return NULL;
> }
> +
> +const char *
> +rte_bbdev_device_status_str(enum rte_bbdev_device_status status)
> +{
> + static const char * const dev_sta_string[] = {
> + "RTE_BBDEV_DEV_NOSTATUS",
> + "RTE_BBDEV_DEV_NOT_SUPPORTED",
> + "RTE_BBDEV_DEV_RESET",
> + "RTE_BBDEV_DEV_CONFIGURED",
> + "RTE_BBDEV_DEV_ACTIVE",
> + "RTE_BBDEV_DEV_FATAL_ERR",
> + "RTE_BBDEV_DEV_RESTART_REQ",
> + "RTE_BBDEV_DEV_RECONFIG_REQ",
> + "RTE_BBDEV_DEV_CORRECT_ERR",
> + };
> +
> + if (status < BBDEV_DEV_STATUS_COUNT)
> + return dev_sta_string[status];
> +
> + rte_bbdev_log(ERR, "Invalid device status");
> + return NULL;
> +}
> diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h
> index b88c881..9b1ffa4 100644
> --- a/lib/bbdev/rte_bbdev.h
> +++ b/lib/bbdev/rte_bbdev.h
> @@ -223,6 +223,21 @@ struct rte_bbdev_queue_conf {
> int
> rte_bbdev_queue_stop(uint16_t dev_id, uint16_t queue_id);
>
> +/**
> + * Flags indicate the status of the device
> + */
> +enum rte_bbdev_device_status {
> + RTE_BBDEV_DEV_NOSTATUS, /**< Nothing being reported */
> + RTE_BBDEV_DEV_NOT_SUPPORTED, /**< Device status is not supported on the PMD */
If this was 0, you may not need to explicitly set.
> + RTE_BBDEV_DEV_RESET, /**< Device in reset and un-configured state */
> + RTE_BBDEV_DEV_CONFIGURED, /**< Device is configured and ready to use */
> + RTE_BBDEV_DEV_ACTIVE, /**< Device is configured and VF is being used */
> + RTE_BBDEV_DEV_FATAL_ERR, /**< Device has hit a fatal uncorrectable error */
> + RTE_BBDEV_DEV_RESTART_REQ, /**< Device requires application to restart */
> + RTE_BBDEV_DEV_RECONFIG_REQ, /**< Device requires application to reconfigure queues */
> + RTE_BBDEV_DEV_CORRECT_ERR, /**< Warning of a correctable error event happened */
Last patch was padded, do something consistent here.
> +};
> +
> /** Device statistics. */
> struct rte_bbdev_stats {
> uint64_t enqueued_count; /**< Count of all operations enqueued */
> @@ -285,12 +300,14 @@ struct rte_bbdev_driver_info {
> /** Set if device supports per-queue interrupts */
> bool queue_intr_supported;
> /** Minimum alignment of buffers, in bytes */
> - uint16_t min_alignment;
> - /** HARQ memory available in kB */
> + /** Device Status */
> + enum rte_bbdev_device_status device_status;
New elements should be added to the end to improve backward compatibility.
Tom
> uint32_t harq_buffer_size;
> /** Byte endianness (RTE_BIG_ENDIAN/RTE_LITTLE_ENDIAN) supported
> * for input/output data
> */
> + uint16_t min_alignment;
> + /** HARQ memory available in kB */
> uint8_t data_endianness;
> /** Default queue configuration used if none is supplied */
> struct rte_bbdev_queue_conf default_queue_conf;
> @@ -827,6 +844,20 @@ typedef void (*rte_bbdev_cb_fn)(uint16_t dev_id,
> rte_bbdev_queue_intr_ctl(uint16_t dev_id, uint16_t queue_id, int epfd, int op,
> void *data);
>
> +/**
> + * Converts device status from enum to string
> + *
> + * @param status
> + * Device status as enum
> + *
> + * @returns
> + * Operation type as string or NULL if op_type is invalid
> + *
> + */
> +__rte_experimental
> +const char*
> +rte_bbdev_device_status_str(enum rte_bbdev_device_status status);
> +
> #ifdef __cplusplus
> }
> #endif
> diff --git a/lib/bbdev/version.map b/lib/bbdev/version.map
> index cce3f3c..9ac3643 100644
> --- a/lib/bbdev/version.map
> +++ b/lib/bbdev/version.map
> @@ -39,3 +39,9 @@ DPDK_22 {
>
> local: *;
> };
> +
> +EXPERIMENTAL {
> + global:
> +
> + rte_bbdev_device_status_str;
> +};