From: Akhil Goyal <akhil.goyal@nxp.com>
To: "Verma, Shally" <Shally.Verma@cavium.com>,
"Saxena, Akash" <Akash.Saxena@cavium.com>,
"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Verma, Ayuj" <Ayuj.Verma@cavium.com>
Subject: Re: [dpdk-dev] [PATCH v1 2/2] test/crypto: remove data verification at rsa verify operation
Date: Wed, 24 Oct 2018 13:09:41 +0000 [thread overview]
Message-ID: <e441561d-68f7-dabf-d571-a51bba7c2ba1@nxp.com> (raw)
In-Reply-To: <SN6PR07MB5152E5D83D7DFB411EDADA86F0F40@SN6PR07MB5152.namprd07.prod.outlook.com>
>>> @@ -153,10 +153,13 @@ test_rsa_sign_verify(void)
>>> goto error_exit;
>>> }
>>> status = TEST_SUCCESS;
>>> - int ret = 0;
>>> - ret = rsa_verify(&rsaplaintext, result_op);
>>> - if (ret)
>>> + if (result_op->status != RTE_CRYPTO_OP_STATUS_SUCCESS) {
>>> + RTE_LOG(ERR, USER1,
>>> + "line %u FAILED: %s",
>>> + __LINE__, "Failed to process asym crypto op");
>>> status = TEST_FAILED;
>>> + goto error_exit;
>>> + }
>>>
>>> error_exit:
>>>
>> What about test_rsa_enc_dec? Do you need to remove verify from that as well?
> No. in case of enc_dec, PMD just return decrypted o/p so, app need to do cross-verify data.
> In case of RSA_VERIFY OP PMD internally does memcmp of plaintext to decrypted o/p and ensure
> Pass / fail. So, doing it again at app level is redundant.
Ok
> Thanks
> Shally
prev parent reply other threads:[~2018-10-24 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 13:43 [dpdk-dev] [PATCH v1 0/2] Changes for RSA verify operation in OpenSSL PMD and unit tests Akash Saxena
2018-10-11 13:43 ` [dpdk-dev] [PATCH v1 1/2] crypto/openssl: changes for RSA verify operation Akash Saxena
2018-10-16 13:15 ` Akhil Goyal
2018-10-16 13:17 ` Akhil Goyal
2018-10-11 13:43 ` [dpdk-dev] [PATCH v1 2/2] test/crypto: remove data verification at rsa " Akash Saxena
2018-10-16 13:21 ` Akhil Goyal
2018-10-22 12:29 ` Verma, Shally
2018-10-24 13:09 ` Akhil Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e441561d-68f7-dabf-d571-a51bba7c2ba1@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=Akash.Saxena@cavium.com \
--cc=Ayuj.Verma@cavium.com \
--cc=Shally.Verma@cavium.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).