From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 96D83324D for ; Tue, 26 Feb 2019 18:50:01 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id e74so3273438wmg.3 for ; Tue, 26 Feb 2019 09:50:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=O4ciNRK58An8jcUmjg/5l1HgeeswXEoM7ROEZIUrFcI=; b=MoM0B7aEezdJjBEA3ay5fPNcejTK6t7AjxOsNZxo7VhndXkjR7zIZQKH7ReVrYbul8 ec4eWowXj1AqiIWlmft9qNhL1AUb1waDYf31sX5vo1FJ6HCr/lzCLfelYLssJCvQT4jY QtETZwpLf+/0ya+0lAyMZZT5m3cDcdpwhDEJn83rQCTHeX+E1wRYPu90gXaQBrzX8uVT lJcHoA1uU0viGPp6ZCPNiCT6wXZcV/fxgHDEizy9y4W90yQZZgEidE0KjWixSNQhHcGX bfYru4FWX9YO5ZBRAqqvmj2scUIfXLq7YtzcKUd7ubUrbiPYnhGnCHvA9JWOb5hKOrOl cbSw== X-Gm-Message-State: AHQUAubek8nrer8IoMkERNvEIQ9+0oShV+gzq7s9IMKETUByRZr/IhJv pbIpTXdz8tAH/MSOIBcJECLAQr/iGHA= X-Google-Smtp-Source: AHgI3Ibz3knq7wNx6+z5SWsB3NpRumft5sbzh/E+Xgc1tmxpz3igLAlPXCEI03FoRP3nZDcz5VXQTQ== X-Received: by 2002:a05:600c:2:: with SMTP id g2mr3439222wmc.109.1551203400833; Tue, 26 Feb 2019 09:50:00 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:b00c:66c8:99df:336]) by smtp.gmail.com with ESMTPSA id v196sm106563wmf.15.2019.02.26.09.50.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Feb 2019 09:50:00 -0800 (PST) Message-ID: From: Luca Boccassi To: dev@dpdk.org Cc: bruce.richardson@intel.com, thomas@monjalon.net Date: Tue, 26 Feb 2019 17:49:59 +0000 In-Reply-To: <20190226174637.27452-6-luca.boccassi@gmail.com> References: <20190103175725.5836-1-bluca@debian.org> <20190226174637.27452-1-luca.boccassi@gmail.com> <20190226174637.27452-6-luca.boccassi@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 17:50:01 -0000 On Tue, 2019-02-26 at 17:46 +0000, luca.boccassi@gmail.com wrote: > From: Luca Boccassi >=20 > pcap has historically shipped a custom pcap-config binary tool which > does the job of pkg-config. It was never compatible with cross > compilation. > Meson uses it when using dependency(), which then means cross > compilation fails. > Set pcap-config to empty in the meson cross compilation files so > that Meson will not use it, and add a fallback in case > dependency() fails. > libpcap 1.9.0 finally ships a pkg-config file so everything will > work out of the box in the future. >=20 > Signed-off-by: Luca Boccassi > --- > v8: added back pcap change separately. Tested with bootlin > cross-compilation toolchain, everything seems to work. I had some time to invest so I added back this change, in a way that works with cross compilation too. Given the series wasn't merged yet and there was a conflict I've done a v8 rather than a single separate patch, but it's independent from the rest. More testing is of course welcome! --=20 Kind regards, Luca Boccassi