Re: [dpdk-dev] [PATCH] build: list symbols exports in a single file

["Kinsella, Ray" <mdr@ashroe.eu>]

On 06/04/2021 17:50, Bruce Richardson wrote:
> On Tue, Apr 06, 2021 at 06:32:30PM +0200, David Marchand wrote:
>> Rather than have two files that keeps getting out of sync, let's
>> annotate the version.map to generate the Windows export file.
>>
>> Note: EAL version.map annotation achieved with:
>> $ ./buildtools/map-list-symbol.sh lib/librte_eal/version.map |
>>   while read file version sym; do
>>     ! git grep -qw $sym lib/librte_eal/*.def || continue;
>>     sed -i -e "s/$sym;/$sym; # WINDOWS_NO_EXPORT/" lib/librte_eal/*.map;
>>   done
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>> ---
> +1 to the idea, this is great to see.

+1 agreed.
> 
>>  MAINTAINERS                        |   1 -
>>  buildtools/map_to_win.py           |   8 +-
>>  devtools/check-symbol-maps.sh      |  20 --
>>  lib/librte_eal/rte_eal_exports.def | 336 -----------------------------
>>  lib/librte_eal/version.map         | 136 ++++++------
>>  5 files changed, 69 insertions(+), 432 deletions(-)
>>  delete mode 100644 lib/librte_eal/rte_eal_exports.def
>>
> <snip>  
>> -# special case, allow override if an def file already exists alongside map file
>> -    override_file = join(dirname(args[1]), basename(args[2]))
>> -    if exists(override_file):
>> -        with open(override_file) as f_in:
>> -            functions = f_in.readlines()
>> -
> 
> If this is removed, then drivers/common/mlx5/version.map similarly needs to
> be annotated so that we can remove rte_common_mlx5_exports.def
>