From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC1EBA0A0F; Wed, 7 Apr 2021 22:06:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D72F140F2E; Wed, 7 Apr 2021 22:06:40 +0200 (CEST) Received: from dal2relay4.mxroute.com (dal2relay4.mxroute.com [64.40.26.4]) by mails.dpdk.org (Postfix) with ESMTP id 114A2140F29 for ; Wed, 7 Apr 2021 22:06:37 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by dal2relay4.mxroute.com (ZoneMTA) with ESMTPSA id 178adf18f50000a323.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Wed, 07 Apr 2021 20:06:32 +0000 X-Zone-Loop: 7a19e4e4995ab0ec82554883c016b9bb41da0b7863bb X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BosIF3oGEQUfW6mn+TjoMCx4yGL813dPqNEGaCmiias=; b=QiSPxl46YNxkU7DeUfy7uTGTt+ TgHasyMWPMi6Ue6+6UxcW1PviwwO6gRATGoaGeDlUzevFFqvvsWHrq7AamOXkwn/GZDD3o5M2IYDl Xj8Yjn9nP0MnxDgXqs4DF8s0qeWDZ8VHat+gAza4TnbRfdgNgQrGdfXUCnGO13+mJLGXojTtfC+Gc cl4e/lQoRmpVUAn8uAcbn4fmsEUSsGM0FBub4ZPOtuw0tTfZSk26b0H6m8/WQeisNwQWdp4CCaGL1 NdmA1BySmDQQ+KLUTMWpAJPyzc/q+4OxIQjSvGU5b/dJvhm93bTU+tdh34WFn680YKKl7UrIm86IC Tai+6kng==; To: Bruce Richardson , David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Neil Horman References: <20210406163231.19663-1-david.marchand@redhat.com> <20210406165058.GD551@bricha3-MOBL.ger.corp.intel.com> From: "Kinsella, Ray" Message-ID: Date: Wed, 7 Apr 2021 21:06:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210406165058.GD551@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH] build: list symbols exports in a single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/04/2021 17:50, Bruce Richardson wrote: > On Tue, Apr 06, 2021 at 06:32:30PM +0200, David Marchand wrote: >> Rather than have two files that keeps getting out of sync, let's >> annotate the version.map to generate the Windows export file. >> >> Note: EAL version.map annotation achieved with: >> $ ./buildtools/map-list-symbol.sh lib/librte_eal/version.map | >> while read file version sym; do >> ! git grep -qw $sym lib/librte_eal/*.def || continue; >> sed -i -e "s/$sym;/$sym; # WINDOWS_NO_EXPORT/" lib/librte_eal/*.map; >> done >> >> Signed-off-by: David Marchand >> --- > +1 to the idea, this is great to see. +1 agreed. > >> MAINTAINERS | 1 - >> buildtools/map_to_win.py | 8 +- >> devtools/check-symbol-maps.sh | 20 -- >> lib/librte_eal/rte_eal_exports.def | 336 ----------------------------- >> lib/librte_eal/version.map | 136 ++++++------ >> 5 files changed, 69 insertions(+), 432 deletions(-) >> delete mode 100644 lib/librte_eal/rte_eal_exports.def >> > >> -# special case, allow override if an def file already exists alongside map file >> - override_file = join(dirname(args[1]), basename(args[2])) >> - if exists(override_file): >> - with open(override_file) as f_in: >> - functions = f_in.readlines() >> - > > If this is removed, then drivers/common/mlx5/version.map similarly needs to > be annotated so that we can remove rte_common_mlx5_exports.def >