From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A588EA0547;
	Fri, 12 Mar 2021 09:25:58 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 27A20160842;
	Fri, 12 Mar 2021 09:25:58 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 231F54067E
 for <dev@dpdk.org>; Fri, 12 Mar 2021 09:25:56 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 693507F4DA;
 Fri, 12 Mar 2021 11:25:55 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 693507F4DA
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1615537555;
 bh=YooFRL7U7RHN+nq+sLDfYvJ8VtkmgxlV9yOFKdOB9QY=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=HiNJdcvU1BoyhtZuaVGXu38Piw5vU78tNlEiTHCziBeCRCM2D4c3nhVePNYirRLiB
 M0FeZrQ6W+mZqV2YkItJ5wcywXDWkSrwiPCROPYzGc8Wwq3+ALmGHhFnXp6N3muQbc
 SeGgifVw9GXb8SZi32gay/f9dZvpzdkhWcyl1dwU=
To: Thomas Monjalon <thomas@monjalon.net>,
 "Wang, Haiyue" <haiyue.wang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Ori Kam <orika@nvidia.com>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>,
 Somnath Kotur <somnath.kotur@broadcom.com>, Chas Williams <chas3@att.com>,
 "Min Hu (Connor)" <humin29@huawei.com>,
 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Sachin Saxena <sachin.saxena@oss.nxp.com>, "Guo, Jia" <jia.guo@intel.com>,
 "Daley, John" <johndale@cisco.com>, Hyong Youb Kim <hyonkim@cisco.com>,
 Gaetan Rivet <grive@u256.net>, Ziyang Xuan <xuanziyang2@huawei.com>,
 Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
 Guoyang Zhou <zhouguoyang@huawei.com>, Yisen Zhuang
 <yisen.zhuang@huawei.com>, Lijun Ou <oulijun@huawei.com>,
 "Xing, Beilei" <beilei.xing@intel.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>, "Yang, Qiming" <qiming.yang@intel.com>,
 "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Xu, Rosen" <rosen.xu@intel.com>,
 Matan Azrad <matan@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>,
 Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
 Liron Himi <lironh@marvell.com>, Jerin Jacob <jerinj@marvell.com>,
 Nithin Dabilpuram <ndabilpuram@marvell.com>,
 Kiran Kumar K <kirankumark@marvell.com>, Rasesh Mody <rmody@marvell.com>,
 Shahed Shaikh <shshaikh@marvell.com>,
 "Singh, Jasvinder" <jasvinder.singh@intel.com>,
 "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
 "Wiles, Keith" <keith.wiles@intel.com>, Jiawen Wu <jiawenwu@trustnetic.com>,
 Jian Wang <jianwang@trustnetic.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>
References: <20210311221742.3750589-1-thomas@monjalon.net>
 <20210311221742.3750589-2-thomas@monjalon.net>
 <BN8PR11MB3795C25359A52AA65D845147F76F9@BN8PR11MB3795.namprd11.prod.outlook.com>
 <323108562.jUxrqk0L7m@thomas>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <e45a8d08-b449-f4ad-6a24-7017552ebc96@oktetlabs.ru>
Date: Fri, 12 Mar 2021 11:25:55 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <323108562.jUxrqk0L7m@thomas>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: replace callback getting filter
 operations
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/12/21 11:22 AM, Thomas Monjalon wrote:
> 12/03/2021 02:44, Wang, Haiyue:
>> From: Thomas Monjalon <thomas@monjalon.net>
>>> -typedef int (*eth_filter_ctrl_t)(struct rte_eth_dev *dev,
>>> -				 enum rte_filter_type filter_type,
>>> -				 enum rte_filter_op filter_op,
>>> -				 void *arg);
>>> -/**< @internal Take operations to assigned filter type on an Ethernet device */
>>> +struct rte_flow_ops;
>>> +typedef int (*eth_flow_ops_get_t)(struct rte_eth_dev *dev,
>>> +				  const struct rte_flow_ops **ops);
>>> +/**< @internal Get flow operations */
>>>
>>
>> How about to change the return type to "const struct rte_flow_ops *" directly ?
>>
>> typedef const struct rte_flow_ops * (*eth_flow_ops_get_t)(struct rte_eth_dev *dev);
> 
> Not sure.
> Returning an int may allow different error codes.
> Any opinions?
> 

I would keep int return value. There is no point to optimize it
(make it simpler). It is called in just one place where
int return value may be used/forwarded (see my review notes).