From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36895A0C43; Fri, 22 Oct 2021 13:29:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F3454114A; Fri, 22 Oct 2021 13:29:17 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 21A2B41149 for ; Fri, 22 Oct 2021 13:29:16 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 7CB477F508; Fri, 22 Oct 2021 14:29:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 7CB477F508 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634902155; bh=0PKCslpu52NeKTPnd9DUlG8k6V/r+IW3hg1xycAMrw4=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=I74Eh5R711v1LJb39B+J+Q6v8GZKauL6+DlnSZ23mKIRbyndyLzORLcELPSTB2psR VV/OgCXx6SBoo2+ReSBKPmG3sFlXUurp9XjYjgKIRRdojK2j6CoHStPouvos7z2uWZ BxAN4QmFat1DBVXy0NLivEYN28Rkwpk1OjknAHnw= To: Ferruh Yigit , Thomas Monjalon Cc: Jerin Jacob , Xiaoyun Li , Ajit Khaparde , Somnath Kotur , Igor Russkikh , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Chas Williams , "Min Hu (Connor)" , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Yisen Zhuang , Lijun Ou , Beilei Xing , Jingjing Wu , Qiming Yang , Andrew Boyer , Rosen Xu , Matan Azrad , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Heinrich Kuhn , Harman Kalra , Nalla Pradeep , Radha Mohan Chintakuntla , Veerasenareddy Burru , Devendra Singh Rawat , Maciej Czekaj , Jiawen Wu , Jian Wang , Maxime Coquelin , Chenbo Xia , Yong Wang , Konstantin Ananyev , Radu Nicolau , Akhil Goyal , David Hunt , John McNamara , dev@dpdk.org, Huisong Li References: <20211001143624.3744505-1-ferruh.yigit@intel.com> <20211018134854.1258938-1-ferruh.yigit@intel.com> <20211018134854.1258938-4-ferruh.yigit@intel.com> <77848604.v7UaWOoZa8@thomas> <7bb6a3b3-2e0a-a762-fbc0-d908ced0fab3@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Fri, 22 Oct 2021 14:29:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <7bb6a3b3-2e0a-a762-fbc0-d908ced0fab3@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v7 4/6] ethdev: remove jumbo offload flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/22/21 2:25 PM, Ferruh Yigit wrote: > On 10/21/2021 1:43 AM, Thomas Monjalon wrote: >> 18/10/2021 15:48, Ferruh Yigit: >>> Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag. >> [...] >>> --- a/doc/guides/nics/features.rst >>> +++ b/doc/guides/nics/features.rst >>> @@ -165,8 +165,7 @@ Jumbo frame >>>     Supports Rx jumbo frames. >>>   -* **[uses]    rte_eth_rxconf,rte_eth_rxmode**: >>> ``offloads:DEV_RX_OFFLOAD_JUMBO_FRAME``. >>> -  ``dev_conf.rxmode.mtu``. >>> +* **[uses]    rte_eth_rxconf,rte_eth_rxmode**: ``dev_conf.rxmode.mtu``. >> >> So we keep announcing the feature "Jumbo frame" in the doc for MTU >> specific values? >> > > It is there mainly I missed to remove all, still it is an option to keep > feature > to let PMDs document capability, but since there is not flag/offload for > it, I > am for removing feature completely. +1