[dpdk-dev] [PATCH] net/vmxnet3: increase rx data ring descriptor size

[dpdk-dev] [PATCH] net/vmxnet3: increase rx data ring descriptor size

[Shraddha Joshi]

Vmxnet3 driver supports receive data ring viz. a set of small sized
buffers that are always mapped by the emulation. If a packet fits into
the receive data ring buffer, the emulation delivers the packet via the
receive data ring.

Increasing the receive data ring descriptor size from 128 to 256
showed performance gains as high as 5% for packets smaller than 256.

Signed-off-by: Shraddha Joshi <jshraddha@vmware.com>
Acked-by: Jin Heo <heoj@vmware.com>
Acked-by: Guolin Yang <gyang@vmware.com>
Acked-by: Boon Ang <bang@vmware.com>
---
 drivers/net/vmxnet3/vmxnet3_ring.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/vmxnet3/vmxnet3_ring.h b/drivers/net/vmxnet3/vmxnet3_ring.h
index 552180e84..50992349d 100644
--- a/drivers/net/vmxnet3/vmxnet3_ring.h
+++ b/drivers/net/vmxnet3/vmxnet3_ring.h
@@ -14,7 +14,7 @@
 #define VMXNET3_DEF_RX_RING_SIZE 128
 
 /* Default rx data ring desc size */
-#define VMXNET3_DEF_RXDATA_DESC_SIZE 128
+#define VMXNET3_DEF_RXDATA_DESC_SIZE 256
 
 #define VMXNET3_SUCCESS 0
 #define VMXNET3_FAIL   -1
-- 
2.11.0

Re: [dpdk-dev] [PATCH] net/vmxnet3: increase rx data ring descriptor size

[Yong Wang]

> -----Original Message-----
> From: Shraddha Joshi [mailto:jshraddha@vmware.com]
> Sent: Thursday, April 19, 2018 11:19 AM
> To: Yong Wang <yongwang@vmware.com>
> Cc: dev@dpdk.org; Shraddha Joshi <jshraddha@vmware.com>
> Subject: [PATCH] net/vmxnet3: increase rx data ring descriptor size
> 
> Vmxnet3 driver supports receive data ring viz. a set of small sized
> buffers that are always mapped by the emulation. If a packet fits into
> the receive data ring buffer, the emulation delivers the packet via the
> receive data ring.
> 
> Increasing the receive data ring descriptor size from 128 to 256
> showed performance gains as high as 5% for packets smaller than 256.
> 
> Signed-off-by: Shraddha Joshi <jshraddha@vmware.com>
> Acked-by: Jin Heo <heoj@vmware.com>
> Acked-by: Guolin Yang <gyang@vmware.com>
> Acked-by: Boon Ang <bang@vmware.com>

Acked-by: Yong Wang <yongwang@vmware.com>

> ---
>  drivers/net/vmxnet3/vmxnet3_ring.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_ring.h
> b/drivers/net/vmxnet3/vmxnet3_ring.h
> index 552180e84..50992349d 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ring.h
> +++ b/drivers/net/vmxnet3/vmxnet3_ring.h
> @@ -14,7 +14,7 @@
>  #define VMXNET3_DEF_RX_RING_SIZE 128
> 
>  /* Default rx data ring desc size */
> -#define VMXNET3_DEF_RXDATA_DESC_SIZE 128
> +#define VMXNET3_DEF_RXDATA_DESC_SIZE 256
> 
>  #define VMXNET3_SUCCESS 0
>  #define VMXNET3_FAIL   -1
> --
> 2.11.0

Re: [dpdk-dev] [PATCH] net/vmxnet3: increase rx data ring descriptor size

[Ferruh Yigit]

On 4/19/2018 10:54 PM, Yong Wang wrote:
>> -----Original Message-----
>> From: Shraddha Joshi [mailto:jshraddha@vmware.com]
>> Sent: Thursday, April 19, 2018 11:19 AM
>> To: Yong Wang <yongwang@vmware.com>
>> Cc: dev@dpdk.org; Shraddha Joshi <jshraddha@vmware.com>
>> Subject: [PATCH] net/vmxnet3: increase rx data ring descriptor size
>>
>> Vmxnet3 driver supports receive data ring viz. a set of small sized
>> buffers that are always mapped by the emulation. If a packet fits into
>> the receive data ring buffer, the emulation delivers the packet via the
>> receive data ring.
>>
>> Increasing the receive data ring descriptor size from 128 to 256
>> showed performance gains as high as 5% for packets smaller than 256.
>>
>> Signed-off-by: Shraddha Joshi <jshraddha@vmware.com>
>> Acked-by: Jin Heo <heoj@vmware.com>
>> Acked-by: Guolin Yang <gyang@vmware.com>
>> Acked-by: Boon Ang <bang@vmware.com>
> 
> Acked-by: Yong Wang <yongwang@vmware.com>

Applied to dpdk-next-net/master, thanks.