From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id BC5AF2C74 for ; Tue, 28 Mar 2017 14:34:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490704490; x=1522240490; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=FNm0yDPOKfAs8CfcQxiVCfgsFU2kQMDGv/oz2Y7LYXE=; b=GGHgMqgWhSYo7KZkemr3Ke86JdHuMz2bwWJ4LhsgTHUkmAe+mZpS0zAk GRNVB5YyK/IeDSibeTBNNxyxePraPQ==; Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2017 05:34:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,236,1486454400"; d="scan'208";a="839275603" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by FMSMGA003.fm.intel.com with ESMTP; 28 Mar 2017 05:34:48 -0700 To: Ed Czeck References: <1490231015-31748-1-git-send-email-ed.czeck@atomicrules.com> <1490231015-31748-7-git-send-email-ed.czeck@atomicrules.com> Cc: dev@dpdk.org, Thomas Monjalon , Shepard Siegel , John Miller From: Ferruh Yigit Message-ID: Date: Tue, 28 Mar 2017 13:34:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 7/7] net/ark: Arkville PMD component integration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 12:34:51 -0000 On 3/23/2017 10:19 PM, Ed Czeck wrote: > > On Thu, Mar 23, 2017 at 8:13 AM, Ferruh Yigit > wrote: >> > >> > >> > +static >> > +int >> >> Can be in same line. > Fixed > >> >> > +check_for_ext(struct rte_eth_dev *dev __rte_unused, >> > + struct ark_adapter *ark __rte_unused) >> >> __rte_unused can go away > Fixed > > >> Hi Ed, >> >> Can you give some more details on "user extension" that loaded > dynamically? >> >> How much the driver depends on it, what happens if the library is missing? >> >> And how do you deliver that shared library? >> > Dynamic libraries arem optional user provided extensions to the PMD. The > driver funcations correctly without one. Here is the blurb from our > doc file: doc/guides/nics/ark.rst > > The ARK PMD user extensions are a feature of Arkville’s DPDK > net/ark poll mode driver, allowing users to add their > own code to extend the net/ark functionality without > having to make source code changes to the driver. One motivation for > this capability is that while DPDK provides a rich set of functions > to interact with NIC-like capabilities (e.g. MAC addresses and statistics), > the Arkville RTL IP does not include a MAC. Users can supply their > own MAC or custom FPGA applications, which may require control from > the PMD. The user extension is the means providing the control > between the user's FPGA application and the existing DPDK features via > the PMD. There is no discussion related to this dependency, I guess we can continue to reviewing patches. Anyone believes this must be discussed more, please chime in.